aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Disable checking of presence of companion objects: forces to much.Dmitry Petrashko2015-04-151-1/+3
| | | | Triggers cycles in ExtensionMethods.
* Fix RestoreScopes from destroying companion links.Dmitry Petrashko2015-04-151-0/+14
| | | | Fixes #476
* Ycheck that companions do not disappear.Dmitry Petrashko2015-04-151-0/+12
|
* Companion methods should have Method flag.Dmitry Petrashko2015-04-151-1/+3
|
* Merge pull request #469 from dotty-staging/stylecheckDmitry Petrashko2015-04-10356-1417/+1541
|\ | | | | Add stylechecking to test suite, fix style errors
| * Enable scalastyle on travis.Dmitry Petrashko2015-04-091-1/+1
| |
| * Remove debug message from ClassfileParser.Dmitry Petrashko2015-04-091-4/+0
| |
| * Ensure spaces after `if` in Dotty tests.Dmitry Petrashko2015-04-0917-20/+20
| |
| * Ensure spaces after `if` in Dotty source.Dmitry Petrashko2015-04-0924-51/+51
| |
| * EnsureSingleSpaceAfterTokenChecker doesn't work. Use regexp instead.Dmitry Petrashko2015-04-091-2/+2
| |
| * Use EnsureSingleSpaceAfterTokenChecker to discover forgotten spaces after `if`Dmitry Petrashko2015-04-091-0/+5
| |
| * Disabling SimplifyBooleanExpressionChecker: not have a hard to rewrite ↵Dmitry Petrashko2015-04-091-1/+1
| | | | | | | | | | | | counterexample. TreeUnpickler: 494, rewriting to reduce/fold isn't equivalent. !exists(false) isn't easier to read.
| * Disabling SpacesAfterPlusChecker: false positives for variances.Dmitry Petrashko2015-04-091-1/+1
| |
| * Add spaces around + in tests.Dmitry Petrashko2015-04-0935-86/+86
| |
| * Add spaces around + in dotty source.Dmitry Petrashko2015-04-0930-69/+69
| |
| * We sometimes define object with a lowercase nameDmitry Petrashko2015-04-091-1/+1
| |
| * Disabling more style checks that do not apply to dotty.Dmitry Petrashko2015-04-091-7/+7
| | | | | | | | | | We use structural types in return values, sometimes we override equals without overriding hashcode
| * Remove trailing spaces in Dotty tests.Dmitry Petrashko2015-04-0943-151/+151
| |
| * Remove trailing spaces in Dotty source.Dmitry Petrashko2015-04-0963-634/+634
| |
| * Removing whitespaces before `[`Dmitry Petrashko2015-04-091-2/+2
| |
| * Code simplifications stimulated by SimplifyBooleanExpressionChecker.Dmitry Petrashko2015-04-093-3/+6
| |
| * ScalaStyle gives spurious errors for braces in ifs.Dmitry Petrashko2015-04-091-3/+3
| | | | | | | | | | | | | | | | | | Commonly used in dotty syntax isn't respected by scalastyle: ``` if (...) bar else if (...) foo else foo ```
| * Disable MethodNameChecker.Dmitry Petrashko2015-04-091-1/+1
| | | | | | | | In Dotty we frequently want to make method look like it returns a constructor, when it's actually not.
| * Allow setters in method name reggae.Dmitry Petrashko2015-04-091-1/+1
| |
| * Replace tabs with 4 spaces in Dotty tests.Dmitry Petrashko2015-04-0999-274/+274
| |
| * Replace tabs with 4 spaces in Dotty source.Dmitry Petrashko2015-04-097-26/+26
| |
| * Disable style tests that are known not to pass.Dmitry Petrashko2015-04-091-8/+8
| | | | | | | | Dotty uses returns, nulls, and has methods with huge cyclomatic compexity
| * Make all dotty tests end in newlineDmitry Petrashko2015-04-0931-31/+31
| |
| * Make all Dotty source files end in newline.Dmitry Petrashko2015-04-0973-73/+73
| |
| * Add scalastyle to dependencies, with default config.Dmitry Petrashko2015-04-092-0/+120
|/
* Merge pull request #468 from dotty-staging/add/no-double-bindingsDmitry Petrashko2015-04-091-4/+4
|\ | | | | Add/no double bindings
| * Disabled -Yno-double-bindings for a neg test.Martin Odersky2015-04-091-1/+1
| | | | | | | | | | | | The test introduced a double definition, which led to a double binding. With -Yno-double-bindings this cauases an assertion violation instead of a reported error.
| * Make -Yno-double-bindings the default for all tests.Martin Odersky2015-04-091-3/+3
| |
* | Merge pull request #456 from dotty-staging/patmat-eqeqDmitry Petrashko2015-04-096-11/+49
|\| | | | | Fix #453, patternMatcher should use ==
| * Fixed selection in InterceptedMethods that caused a data raceMartin Odersky2015-04-092-5/+42
| | | | | | | | | | Also, added comments to the tpd select methods that explain how the data race could arise and how to avoid it.
| * Rename -YnoDoubleBindings to -Yno-double-bindingsMartin Odersky2015-04-093-5/+5
| | | | | | | | | | | | | | This aligns with the "-" instead of CamelCase convention for the other command line options. Also, enable -Yno-double-bindings for dotc_core.
| * Fix #453, patternMatcher should use ==Dmitry Petrashko2015-04-091-1/+2
| |
* | Merge pull request #467 from dotty-staging/drop/invalidateCompanionsDmitry Petrashko2015-04-091-14/+0
|\ \ | |/ |/| Drop the invalidate undefined companions code in restoreScopes
| * Drop the invalidate undefined companions code in restoreScopesMartin Odersky2015-04-091-14/+0
|/ | | | | It is no longer needed because companion classes are now tracked with companion$ methods. It also causes unncessary inner classes reads.
* Merge pull request #465 from dotty-staging/fix/picklingDmitry Petrashko2015-04-0916-222/+270
|\ | | | | Fix/pickling
| * Refactor checking in NamedTypes.Dmitry Petrashko2015-04-081-9/+4
| |
| * Simplified unpickling of refined types via nextUnsharedTagMartin Odersky2015-04-071-11/+5
| |
| * Change of TERMREFsymbol/TYPEREFsymbol semanticsMartin Odersky2015-04-075-59/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Used to be "with fixed sym". Now it is: With initial symbol as given in the serialized info. It turns out the only previous uses of (TERM|TYPE)REFsymbol were types that were made symbolic in self types. But exactly that caused that problems in unpickling which we tried to workaround by changing WithFixedSym#newLikeThis. And these fixes became less and less intuitive and still could not solve the problem for good. Last hurdle was pickle-testing all files in ast together. It's much simpler to reserve (TERM|TYPE)REFsymbol for NamedTypes that have an initial symbol. Like the previous "WithFixedSym" pickling, this avoids inifinite recursions in pickling/extmethods.scala. But it also avoids problens with unpickling ast/*.scala. The reason it is better is that it more accurately models that types that exist before pickling. This change also undoes previous changes to WithFixedSym#newlikeThis. Better to keep the more restrictive contract for these.
| * Homogenize #Apply projections.Martin Odersky2015-04-072-1/+14
| | | | | | | | | | | | | | | | Simplify fully applied #Apply projections before comparing trees. Such projections are now (correctly) simplified on unpickling but persist in the original tree before pickling. The discrepancy was uncovered by the last commit.
| * Fix Deferred flag determination when unpicklingMartin Odersky2015-04-071-2/+14
| | | | | | | | | | | | isAbstractType was wrong because it did not follow through SHARED aliases. This was masked before 1b1fb6e5cf7df42000e378c628c8411bce952eb0 but uncovered afterwards.
| * Fixes to double binding check.Martin Odersky2015-04-071-3/+8
| | | | | | | | | | | | | | | | | | | | | | There was a spurious error when doing pickling tests with -YnoDoubleBindings The test manifested itself when compiling `Trees` and `untpd`. The problem was a sourious double assignment to the `untpd$` TypeRef. The problem was that the old `untpd` symbol did get a runId of 3, because it was looked at immediately before being overritten with the new symbol. So the system detected a race condition. The new test looks at the denotations previous run id instead of the symbol's when setting a denotation. That runId was still 2, so not real double binding occurred.
| * Allow change of symbols in WithFixedSym#newLikeThisMartin Odersky2015-04-071-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The symbol might be overridden, in which case the overriding symbol should be chosen. This was observered when trying to pickle test all of ast. Compiling Trees and untpd together gave discrepancies involving `untpd.dotty$tools$dotc$ast$Trees$$Instance$$T`. It was found that the symbol referred to by that type refers to the abstract type in Trees.Instance, not the alias in untpd. The bad type was produced by an asSeenFrom of the `WithFixedSym` type `Instance.this.untpd.dotty$tools$dotc$ast$Trees$$Instance$$T` as seen from `untpd`. The as seen from did not pick the new instance in `untpd`.
| * Move normalizeClassRef to readTemplateMartin Odersky2015-04-071-12/+8
| | | | | | | | | | | | | | | | | | Do a normalizeClassRef immediately after parents are read. Not clear whether this chanegs anything, but it's the prudent thing to do since Namer behaves the same way. The danger would be that between reading parents and normalizing refs someone refers to an overridden param and gets the wrong type.
| * Some more pickling testsMartin Odersky2015-04-071-0/+2
| |
| * Avoid spurious Deferred flag when unpickling classes.Martin Odersky2015-04-071-1/+2
| | | | | | | | For classes rhsIsEmpty is true, but they should not be Deferred.