| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This test case exercised several problems:
1.)2.) Two ways to run into a cyclic references. Fixed by
- assuming an early info when completing a typedef, similarly to what is done for a classdef
- doing wellformed bounds checking in a later phase.
Failure to check whether arguments correspond to F-bounds.
- a substitution was missing.
|
|
|
|
|
| |
Need to compile the self type of a class not in the context of the class members but one context further out.
Reason: self type should not be able to see the members.
|
|\
| |
| | |
Improve test infrastructure
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
1) New method compileFiles which allows one to compile the content of a directory one file or directory
after another.
2) max constraint is printed to typr.
Added new test pos_all. Other pos tests can be retired.
|
|\ \
| |/
|/| |
Bringing back dotc script that was accidentely deleted.
|
| | |
|
|\ \
| |/
|/| |
Try/typer reorg
|
| |
| |
| |
| | |
Common code between tpd and Typer has been factored out into class TypeAssigner.
|
| |
| |
| |
| |
| | |
TypeAssigners assign a toplevel type to a node. They are mixed into Typer, and can be accessed from tpd using
ctx.typeAssigner.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Goal is better modularization and avoiding code duplication and divergence between Typer and tpd. As a first step, we split Inferencing into Inferencing, Checking, and ProtoTypes. Inferencing and Checking become Typer traits, while ProtoTypes remains a global object.
Eventually:
- we want to have a SimpleTyper, which does the main stuff in tpd, and can mixin either full checking or no checking. Each method in SimpleTyper takes an untyped tree (which is assumed to have typed arguments) and adds a toplevel type to that tree. The methods subsume the type-checking parts in Typers, except for
(1) simplifications and expansions (2) computing prototypes and recursing with them into childtrees (3) adaptation. The method calls the necessary checking operations, which may however be stubbed out.
The idea is already exercised in the typechecking code for Literal and New, except that for now it calls methods in tpd (they will become methods in SimpleTyper instead).
- Typer should inherit from SimpleTyper, and forward all logic except for (1) - (3) to it.
- tpd should call the simple typer it gets from ctx.typer
- ctx.typer should be a SimpleTyper, not a complete one.
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
Overloaded TermRefs do not have an info, and consequently do not support =:=. Yet in Typer#checkNewOrShadowed we compared termrefs with =:=. This gives an exception if the termrefs are overloaded. The fix is to provide a new method isSameRef in TypeComparer which is called instead of =:= in Typer#checkNewOrShadowed.
|
| |
| |
| |
| | |
Rewrap needs to produce alternatives with signatures. Otgerwise the new denotation will simply overwrite the old because both the overloaded TermRef and the alternative will hash to the same unique TermRef.
|
|/ |
|
|\
| |
| | |
Get rid of SharedTree
|
| | |
|
|\ \
| | |
| | | |
Tree transformer&TreeTransform
|
| |/
| |
| |
| |
| |
| |
| |
| | |
1) using fast tracks in case node type isn't altered by Transformation;
2) using pre-computed hints(nxTransformXXX arrays) to quickly jump to next transformation interested in transforming particular Tree type;
3) using pre-computed hints(nxPrepareXXX arrays) to know which transformations are going to 'prepare' for transforming particular Tree type;
4) recomputing those hints in case some transformation changed implementation class during 'prepare';
5) TreeTransform is now responsible of calling transformFollowing on nodes created by it.
|
|\ \
| |/
|/| |
Fix of #39
|
| |
| |
| |
| |
| |
| |
| |
| | |
Two fixes:
1) Avoid the infinite recursion in checkAccessible if the accessibility check fails.
2) Make accessibility succeed for the test, and in general if the target denotation does not have a symbol.
Added original test in pos and a negative test which makes accessibility fail.
|
|\ \
| |/
|/| |
Use virtual file instead of temporary file for tests
|
|/ |
|
|\
| |
| | |
Typos, better assertions, dead code
|
| |
| |
| |
| |
| | |
More verbose assertions.
Unnecessary semicolons removed.
|
| | |
|
|\ \
| | |
| | | |
For some tests context is required, it should be passed to checker phase.
|
| |/ |
|
|\ \
| | |
| | | |
Fix/#34 pathresolvers
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The root cause of #34 was that we took a type argument which was an existential type. These are returned as type bounds, which make no sense in the calling context. To avoid that problem in the future, `typeArgs`
got renamed to `argInfos`, so it is clear we get an info, not necessarily a value type. There are
also added method `argTypes`, `argTypesLo`, `argTypesHi`, which return a type, but either throw an exception or return a lower/upper approximation of the argument is an existential type.
There's another issue that the existential type only arose when compiling the same couple fo files the seciond time. We need to chase that one down separately.
|
| | |
| | |
| | |
| | | |
Right now this one fails.
|
|\ \ \
| |_|/
|/| | |
Enable verbose printing of exceptions thrown in junit tests
|
|/ / |
|
|\ \
| |/
|/|
| | |
Infrastructure for per-phase tests, with inline source as a string.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
What was `baseType` and is now `baseTypeRef` only computes the prefix of of basetype, not the type arguments.
If type arguments need to be included there is `baseTypeWithArgs`. The reason is that type arguments are usually already encoded as member types. But this was a source of errors because in Scala 2, baseType includes the type arguements.
(also added test file structural.scala forgotten from last commit)
|
| |
| |
| |
| | |
We need to use Object as parent then, but this was forgotten.
|
| | |
|
| |
| |
| |
| | |
Need to take variances into account when forming & or | of bounds. Achieved by moving code from distributeAnd/Or to TypeBounds &/|.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Template parents always were constructor calls before. This is not correct because in a situation like the one
elaborated in templateParents, the trait D has the class C as supertype, but it does not call its constructor (in fact, if we added a () parameter list to make it into a constructor this would be wrong because C takes parameters.
Now parents can be either types or constructor calls.
The logic in Namer and Typer that deals with parents is cleaned up. In particular, we now construct any synthetic class parent as a full type, before calling normalizeToClassRefs. This obviates the forwardRefs logic that needed to be done in a cleanup of Namers.
Also added two more checks: (1) All parents except the first one must point to traits. (2) A trait may not call a parent class constructor.
|
| |
| |
| |
| |
| | |
1) Untyped trees now have precise isType/isTerm methods.
2) The New(tree, args) method can now also handle TypedSplices.
|
|/
|
|
| |
See examplation in 2nd commit of branch aborted/simplify-hk.
|
| |
|
|
|
|
| |
There were a lot in StoreReporter, as we are creating about 0.5M new ones per self-compile.
|
|
|
|
| |
This avoids the megamorphic dispatch on symbol before. Looked promising in the profiler (symbol showed up at 9%) but does not seem to gain much in practice. Still, can't hurt to do it.
|
|
|
|
| |
into locals.
|
|
|
|
|
|
|
| |
1) We now keep an association between ClassSymbol and SuperId (instead of TypeRef and SuperId). That's better
because superId's are deleted anyway after each run, so we gain nothing by keeping a stable ref.
2) hasChildren got dropped. It was too unreliable. The mere fact that someone take's the superId of a class
does not means that that class has children.
|
|
|
|
|
|
| |
Perform the operation only if there are qualifying type variables, which is rarely the case.
Reverted variances optimization to simpler and shorter previous implementation, because variances
is no longer hot.
|
|
|
|
|
|
| |
- Avoid closure creation in Position.
- Avoid creating debug string in SymDenotations
- Avoid creating Flag translation tables in pickle buffers
|