| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
| |
The test introduced a double definition, which led to a double
binding. With -Yno-double-bindings this cauases an assertion violation
instead of a reported error.
|
| |
|
|
|
|
|
|
|
| |
This aligns with the "-" instead of CamelCase convention for
the other command line options.
Also, enable -Yno-double-bindings for dotc_core.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used to be "with fixed sym". Now it is: With initial symbol
as given in the serialized info.
It turns out the only previous uses of (TERM|TYPE)REFsymbol were
types that were made symbolic in self types. But exactly that caused
that problems in unpickling which we tried to workaround by changing
WithFixedSym#newLikeThis. And these fixes became less and less intuitive and
still could not solve the problem for good. Last hurdle was pickle-testing
all files in ast together.
It's much simpler to reserve (TERM|TYPE)REFsymbol for NamedTypes that have
an initial symbol. Like the previous "WithFixedSym" pickling, this avoids
inifinite recursions in pickling/extmethods.scala. But it also avoids problens
with unpickling ast/*.scala. The reason it is better is that it more accurately
models that types that exist before pickling.
This change also undoes previous changes to WithFixedSym#newlikeThis. Better to keep
the more restrictive contract for these.
|
| |
|
|
|
|
|
|
|
|
| |
... in order to save some time. On my laptop:
Without twice: 175sec
With full twice as in last commit: 220sec
With reduced twice: 188sec
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stillValid should always be tested at the phase where the initial
denotation is defined. If we do not do this we get false stale symbol errors.
Here is a scenario:
To `bringForward` `Predef$$ArrowAsscoc`, we check whether its initial denotation
has an owner which contains the denotation as one of its members. But if we do this
at a later phase (e.g. GenBCode), the owner of the initial denotation is Predef, but
Predef no longer contains ArraoAssoc - it lost the member at flatten.
With this fix we can run everything with -twice, except dotc_core. I left a comment what
goes wrong there.
|
|
|
|
|
| |
When reading external symbols from class Object, need to consider
members of Any as well.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Move pickling tests into separate top-level test directory.
That way they are not needlessly pos-tested before.
Also, disable core tests for now - after rebasing we get a stale symbol error.
Need to investigate that.
|
|
|
|
|
|
|
|
|
| |
1) DefDefs with implicit method types generate implicit parameters
2) Super accessors are inserted after class parameters.
With these changes files in core also print the same after pickling,
with the exception of Types and TypeOps which have some spurious differences:
Types are equal but appear in more simplified form after pickling.
|
|
|
|
|
|
|
|
|
| |
The unpickled term in a package id is different from the original but the
type is the same.
In a literal prefer constants in the types over thsoe in the terms.
With this change, we get identical typed tree output also for core/pickled.
|
|
|
|
|
|
|
|
| |
We got some spurious differences in the types in TemplateParents
because simplification was done in Typer but not in Unpickler.
With the change we get perfect matches for all files in pickleOK
also if we print their types.
|
|
|
|
| |
Some pickling tests are now run on every check in.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lazy fields are
- the rhs field of a ValDef or DefDef
- the body field of a Template
These can be instantiated with Lazy instances.
The scheme is such that lazy fields are completely
transparent for users of the Trees API.
The only downside is that the parameter used to initialize
a potentially lazy field has a weak type (now it's Any, with
Dotty it would be a union type of the form `T | Lazy[T]`.
Therefore, the parameter cannot be recovered through pattern
matching.
|
|
|
|
|
|
|
|
| |
We planned this for a long time but never implemented it. Instead, we sometimes
issued an erro in Splitter, namely if reflection would have been needed to access the
member. It turns out that some tests (e.g. neg/t625) fail -Ycheck (we knew that before
and disabled) but also fail Pickling because they generate orhpan PolyParams. So rather
than patching this up it seems now is a good time to enforce the restriction for real.
|
| |
|
| |
|
| |
|
|
|
|
| |
compiling dotty is stil WIP
|
| |
|
|
|
|
|
| |
The `from` field of a Return tree should either be EmptyTree or an Ident
corresponding to the method we're returning from.
|
|
|
|
|
| |
Proposed to be used from repl: it gives you internal
representation of types after frontend and a context to play with them
|
|
|
|
|
|
|
|
|
|
| |
Dotty requires a mangled bootclasspath to start.
It means that `console` mode of sbt doesn't work for us.
At least I wasn't able to make sbt fork in console,
so instead I've added a Scala-repl into dotty itself :-)
It would be good to make it use dotty one day when we have
a backend :-)
|
|\
| |
| | |
Fix/erasure lub alternative
|
| |
| |
| |
| | |
Will do it in a different PR.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, tests fail. The failures I checked are all related to tailcalls.
Not sure whether there are others.
This is a blocker for serialization. Orphan parameters cannot be serialized.
Maybe rethink the position of tailcalls? It looks to me that the repeated trouble it gives us is
more than the effort required to put an efficient tailcall recognition after pattern matching in place.
But I might be wrong.
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
Fixes two bugs needed for java-override test:
Namer was creating a MethodType instead of a JavaMethodType even though
the JavaDefined flag was set on the DefDef.
Following Scalac, Namer needs to convert Java method parameters
of type j.l.Object to s.Any.
|
| |
|
|
|
|
|
| |
Reformulated matchign spec and implemented accordingly. Previous
fix for #329 would have missed third new error case in over.scala.
|
|
|
|
| |
Overriding pairs needs to match ExprTypes with field types. Closes #329.
|
| |
|
|
|
|
| |
Tests (non)equivalence of modules and their ThisTypes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous scheme did not ensure that transitivity was eliminated.
Example scenario:
We have in the constraint
P <: Q
for constrained variables P, Q and add
Q <: T
Previous propagation added the constraint and then tested
whether the bounds of all variables were satisfiable. For
Q we test
P <: T
but that is true because P <: Q and we already added the constraint Q <: T.
So we fail to add the constraint P <: T, and transitivity is no longer eliminated.
Instead we now test the new bounds (in this case P <: T) *before* adding
the new constraint Q <: T. This is also simpler than the previous scheme.
|
|
|
|
|
|
| |
Symptom was: When compiling Definitions.scala with the changes in the subsequent
commits, an empty tree was passed as implicit parameter, without an "implicit not found"
error being reported. The problem needed a fix in TyperState.
|
|
|
|
|
|
|
|
|
| |
I get very frequent build failures due to the mutual Scala<->Java dependency.
It builds for a long time, then decides that getCtx overrides nothing. The only
way to fix is another clean build. Total time lost: >5 minutes. These happened
occasionally before but have become much more frequent under ScalaIDe4.0, to the
point where this becomes a major drag on productity. Context escape detection
is nice but if it stops us getting work done, not worth the effort.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Remove historical enabling of erasure for some tests: its enabled by default now
|
|\
| |
| | |
Two new tests
|