diff options
author | Nikolay Tatarinov <5min4eq.unity@gmail.com> | 2017-11-24 01:39:26 +0300 |
---|---|---|
committer | Li Haoyi <haoyi.sg@gmail.com> | 2017-11-23 14:39:26 -0800 |
commit | 3416790b6f66925c0ad8b23f8da8fd00714afe50 (patch) | |
tree | 93e1734d0c889652e18332e6b717e54c5920b815 /core | |
parent | 15ce6dc4c5f2650a5d79143577dccefe1efe8221 (diff) | |
download | mill-3416790b6f66925c0ad8b23f8da8fd00714afe50.tar.gz mill-3416790b6f66925c0ad8b23f8da8fd00714afe50.tar.bz2 mill-3416790b6f66925c0ad8b23f8da8fd00714afe50.zip |
Fixes #1. Don't log "Running" of skipped target (#11)
* fixes #1: don't log failed targets as running
* remove pprint logging
Diffstat (limited to 'core')
-rw-r--r-- | core/src/main/scala/mill/eval/Evaluator.scala | 33 |
1 files changed, 26 insertions, 7 deletions
diff --git a/core/src/main/scala/mill/eval/Evaluator.scala b/core/src/main/scala/mill/eval/Evaluator.scala index f91a1e8c..6acfe066 100644 --- a/core/src/main/scala/mill/eval/Evaluator.scala +++ b/core/src/main/scala/mill/eval/Evaluator.scala @@ -67,7 +67,8 @@ class Evaluator(workspacePath: Path, group.toIterator.map(_.sideHash).toVector.hashCode() terminal match{ - case Left(task) => evaluateGroup(group, results, None) + case Left(task) => + evaluateGroup(group, results, targetDestPath = None, maybeTargetLabel = None) case Right(labelledTarget) => val (destPath, metadataPath) = resolveDestPaths(labelledTarget) val cached = for{ @@ -84,16 +85,18 @@ class Evaluator(workspacePath: Path, case _ => - pprint.log(labelledTarget.segments) val Seq(first, rest @_*) = labelledTarget.segments val msgParts = Seq(first.asInstanceOf[Mirror.Segment.Label].value) ++ rest.map{ case Mirror.Segment.Label(s) => "." + s case Mirror.Segment.Cross(s) => "[" + s.mkString(",") + "]" } - log("Running " + msgParts.mkString) if (labelledTarget.target.flushDest) rm(destPath) - val (newResults, newEvaluated) = evaluateGroup(group, results, Some(destPath)) + val (newResults, newEvaluated) = evaluateGroup( + group, + results, + Some(destPath), + maybeTargetLabel = Some(msgParts.mkString)) newResults(labelledTarget.target) match{ case Result.Success(v) => @@ -116,12 +119,28 @@ class Evaluator(workspacePath: Path, def evaluateGroup(group: OSet[Task[_]], results: collection.Map[Task[_], Result[Any]], - targetDestPath: Option[Path]) = { + targetDestPath: Option[Path], + maybeTargetLabel: Option[String] + ) = { val newEvaluated = mutable.Buffer.empty[Task[_]] val newResults = mutable.LinkedHashMap.empty[Task[_], Result[Any]] - for (target <- group.items if !results.contains(target)) { + + val nonEvaluatedTargets = group.indexed.filterNot(results.contains) + + maybeTargetLabel.foreach { targetLabel => + val inputResults = for { + target <- nonEvaluatedTargets + item <- target.inputs.filterNot(group.contains) + } yield results(item) + + val logRun = inputResults.forall(_.isInstanceOf[Result.Success[_]]) + + if(logRun) { log("Running " + targetLabel) } + } + + for (target <- nonEvaluatedTargets) { newEvaluated.append(target) val targetInputValues = target.inputs @@ -152,4 +171,4 @@ object Evaluator{ failing: MultiBiMap[Either[Task[_], LabelledTarget[_]], Result.Failing]){ def values = rawValues.collect{case Result.Success(v) => v} } -}
\ No newline at end of file +} |