summaryrefslogtreecommitdiff
path: root/core
diff options
context:
space:
mode:
authorLi Haoyi <haoyi.sg@gmail.com>2018-01-06 23:25:29 -0800
committerLi Haoyi <haoyi.sg@gmail.com>2018-01-07 00:21:37 -0800
commit7cd18fd936b95410274be031a8231e5a3d9866a4 (patch)
treec3d9a1f4a110dc5f25824eb9f118ea8ebfcd2b37 /core
parenta6febe05a5650274110301a09bb97e4770ea0400 (diff)
downloadmill-7cd18fd936b95410274be031a8231e5a3d9866a4.tar.gz
mill-7cd18fd936b95410274be031a8231e5a3d9866a4.tar.bz2
mill-7cd18fd936b95410274be031a8231e5a3d9866a4.zip
First pass at implicitly propagating a `def basePath: Path` up the `Module` hierarchy, which each module receives and extends.
One constraint is that now must define your abstract modules as `trait`s rather than `class`es, or otherwise add an implicit `ctx: ModuleCtx` parameter to your class definition. So far this lets us remove some explicit `basePath` definitions in `build.sc`. Proper handling of `basePath` in `CrossModule`s is future work
Diffstat (limited to 'core')
-rw-r--r--core/src/main/scala/mill/define/Cross.scala10
-rw-r--r--core/src/main/scala/mill/define/Task.scala35
-rw-r--r--core/src/main/scala/mill/main/MainRunner.scala14
-rw-r--r--core/src/main/scala/mill/package.scala3
-rw-r--r--core/src/test/scala/mill/define/BasePathTests.scala42
-rw-r--r--core/src/test/scala/mill/define/CacherTests.scala6
-rw-r--r--core/src/test/scala/mill/define/MacroErrorTests.scala2
-rw-r--r--core/src/test/scala/mill/discover/CrossModuleTests.scala31
-rw-r--r--core/src/test/scala/mill/discover/DiscoveredTests.scala7
-rw-r--r--core/src/test/scala/mill/eval/EvaluationTests.scala2
-rw-r--r--core/src/test/scala/mill/eval/JavaCompileJarTests.scala4
-rw-r--r--core/src/test/scala/mill/main/MainTests.scala26
-rw-r--r--core/src/test/scala/mill/util/TestGraphs.scala91
-rw-r--r--core/src/test/scala/mill/util/TestUtil.scala16
14 files changed, 190 insertions, 99 deletions
diff --git a/core/src/main/scala/mill/define/Cross.scala b/core/src/main/scala/mill/define/Cross.scala
index 90a383a6..26eef933 100644
--- a/core/src/main/scala/mill/define/Cross.scala
+++ b/core/src/main/scala/mill/define/Cross.scala
@@ -28,4 +28,12 @@ object Cross{
class CrossModule[T, V](constructor: T => V, cases: T*)
(implicit e: sourcecode.Enclosing, l: sourcecode.Line)
-extends Cross[V](cases.toList.map(x => (List(x), constructor(x)))) \ No newline at end of file
+extends Cross[V](cases.toList.map(x => (List(x), constructor(x))))
+
+class CrossModule2[T1, T2, V](constructor: (T1, T2) => V, cases: (T1, T2)*)
+ (implicit e: sourcecode.Enclosing, l: sourcecode.Line)
+extends Cross[V](cases.toList.map(x => (List(x._2, x._1), constructor(x._1, x._2))))
+
+class CrossModule3[T1, T2, T3, V](constructor: (T1, T2, T3) => V, cases: (T1, T2, T3)*)
+ (implicit e: sourcecode.Enclosing, l: sourcecode.Line)
+extends Cross[V](cases.toList.map(x => (List(x._3, x._2, x._1), constructor(x._1, x._2, x._3)))) \ No newline at end of file
diff --git a/core/src/main/scala/mill/define/Task.scala b/core/src/main/scala/mill/define/Task.scala
index 6ee9c606..0704c7c8 100644
--- a/core/src/main/scala/mill/define/Task.scala
+++ b/core/src/main/scala/mill/define/Task.scala
@@ -1,6 +1,7 @@
package mill.define
import ammonite.main.Router.Overrides
+import ammonite.ops.Path
import mill.define.Applicative.Applyable
import mill.eval.{PathRef, Result}
import mill.util.Ctx
@@ -361,10 +362,9 @@ class Input[T](t: Task[T],
def evaluate(args: Ctx) = args[T](0)
override def sideHash = util.Random.nextInt()
}
-
+case class BasePath(value: Path)
object Task {
-
trait TaskModule extends Module {
def defaultCommandName(): String
}
@@ -375,14 +375,37 @@ object Task {
* instantiation site so they can capture the enclosing/line information of
* the concrete instance.
*/
- class Module(implicit millModuleEnclosing0: sourcecode.Enclosing,
- millModuleLine0: sourcecode.Line) extends mill.moduledefs.Cacher{
+ class Module(implicit ctx: Module.Ctx) extends mill.moduledefs.Cacher{
// Ensure we do not propagate the implicit parameters as implicits within
// the body of any inheriting class/trait/objects, as it would screw up any
// one else trying to use sourcecode.{Enclosing,Line} to capture debug info
- val millModuleEnclosing = millModuleEnclosing0
- val millModuleLine = millModuleLine0
+ val millModuleEnclosing = ctx.millModuleEnclosing0
+ val millModuleLine = ctx.millModuleLine0
+ def basePath: Path = ctx.millModuleBasePath0.value / ctx.millName0.value
+ implicit def millModuleBasePath: BasePath = BasePath(basePath)
+ }
+ object Module{
+ case class Ctx(millModuleEnclosing0: sourcecode.Enclosing,
+ millModuleLine0: sourcecode.Line,
+ millName0: sourcecode.Name,
+ millModuleBasePath0: BasePath)
+ object Ctx{
+ implicit def make(implicit millModuleEnclosing0: sourcecode.Enclosing,
+ millModuleLine0: sourcecode.Line,
+ millName0: sourcecode.Name,
+ millModuleBasePath0: BasePath): Ctx = Ctx(
+ millModuleEnclosing0,
+ millModuleLine0,
+ millName0,
+ millModuleBasePath0
+ )
+ }
}
+ class BaseModule(basePath: Path)
+ (implicit millModuleEnclosing0: sourcecode.Enclosing,
+ millModuleLine0: sourcecode.Line,
+ millName0: sourcecode.Name)
+ extends Module()(Module.Ctx.make(implicitly, implicitly, implicitly, BasePath(basePath)))
class Task0[T](t: T) extends Task[T]{
lazy val t0 = t
diff --git a/core/src/main/scala/mill/main/MainRunner.scala b/core/src/main/scala/mill/main/MainRunner.scala
index 76e2d069..322795ea 100644
--- a/core/src/main/scala/mill/main/MainRunner.scala
+++ b/core/src/main/scala/mill/main/MainRunner.scala
@@ -75,15 +75,12 @@ class MainRunner(config: ammonite.main.Cli.Config,
}
override def initMain(isRepl: Boolean) = {
super.initMain(isRepl).copy(
- scriptCodeWrapper = mill.main.MainRunner.CustomCodeWrapper,
+ scriptCodeWrapper = CustomCodeWrapper,
// Ammonite does not properly forward the wd from CliConfig to Main, so
// force forward it outselves
wd = config.wd
)
}
-}
-
-object MainRunner{
object CustomCodeWrapper extends Preprocessor.CodeWrapper {
def top(pkgName: Seq[Name], imports: Imports, indexedWrapperName: Name) = {
val wrapName = indexedWrapperName.backticked
@@ -93,14 +90,17 @@ object MainRunner{
|$imports
|import mill._
|
- |object $wrapName extends $wrapName{
+ |object $wrapName extends mill.define.Task.BaseModule(ammonite.ops.Path(${pprint.Util.literalize(config.wd.toString)})) with $wrapName{
+ | // Make sure we don't include the `build` wrapper-object's name in
+ | // the `basePath`s of our build
+ | override def basePath = super.basePath / ammonite.ops.up
| // Stub to make sure Ammonite has something to call after it evaluates a script,
| // even if it does nothing...
| def $$main() = Iterator[String]()
| lazy val mapping = mill.discover.Discovered.make[$wrapName].mapping(this)
|}
|
- |sealed abstract class $wrapName extends mill.Module{
+ |sealed trait $wrapName extends mill.Module{
|""".stripMargin
}
@@ -112,4 +112,4 @@ object MainRunner{
"\n}"
}
}
-} \ No newline at end of file
+}
diff --git a/core/src/main/scala/mill/package.scala b/core/src/main/scala/mill/package.scala
index b7332f9e..f833b82c 100644
--- a/core/src/main/scala/mill/package.scala
+++ b/core/src/main/scala/mill/package.scala
@@ -6,5 +6,8 @@ package object mill extends JsonFormatters{
val PathRef = mill.eval.PathRef
type PathRef = mill.eval.PathRef
type Module = define.Task.Module
+ val Module = define.Task.Module
type CrossModule[T, V] = define.CrossModule[T, V]
+ type CrossModule2[T1, T2, V] = define.CrossModule2[T1, T2, V]
+ type CrossModule3[T1, T2, T3, V] = define.CrossModule3[T1, T2, T3, V]
}
diff --git a/core/src/test/scala/mill/define/BasePathTests.scala b/core/src/test/scala/mill/define/BasePathTests.scala
new file mode 100644
index 00000000..67b6dc3c
--- /dev/null
+++ b/core/src/test/scala/mill/define/BasePathTests.scala
@@ -0,0 +1,42 @@
+package mill.define
+
+import mill.util.TestGraphs
+import utest._
+import ammonite.ops.pwd
+object BasePathTests extends TestSuite{
+ val testGraphs = new TestGraphs
+ val tests = Tests{
+ 'singleton - {
+ assert(
+ testGraphs.singleton.millModuleBasePath ==
+ BasePath(pwd / "mill.util.TestGraphs#singleton" / "singleton")
+ )
+ }
+ 'separateGroups - {
+ assert(
+ TestGraphs.separateGroups.millModuleBasePath ==
+ BasePath(pwd / "mill.util.TestGraphs.separateGroups" / "separateGroups")
+ )
+ }
+ 'TraitWithModuleObject - {
+ assert(
+ TestGraphs.TraitWithModuleObject.TraitModule.millModuleBasePath ==
+ BasePath(pwd / "mill.util.TestGraphs.TraitWithModuleObject" / "TraitWithModuleObject" / "TraitModule")
+ )
+ }
+ 'nestedModuleNested - {
+ assert(
+ TestGraphs.nestedModule.nested.millModuleBasePath ==
+ BasePath(pwd / "mill.util.TestGraphs.nestedModule" / "nestedModule" / "nested")
+ )
+ }
+ 'nestedModuleInstance - {
+ assert(
+ TestGraphs.nestedModule.classInstance.millModuleBasePath ==
+ BasePath(pwd / "mill.util.TestGraphs.nestedModule" / "nestedModule" / "classInstance")
+ )
+ }
+
+ }
+}
+
diff --git a/core/src/test/scala/mill/define/CacherTests.scala b/core/src/test/scala/mill/define/CacherTests.scala
index e46c0390..faf274f2 100644
--- a/core/src/test/scala/mill/define/CacherTests.scala
+++ b/core/src/test/scala/mill/define/CacherTests.scala
@@ -2,7 +2,7 @@ package mill.define
import mill.discover.Discovered
import mill.eval.Evaluator
-import mill.util.{DummyLogger, OSet}
+import mill.util.{DummyLogger, OSet, TestUtil}
import mill.T
import mill.eval.Result.Success
import utest._
@@ -10,7 +10,7 @@ import utest.framework.TestPath
object CacherTests extends TestSuite{
object Base extends Base
- trait Base extends Task.Module{
+ trait Base extends TestUtil.BaseModule{
def value = T{ 1 }
def result = T{ Success(1) }
}
@@ -19,7 +19,7 @@ object CacherTests extends TestSuite{
def value = T{ super.value() + 2}
def overriden = T{ super.value()}
}
- object Terminal extends Terminal
+ object Terminal extends Terminal
trait Terminal extends Middle{
override def value = T{ super.value() + 4}
}
diff --git a/core/src/test/scala/mill/define/MacroErrorTests.scala b/core/src/test/scala/mill/define/MacroErrorTests.scala
index fd0116d8..7c1bd3a1 100644
--- a/core/src/test/scala/mill/define/MacroErrorTests.scala
+++ b/core/src/test/scala/mill/define/MacroErrorTests.scala
@@ -11,7 +11,7 @@ object MacroErrorTests extends TestSuite{
val expectedMsg =
"T{} members must be defs defined in a Cacher class/trait/object body"
- val err = compileError("object Foo extends Module{ val x = T{1} }")
+ val err = compileError("object Foo extends TestUtil.BaseModule{ val x = T{1} }")
assert(err.msg == expectedMsg)
}
diff --git a/core/src/test/scala/mill/discover/CrossModuleTests.scala b/core/src/test/scala/mill/discover/CrossModuleTests.scala
index e0a7a1a0..6ae3d622 100644
--- a/core/src/test/scala/mill/discover/CrossModuleTests.scala
+++ b/core/src/test/scala/mill/discover/CrossModuleTests.scala
@@ -7,17 +7,17 @@ import mill.discover.Mirror.Segment.Label
import mill.util.TestUtil.test
import utest._
import mill.util.TestGraphs._
+import mill.util.TestUtil
object CrossModuleTests extends TestSuite{
val tests = Tests{
'cross - {
- object outer{
- val crossed =
- for(n <- Cross("2.10.6", "2.11.8", "2.12.4"))
- yield new Module{
- def scalaVersion = n
- }
+ object outer extends TestUtil.BaseModule {
+ object crossed extends mill.CrossModule(CrossedModule, "2.10.6", "2.11.8", "2.12.4")
+ case class CrossedModule(n: String) extends Module{
+ def scalaVersion = n
+ }
}
val discovered = Discovered.make[outer.type]
@@ -36,15 +36,16 @@ object CrossModuleTests extends TestSuite{
}
}
'doubleCross - {
- object outer{
- val crossed =
- for{
- platform <- Cross("", "sjs0.6", "native0.3")
- scalaVersion <- Cross("2.10.6", "2.11.8", "2.12.4")
- if !(platform == "native0.3" && scalaVersion == "2.10.6")
- } yield new Module{
- def suffix = Seq(scalaVersion, platform).filter(_.nonEmpty).map("_"+_).mkString
- }
+ object outer extends TestUtil.BaseModule {
+ val crossMatrix = for{
+ platform <- Seq("", "sjs0.6", "native0.3")
+ scalaVersion <- Seq("2.10.6", "2.11.8", "2.12.4")
+ if !(platform == "native0.3" && scalaVersion == "2.10.6")
+ } yield (platform, scalaVersion)
+ object crossed extends mill.CrossModule2(CrossModule, crossMatrix:_*)
+ case class CrossModule(platform: String, scalaVersion: String) extends mill.Module{
+ def suffix = Seq(scalaVersion, platform).filter(_.nonEmpty).map("_"+_).mkString
+ }
}
val Some((gen, innerMirror)) = Discovered.make[outer.type]
diff --git a/core/src/test/scala/mill/discover/DiscoveredTests.scala b/core/src/test/scala/mill/discover/DiscoveredTests.scala
index 1a22e901..d141352e 100644
--- a/core/src/test/scala/mill/discover/DiscoveredTests.scala
+++ b/core/src/test/scala/mill/discover/DiscoveredTests.scala
@@ -7,6 +7,7 @@ import utest._
import mill.{Module, T}
import mill.discover.Mirror.Segment.Label
import mill.util.TestGraphs.{TraitWithModuleObject, nestedModule}
+import mill.util.TestUtil
object DiscoveredTests extends TestSuite{
val tests = Tests{
@@ -49,7 +50,7 @@ object DiscoveredTests extends TestSuite{
}
'commands - {
- object outer extends mill.Module{
+ object outer extends TestUtil.BaseModule{
def hello() = T.command{
println("Hello")
}
@@ -91,7 +92,7 @@ object DiscoveredTests extends TestSuite{
'unserializableTarget - {
- object outer extends Module {
+ object outer extends TestUtil.BaseModule {
val error = compileError("def single = mill.T{ new InputStreamReader(System.in) }")
}
@@ -103,7 +104,7 @@ object DiscoveredTests extends TestSuite{
}
'unreadableCommand - {
- object outer extends Module {
+ object outer extends TestUtil.BaseModule {
def single(in: InputStreamReader) = mill.T.command{ println(123) }
}
diff --git a/core/src/test/scala/mill/eval/EvaluationTests.scala b/core/src/test/scala/mill/eval/EvaluationTests.scala
index fb3f6b97..54e184b5 100644
--- a/core/src/test/scala/mill/eval/EvaluationTests.scala
+++ b/core/src/test/scala/mill/eval/EvaluationTests.scala
@@ -212,7 +212,7 @@ object EvaluationTests extends TestSuite{
// up middle -- down
// /
// right
- object build extends Module{
+ object build extends TestUtil.BaseModule{
var leftCount = 0
var rightCount = 0
var middleCount = 0
diff --git a/core/src/test/scala/mill/eval/JavaCompileJarTests.scala b/core/src/test/scala/mill/eval/JavaCompileJarTests.scala
index ca317a06..47e09ec3 100644
--- a/core/src/test/scala/mill/eval/JavaCompileJarTests.scala
+++ b/core/src/test/scala/mill/eval/JavaCompileJarTests.scala
@@ -7,7 +7,7 @@ import mill.discover.Discovered
import mill.modules.Jvm
import mill.util.Ctx.DestCtx
import mill.{Module, T}
-import mill.util.{DummyLogger, OSet}
+import mill.util.{DummyLogger, OSet, TestUtil}
import utest._
import mill._
@@ -28,7 +28,7 @@ object JavaCompileJarTests extends TestSuite{
mkdir(pwd / 'target / 'workspace / 'javac)
cp(javacSrcPath, javacDestPath)
- object Build extends Module{
+ object Build extends TestUtil.BaseModule{
def sourceRootPath = javacDestPath / 'src
def resourceRootPath = javacDestPath / 'resources
diff --git a/core/src/test/scala/mill/main/MainTests.scala b/core/src/test/scala/mill/main/MainTests.scala
index 3e0f606b..320731fa 100644
--- a/core/src/test/scala/mill/main/MainTests.scala
+++ b/core/src/test/scala/mill/main/MainTests.scala
@@ -47,19 +47,19 @@ object MainTests extends TestSuite{
'neg2 - check(mapping(singleCross), "cross[doesntExist].doesntExist", Left("Cannot resolve cross cross[doesntExist]"))
'neg2 - check(mapping(singleCross), "cross[doesntExist].suffix", Left("Cannot resolve cross cross[doesntExist]"))
}
- 'double - {
-
- 'pos1 - check(
- mapping(doubleCross),
- "cross[jvm,210].suffix",
- Right(doubleCross.cross("jvm", "210").suffix)
- )
- 'pos2 - check(
- mapping(doubleCross),
- "cross[jvm,211].suffix",
- Right(doubleCross.cross("jvm", "211").suffix)
- )
- }
+// 'double - {
+//
+// 'pos1 - check(
+// mapping(doubleCross),
+// "cross[jvm,210].suffix",
+// Right(doubleCross.cross("jvm", "210").suffix)
+// )
+// 'pos2 - check(
+// mapping(doubleCross),
+// "cross[jvm,211].suffix",
+// Right(doubleCross.cross("jvm", "211").suffix)
+// )
+// }
'nested - {
'indirect - {
'pos1 - check(
diff --git a/core/src/test/scala/mill/util/TestGraphs.scala b/core/src/test/scala/mill/util/TestGraphs.scala
index 25c806fa..64fc4737 100644
--- a/core/src/test/scala/mill/util/TestGraphs.scala
+++ b/core/src/test/scala/mill/util/TestGraphs.scala
@@ -1,5 +1,6 @@
package mill.util
import TestUtil.test
+import mill.define.CrossModule
import mill.{Module, T}
/**
@@ -15,18 +16,18 @@ import mill.{Module, T}
*/
class TestGraphs(){
// single
- object singleton extends Module{
+ object singleton extends TestUtil.BaseModule {
val single = test()
}
// up---down
- object pair extends Module {
+ object pair extends TestUtil.BaseModule{
val up = test()
val down = test(up)
}
// up---o---down
- object anonTriple extends Module{
+ object anonTriple extends TestUtil.BaseModule {
val up = test()
val down = test(test.anon(up))
}
@@ -36,7 +37,7 @@ class TestGraphs(){
// up down
// \ /
// right
- object diamond extends Module{
+ object diamond extends TestUtil.BaseModule {
val up = test()
val left = test(up)
val right = test(up)
@@ -48,12 +49,12 @@ class TestGraphs(){
// up down
// \ /
// o
- object anonDiamond extends Module{
+ object anonDiamond extends TestUtil.BaseModule {
val up = test()
val down = test(test.anon(up), test.anon(up))
}
- object defCachedDiamond extends Module{
+ object defCachedDiamond extends TestUtil.BaseModule {
def up = T{ test() }
def left = T{ test(up) }
def right = T{ test(up) }
@@ -61,14 +62,14 @@ class TestGraphs(){
}
- object borkedCachedDiamond2 extends Module {
+ object borkedCachedDiamond2 extends TestUtil.BaseModule {
def up = test()
def left = test(up)
def right = test(up)
def down = test(left, right)
}
- object borkedCachedDiamond3 extends Module {
+ object borkedCachedDiamond3 extends TestUtil.BaseModule {
def up = test()
def left = test(up)
def right = test(up)
@@ -86,7 +87,7 @@ class TestGraphs(){
// o o---F---o
// / /
// o--B o
- object bigSingleTerminal extends Module{
+ object bigSingleTerminal extends TestUtil.BaseModule {
val a = test(test.anon(), test.anon())
val b = test(test.anon())
val e = {
@@ -113,7 +114,7 @@ object TestGraphs{
// task1 -------- right
// _/
// change - task2
- object separateGroups extends Module{
+ object separateGroups extends TestUtil.BaseModule {
val task1 = T.task{ 1 }
def left = T{ task1() }
val change = test()
@@ -125,7 +126,7 @@ object TestGraphs{
// _ left _
// / \
// task -------- right
- object triangleTask extends Module{
+ object triangleTask extends TestUtil.BaseModule {
val task = T.task{ 1 }
def left = T{ task() }
def right = T{ task() + left() + 1 }
@@ -135,7 +136,7 @@ object TestGraphs{
// _ left
// /
// task -------- right
- object multiTerminalGroup extends Module{
+ object multiTerminalGroup extends TestUtil.BaseModule {
val task = T.task{ 1 }
def left = T{ task() }
def right = T{ task() }
@@ -144,7 +145,7 @@ object TestGraphs{
// _ left _____________
// / \ \
// task1 -------- right ----- task2
- object multiTerminalBoundary extends Module{
+ object multiTerminalBoundary extends TestUtil.BaseModule {
val task1 = T.task{ 1 }
def left = T{ task1() }
def right = T{ task1() + left() + 1 }
@@ -152,13 +153,13 @@ object TestGraphs{
}
- class CanNest extends Module{
+ trait CanNest extends Module{
def single = T{ 1 }
def invisible: Any = T{ 2 }
def invisible2: mill.define.Task[Int] = T{ 3 }
def invisible3: mill.define.Task[_] = T{ 4 }
}
- object nestedModule extends Module{
+ object nestedModule extends TestUtil.BaseModule {
def single = T{ 5 }
def invisible: Any = T{ 6 }
object nested extends Module{
@@ -166,7 +167,7 @@ object TestGraphs{
def invisible: Any = T{ 8 }
}
- val classInstance = new CanNest
+ object classInstance extends CanNest
}
@@ -174,7 +175,7 @@ object TestGraphs{
def foo = T{ Seq("base") }
}
- object canOverrideSuper extends BaseModule {
+ object canOverrideSuper extends TestUtil.BaseModule with BaseModule {
override def foo = T{ super.foo() ++ Seq("object") }
}
@@ -187,46 +188,44 @@ object TestGraphs{
// Make sure nested objects inherited from traits work
- object TraitWithModuleObject extends TraitWithModule
+ object TraitWithModuleObject extends TestUtil.BaseModule with TraitWithModule
- object singleCross{
- val cross =
- for(scalaVersion <- mill.define.Cross("210", "211", "212"))
- yield new mill.Module{
- def suffix = T{ scalaVersion }
- }
+ object singleCross extends TestUtil.BaseModule {
+ object cross extends mill.CrossModule(CrossModule, "210", "211", "212")
+ case class CrossModule(scalaVersion: String) extends Module{
+ def suffix = T{ scalaVersion }
+ }
}
- object doubleCross{
- val cross = for{
- scalaVersion <- mill.define.Cross("210", "211", "212")
- platform <- mill.define.Cross("jvm", "js", "native")
+ object doubleCross extends TestUtil.BaseModule {
+ val crossMatrix = for{
+ scalaVersion <- Seq("210", "211", "212")
+ platform <- Seq("jvm", "js", "native")
if !(platform == "native" && scalaVersion != "212")
- } yield new Module{
+ } yield (scalaVersion, platform)
+ object cross extends mill.CrossModule2(CrossModule, crossMatrix:_*)
+ case class CrossModule(scalaVersion: String, platform: String) extends Module{
def suffix = T{ scalaVersion + "_" + platform }
}
}
- object indirectNestedCrosses{
- val cross = mill.define.Cross("210", "211", "212").map(new cross(_))
- class cross(scalaVersion: String) extends mill.Module{
- val cross2 =
- for(platform <- mill.define.Cross("jvm", "js", "native"))
- yield new mill.Module{
- def suffix = T{ scalaVersion + "_" + platform }
- }
+ object indirectNestedCrosses extends TestUtil.BaseModule {
+ object cross extends mill.CrossModule(CrossModule, "210", "211", "212")
+ case class CrossModule(scalaVersion: String) extends mill.Module{
+ object cross2 extends mill.CrossModule(CrossModule, "jvm", "js", "native")
+ case class CrossModule(platform: String) extends mill.Module{
+ def suffix = T{ scalaVersion + "_" + platform }
+ }
}
}
- object nestedCrosses{
- val cross =
- for(scalaVersion <- mill.define.Cross("210", "211", "212"))
- yield new mill.Module{
- val cross2 =
- for(platform <- mill.define.Cross("jvm", "js", "native"))
- yield new mill.Module{
- def suffix = T{ scalaVersion + "_" + platform }
- }
+ object nestedCrosses extends TestUtil.BaseModule {
+ object cross extends mill.CrossModule(CrossModule, "210", "211", "212")
+ case class CrossModule(scalaVersion: String) extends mill.Module{
+ object cross2 extends mill.CrossModule(CrossModule, "jvm", "js", "native")
+ case class CrossModule(platform: String) extends mill.Module{
+ def suffix = T{ scalaVersion + "_" + platform }
}
+ }
}
}
diff --git a/core/src/test/scala/mill/util/TestUtil.scala b/core/src/test/scala/mill/util/TestUtil.scala
index 0d28fcf6..8cb1c375 100644
--- a/core/src/test/scala/mill/util/TestUtil.scala
+++ b/core/src/test/scala/mill/util/TestUtil.scala
@@ -1,13 +1,27 @@
package mill.util
import ammonite.main.Router.Overrides
-import mill.define.{Caller, Target, Task}
+import ammonite.ops.Path
+import mill.define.Task.Module
+import mill.define.{BasePath, Caller, Target, Task}
import mill.eval.Result
import utest.assert
+import utest.framework.TestPath
import scala.collection.mutable
object TestUtil {
+ class BaseModule(implicit millModuleEnclosing0: sourcecode.Enclosing,
+ millModuleLine0: sourcecode.Line,
+ millName0: sourcecode.Name)
+ extends Module()(
+ Module.Ctx.make(
+ implicitly,
+ implicitly,
+ implicitly,
+ BasePath(ammonite.ops.pwd / millModuleEnclosing0.value)
+ )
+ )
object test{
def anon(inputs: Task[Int]*) = new Test(inputs)