diff options
author | Gregory Nutt <gnutt@nuttx.org> | 2014-11-25 15:26:30 -0600 |
---|---|---|
committer | Gregory Nutt <gnutt@nuttx.org> | 2014-11-25 15:26:30 -0600 |
commit | 76d6af0fd310967d8bf08d01cfc1db00e4a0c757 (patch) | |
tree | 963a7f1a3e29449a2389cfbe0053d608e7e9d16a /apps/netutils/ftpc | |
parent | 6b0412f5128e2fdf94852de586b3f90cbf476240 (diff) | |
download | nuttx-76d6af0fd310967d8bf08d01cfc1db00e4a0c757.tar.gz nuttx-76d6af0fd310967d8bf08d01cfc1db00e4a0c757.tar.bz2 nuttx-76d6af0fd310967d8bf08d01cfc1db00e4a0c757.zip |
Fixes for more issues found by cppcheck
Diffstat (limited to 'apps/netutils/ftpc')
-rw-r--r-- | apps/netutils/ftpc/ftpc_chmod.c | 3 | ||||
-rw-r--r-- | apps/netutils/ftpc/ftpc_rpwd.c | 4 | ||||
-rw-r--r-- | apps/netutils/ftpc/ftpc_transfer.c | 7 |
3 files changed, 6 insertions, 8 deletions
diff --git a/apps/netutils/ftpc/ftpc_chmod.c b/apps/netutils/ftpc/ftpc_chmod.c index e5cd48b46..ea84c66de 100644 --- a/apps/netutils/ftpc/ftpc_chmod.c +++ b/apps/netutils/ftpc/ftpc_chmod.c @@ -79,13 +79,12 @@ int ftpc_chmod(SESSION handle, FAR const char *path, FAR const char *mode) { FAR struct ftpc_session_s *session = (FAR struct ftpc_session_s *)handle; - int ret; /* Does the server support the size CHMOD command? */ if (FTPC_HAS_CHMOD(session)) { - ret = ftpc_cmd(session, "SITE CHMOD %s %s", path, mode); + (void)ftpc_cmd(session, "SITE CHMOD %s %s", path, mode); /* Check for "502 Command not implemented" */ diff --git a/apps/netutils/ftpc/ftpc_rpwd.c b/apps/netutils/ftpc/ftpc_rpwd.c index 91dd1504f..1f87f5f14 100644 --- a/apps/netutils/ftpc/ftpc_rpwd.c +++ b/apps/netutils/ftpc/ftpc_rpwd.c @@ -87,11 +87,10 @@ FAR char *ftpc_rpwd(SESSION handle) FAR char *pwd; FAR char *ptr; int len; - int ret; /* Send the PWD command */ - ret = ftpc_cmd(session, "PWD"); + (void)ftpc_cmd(session, "PWD"); /* Response is like: 257 "/home/gnutt" (from vsftpd). * @@ -147,5 +146,6 @@ FAR char *ftpc_rpwd(SESSION handle) *ptr = '/'; } } + return pwd; } diff --git a/apps/netutils/ftpc/ftpc_transfer.c b/apps/netutils/ftpc/ftpc_transfer.c index e26d7e87b..8dbb2d0ad 100644 --- a/apps/netutils/ftpc/ftpc_transfer.c +++ b/apps/netutils/ftpc/ftpc_transfer.c @@ -171,7 +171,6 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, FAR const char *curdir) { FAR char *ptr = NULL; - int ret = OK; /* If no relative path was provide, then use the current working directory */ @@ -195,7 +194,7 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else if (relpath[1] == '/') { - ret = asprintf(&ptr, "%s%s", homedir, &relpath[1]); + (void)asprintf(&ptr, "%s%s", homedir, &relpath[1]); } /* Hmmm... this pretty much guaranteed to fail */ @@ -212,7 +211,7 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else if (strncmp(relpath, "./", 2) == 0) { - ret = asprintf(&ptr, "%s%s", curdir, relpath+1); + (void)asprintf(&ptr, "%s%s", curdir, relpath+1); } /* Check for an absolute path */ @@ -226,7 +225,7 @@ static FAR char *ftpc_abspath(FAR struct ftpc_session_s *session, else { - ret = asprintf(&ptr, "%s/%s", curdir, relpath); + (void)asprintf(&ptr, "%s/%s", curdir, relpath); } return ptr; |