diff options
| author | Feng Xiao <xfxyjwf@gmail.com> | 2015-08-26 22:40:41 +0100 |
|---|---|---|
| committer | Feng Xiao <xfxyjwf@gmail.com> | 2015-08-26 22:40:41 +0100 |
| commit | d9f4636818e6f935df98c17d875217210a123917 (patch) | |
| tree | 3f37ef4e9b06871d28bf7f7c4da69daba74ea8e6 | |
| parent | b47bf4c9300c8effa9c93ca1cc5cc51a12c8e119 (diff) | |
| download | protobuf-d9f4636818e6f935df98c17d875217210a123917.tar.gz protobuf-d9f4636818e6f935df98c17d875217210a123917.tar.bz2 protobuf-d9f4636818e6f935df98c17d875217210a123917.zip | |
Add a TODO to clean-up the LITTLE_ENDIAN macro.
| -rw-r--r-- | src/google/protobuf/stubs/port.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/google/protobuf/stubs/port.h b/src/google/protobuf/stubs/port.h index 55c41685..9ea34cde 100644 --- a/src/google/protobuf/stubs/port.h +++ b/src/google/protobuf/stubs/port.h @@ -47,6 +47,9 @@ #undef PROTOBUF_LITTLE_ENDIAN #ifdef _WIN32 // Assuming windows is always little-endian. + // TODO(xiaofeng): The PROTOBUF_LITTLE_ENDIAN is not only used for + // optimization but also for correctness. We should define an + // different macro to test the big-endian code path in coded_stream. #if !defined(PROTOBUF_DISABLE_LITTLE_ENDIAN_OPT_FOR_TEST) #define PROTOBUF_LITTLE_ENDIAN 1 #endif |