aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Cozzette <acozzette@gmail.com>2016-12-21 13:45:49 -0800
committerPaul Yang <TeBoring@users.noreply.github.com>2016-12-21 13:45:49 -0800
commitc7cbf5fc373efb6c054906391f98892e955a60b1 (patch)
treed4e9a3f7bb911437b2e89bb4a504c14e13bf3c00
parente02ff1a1943f3a9040619cb472a8e82128b690e9 (diff)
downloadprotobuf-c7cbf5fc373efb6c054906391f98892e955a60b1.tar.gz
protobuf-c7cbf5fc373efb6c054906391f98892e955a60b1.tar.bz2
protobuf-c7cbf5fc373efb6c054906391f98892e955a60b1.zip
maps_test.js: check whether Symbol is defined before using it (#2524)
Symbol is not yet available on older versions of Node.js and so this test fails with them. This change just directly checks whether Symbol is available before we try to use it.
-rwxr-xr-xjs/maps_test.js9
1 files changed, 3 insertions, 6 deletions
diff --git a/js/maps_test.js b/js/maps_test.js
index bb1696f1..e8dd2f21 100755
--- a/js/maps_test.js
+++ b/js/maps_test.js
@@ -302,8 +302,7 @@ function makeTests(msgInfo, submessageCtor, suffix) {
assertElementsEquals(entryIterator.next().value, ['key2', 'value2']);
assertEquals(entryIterator.next().done, true);
- if (!goog.userAgent.IE) {
- // Symbol is not defined in IE
+ if (typeof(Symbol) != 'undefined') {
var entryIterable = m.entries()[Symbol.iterator]();
assertElementsEquals(entryIterable.next().value, ['key1', 'value1']);
assertElementsEquals(entryIterable.next().value, ['key2', 'value2']);
@@ -315,8 +314,7 @@ function makeTests(msgInfo, submessageCtor, suffix) {
assertEquals(keyIterator.next().value, 'key2');
assertEquals(keyIterator.next().done, true);
- if (!goog.userAgent.IE) {
- // Symbol is not defined in IE
+ if (typeof(Symbol) != 'undefined') {
var keyIterable = m.keys()[Symbol.iterator]();
assertEquals(keyIterable.next().value, 'key1');
assertEquals(keyIterable.next().value, 'key2');
@@ -327,8 +325,7 @@ function makeTests(msgInfo, submessageCtor, suffix) {
assertEquals(valueIterator.next().value, 'value2');
assertEquals(valueIterator.next().done, true);
- if (!goog.userAgent.IE) {
- // Symbol is not defined in IE
+ if (typeof(Symbol) != 'undefined') {
var valueIterable = m.values()[Symbol.iterator]();
assertEquals(valueIterable.next().value, 'value1');
assertEquals(valueIterable.next().value, 'value2');