diff options
author | Jon Skeet <jonskeet@google.com> | 2015-11-19 09:40:49 +0000 |
---|---|---|
committer | Jon Skeet <jonskeet@google.com> | 2015-11-19 09:40:49 +0000 |
commit | 360feda5f76e62a3a8e5b086bdb3b851f7730f2e (patch) | |
tree | 0ab0f79a8121e4c8a5d49afc6caae561963f7ed4 | |
parent | eadd4caa09a0ce063cbe5298146d4e5da15da89e (diff) | |
download | protobuf-360feda5f76e62a3a8e5b086bdb3b851f7730f2e.tar.gz protobuf-360feda5f76e62a3a8e5b086bdb3b851f7730f2e.tar.bz2 protobuf-360feda5f76e62a3a8e5b086bdb3b851f7730f2e.zip |
Finished an implementation comment
-rw-r--r-- | csharp/src/Google.Protobuf/MessageParser.cs | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/csharp/src/Google.Protobuf/MessageParser.cs b/csharp/src/Google.Protobuf/MessageParser.cs index f911c9dd..81be3c2a 100644 --- a/csharp/src/Google.Protobuf/MessageParser.cs +++ b/csharp/src/Google.Protobuf/MessageParser.cs @@ -157,7 +157,9 @@ namespace Google.Protobuf public sealed class MessageParser<T> : MessageParser where T : IMessage<T> { // Implementation note: all the methods here *could* just delegate up to the base class and cast the result. - // The + // The current implementation avoids a virtual method call and a cast, which *may* be significant in some cases. + // Benchmarking work is required to measure the significance - but it's only a few lines of code in any case. + // The API wouldn't change anyway - just the implementation - so this work can be deferred. private readonly Func<T> factory; /// <summary> |