diff options
author | Nico Weber <thakis@chromium.org> | 2018-02-07 08:55:36 -0500 |
---|---|---|
committer | Nico Weber <thakis@chromium.org> | 2018-02-07 08:55:36 -0500 |
commit | c66dd6c2760f0edeaa2529f25668f025a9f5dd0c (patch) | |
tree | da4bac9b22ff1eab2f1a4c7b330e7f6feef69234 /LICENSE | |
parent | 82e02316072f38f994395b1620cda2aff927dd0f (diff) | |
download | protobuf-c66dd6c2760f0edeaa2529f25668f025a9f5dd0c.tar.gz protobuf-c66dd6c2760f0edeaa2529f25668f025a9f5dd0c.tar.bz2 protobuf-c66dd6c2760f0edeaa2529f25668f025a9f5dd0c.zip |
Remove use of GOOGLE_FALLTHROUGH_INTENDED from protobuf.
Chrome is running into two issues with the use of this macro
in open-source protobuf (https://crbug.com/809157):
1. GOOGLE_FALLTHROUGH_INTENDED is defined to nothing on __APPLE__
platforms, which blocks us from enabling -Wimplicit-fallthrough
on Mac and iOS. (We use a hermetic self-built modern clang,
so whatever Xcode bug that exclusion might be for doesn't apply
to us.)
2. It's in a public header file, and it's included in a public header file.
When clang suggests adding [[clang::fallthrough]], it checks if it knows of
a macro expanding to that and if so, suggests inserting that. Since lots of
chrome code includes protobuf headers, it often suggests inserting
GOOGLE_FALLTHROUGH_INTENDED (from protobuf) instead of the correct
FALLTHROUGH (from chrome's base).
Since the fallthrough doens't do anyting useful, just remove it.
Long ago, this might have had perf impact, but d64a2d9941c36a7bc added a
parsing fast path that calls this switch as slow fallback, so it should
be off the hot path nowadays.
No intended behavior change.
This is the public version of internal change 184824132.
Diffstat (limited to 'LICENSE')
0 files changed, 0 insertions, 0 deletions