diff options
author | Jon Skeet <jonskeet@google.com> | 2015-07-22 19:57:29 +0100 |
---|---|---|
committer | Jon Skeet <jonskeet@google.com> | 2015-07-22 20:13:38 +0100 |
commit | c1c6b2d0d579d863c2ff3709a0053039801f5430 (patch) | |
tree | 67df2426209fb564b4a8504fafd1ceaf8481bfdb /cmake/libprotobuf.cmake | |
parent | 5e0cfc9a4796ab449e042098e914ace9a635c0b6 (diff) | |
download | protobuf-c1c6b2d0d579d863c2ff3709a0053039801f5430.tar.gz protobuf-c1c6b2d0d579d863c2ff3709a0053039801f5430.tar.bz2 protobuf-c1c6b2d0d579d863c2ff3709a0053039801f5430.zip |
Implemented Jan's suggestion of FieldCollection, replacing FieldAccessorCollection.
I think Jan was actually suggesting keeping both, but that feels redundant to me. The test diff is misleading here IMO, because I wouldn't expect real code using reflection to use several accessors one after another like this, unless it was within a loop. Evidence to the contrary would be welcome :)
This change also incidentally goes part way to fixing the issue of the JSON formatter not writing out the fields in field number order - with this change, it does except for oneofs, which we can fix in a follow-up change.
I haven't actually added a test with a message with fields deliberately out of order - I'm happy to do so though. It feels like it would make sense to be in google/src/protobuf, but it's not entirely clear what the rules of engagement are for adding new messages there. (unittest_proto3.proto?)
Diffstat (limited to 'cmake/libprotobuf.cmake')
0 files changed, 0 insertions, 0 deletions