diff options
author | Josh Haberman <jhaberman@gmail.com> | 2016-05-16 12:45:02 -0700 |
---|---|---|
committer | Josh Haberman <jhaberman@gmail.com> | 2016-06-03 09:39:38 -0700 |
commit | ef7894e2dc6d287419e42a4fdc52cdfedd386d16 (patch) | |
tree | e47fa4540f4c278ac2032549fdf311e3442c8c7f /conformance/conformance_test_runner.cc | |
parent | 20b532544fde1dff34429b52db95c3a96409b73c (diff) | |
download | protobuf-ef7894e2dc6d287419e42a4fdc52cdfedd386d16.tar.gz protobuf-ef7894e2dc6d287419e42a4fdc52cdfedd386d16.tar.bz2 protobuf-ef7894e2dc6d287419e42a4fdc52cdfedd386d16.zip |
Make conformance tests more strict about the failure list.
The failure lists were falling out of date because the
tests would pass even if people forgot to remove failures
from the list.
Diffstat (limited to 'conformance/conformance_test_runner.cc')
-rw-r--r-- | conformance/conformance_test_runner.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/conformance/conformance_test_runner.cc b/conformance/conformance_test_runner.cc index 376a60b9..d6b1175c 100644 --- a/conformance/conformance_test_runner.cc +++ b/conformance/conformance_test_runner.cc @@ -280,11 +280,13 @@ int main(int argc, char *argv[]) { char *program; google::protobuf::ConformanceTestSuite suite; + string failure_list_filename; vector<string> failure_list; for (int arg = 1; arg < argc; ++arg) { if (strcmp(argv[arg], "--failure_list") == 0) { if (++arg == argc) UsageError(); + failure_list_filename = argv[arg]; ParseFailureList(argv[arg], &failure_list); } else if (strcmp(argv[arg], "--verbose") == 0) { suite.SetVerbose(true); @@ -300,7 +302,7 @@ int main(int argc, char *argv[]) { } } - suite.SetFailureList(failure_list); + suite.SetFailureList(failure_list_filename, failure_list); ForkPipeRunner runner(program); std::string output; |