diff options
| author | Jon Skeet <skeet@pobox.com> | 2015-08-08 07:26:51 +0100 |
|---|---|---|
| committer | Jon Skeet <skeet@pobox.com> | 2015-08-08 07:26:51 +0100 |
| commit | e58cdbd2146bc8e2e2f5bf4bc8a7576f82535ae6 (patch) | |
| tree | eef81bcb57f5b203ae4a1084473355f17c2a8620 /csharp/src/Google.Protobuf/Collections/RepeatedField.cs | |
| parent | cac45313235bd11b08e0803453a2ec5a7d4b652a (diff) | |
| parent | c671095e91d2f0d6af25e1f046e526d4842f9e1c (diff) | |
| download | protobuf-e58cdbd2146bc8e2e2f5bf4bc8a7576f82535ae6.tar.gz protobuf-e58cdbd2146bc8e2e2f5bf4bc8a7576f82535ae6.tar.bz2 protobuf-e58cdbd2146bc8e2e2f5bf4bc8a7576f82535ae6.zip | |
Merge pull request #695 from jskeet/remove-todos
Tidying up
Diffstat (limited to 'csharp/src/Google.Protobuf/Collections/RepeatedField.cs')
| -rw-r--r-- | csharp/src/Google.Protobuf/Collections/RepeatedField.cs | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/csharp/src/Google.Protobuf/Collections/RepeatedField.cs b/csharp/src/Google.Protobuf/Collections/RepeatedField.cs index c901864a..d9ced6ec 100644 --- a/csharp/src/Google.Protobuf/Collections/RepeatedField.cs +++ b/csharp/src/Google.Protobuf/Collections/RepeatedField.cs @@ -88,7 +88,7 @@ namespace Google.Protobuf.Collections public void AddEntriesFrom(CodedInputStream input, FieldCodec<T> codec) { // TODO: Inline some of the Add code, so we can avoid checking the size on every - // iteration and the mutability. + // iteration. uint tag = input.LastTag; var reader = codec.ValueReader; // Value types can be packed or not. @@ -315,7 +315,7 @@ namespace Google.Protobuf.Collections { throw new ArgumentNullException("values"); } - // TODO: Check for ICollection and get the Count? + // TODO: Check for ICollection and get the Count, to optimize? foreach (T item in values) { Add(item); @@ -394,7 +394,6 @@ namespace Google.Protobuf.Collections { return false; } - // TODO(jonskeet): Does this box for enums? EqualityComparer<T> comparer = EqualityComparer<T>.Default; for (int i = 0; i < count; i++) { @@ -418,7 +417,6 @@ namespace Google.Protobuf.Collections { throw new ArgumentNullException("item"); } - // TODO(jonskeet): Does this box for enums? EqualityComparer<T> comparer = EqualityComparer<T>.Default; for (int i = 0; i < count; i++) { |