Reimplement RepeatedField<T> using an array as the backing store.

This is effectively reimplementing List<T>, but with a few advantages:
- We know that an empty repeated field is common, so don't allocate an array until we need to
- With direct access to the array, we can easily convert enum values to int without boxing
- We can relax the restrictions over what happens if the repeated field is modified while iterating, avoiding so much checking

This is somewhat risky, in that reimplementing a building block like this is *always* risky, but hey...
(The performance benefits are significant...)

1 files changed, 2 insertions, 2 deletions

diff --git a/csharp/src/ProtocolBuffers.Test/CodedInputStreamTest.cs b/csharp/src/ProtocolBuffers.Test/CodedInputStreamTest.cs
index 450662a6..07f54e94 100644
--- a/csharp/src/ProtocolBuffers.Test/CodedInputStreamTest.cs
+++ b/csharp/src/ProtocolBuffers.Test/CodedInputStreamTest.cs
@@ -487,7 +487,7 @@ namespace Google.Protobuf
             uint tag;

             Assert.IsTrue(input.ReadTag(out tag));

 

-            List<TestNegEnum> values = new List<TestNegEnum>();

+            RepeatedField<TestNegEnum> values = new RepeatedField<TestNegEnum>();

             input.ReadEnumArray(tag, values);

 

             Assert.AreEqual(6, values.Count);

@@ -511,7 +511,7 @@ namespace Google.Protobuf
             uint tag;

             Assert.IsTrue(input.ReadTag(out tag));

 

-            List<TestNegEnum> values = new List<TestNegEnum>();

+            RepeatedField<TestNegEnum> values = new RepeatedField<TestNegEnum>();

             input.ReadEnumArray(tag, values);

 

             Assert.AreEqual(6, values.Count);