diff options
author | Jon Skeet <jonskeet@google.com> | 2015-04-28 15:06:59 +0100 |
---|---|---|
committer | Jon Skeet <jonskeet@google.com> | 2015-04-28 15:06:59 +0100 |
commit | ce66c5f1b99fe36b5b91e8b59cc75ce8a4e9cba5 (patch) | |
tree | 84adc050b8ee575f94a5efc13322dd7d344fcff7 /csharp/src/ProtocolBuffers.Test/ReflectionTester.cs | |
parent | f3504cf3b1d456a843e8242fdee9ba0bf2991dc1 (diff) | |
download | protobuf-ce66c5f1b99fe36b5b91e8b59cc75ce8a4e9cba5.tar.gz protobuf-ce66c5f1b99fe36b5b91e8b59cc75ce8a4e9cba5.tar.bz2 protobuf-ce66c5f1b99fe36b5b91e8b59cc75ce8a4e9cba5.zip |
Updated set of unit tests and unit test protos.
This commit includes changes to the C#-specific protos, and rebuilt versions of the "stock" protos.
The stock protos have been locally updated to have a specific C# namespace, but this is expected to change soon, so hasn't been committed.
Four areas are currently not tested:
1) Serialization - we may restore this at some point, possibly optionally.
2) Services - currently nothing is generated for this; will need to see how it interacts with GRPC
3) Fields beginning with _{digit} - see https://github.com/google/protobuf/issues/308
4) Fields with names which conflict with the declaring type in nasty ways - see https://github.com/google/protobuf/issues/309
Diffstat (limited to 'csharp/src/ProtocolBuffers.Test/ReflectionTester.cs')
-rw-r--r-- | csharp/src/ProtocolBuffers.Test/ReflectionTester.cs | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/csharp/src/ProtocolBuffers.Test/ReflectionTester.cs b/csharp/src/ProtocolBuffers.Test/ReflectionTester.cs index 2120ff84..5385d316 100644 --- a/csharp/src/ProtocolBuffers.Test/ReflectionTester.cs +++ b/csharp/src/ProtocolBuffers.Test/ReflectionTester.cs @@ -97,10 +97,8 @@ namespace Google.ProtocolBuffers this.extensionRegistry = extensionRegistry;
this.file = baseDescriptor.File;
- // TODO(jonskeet): We've got 2 dependencies, not 1 - because of the C# options. Hmm.
- // Assert.AreEqual(1, file.Dependencies.Count);
- // TODO(jonskeet): Find dependency by name instead of number?
- this.importFile = file.Dependencies[1];
+ Assert.AreEqual(1, file.Dependencies.Count);
+ this.importFile = file.Dependencies[0];
MessageDescriptor testAllTypes;
if (baseDescriptor.Name == "TestAllTypes")
|