diff options
| author | Jon Skeet <jonskeet@google.com> | 2016-01-20 18:43:00 +0000 |
|---|---|---|
| committer | Jon Skeet <jonskeet@google.com> | 2016-01-20 18:43:00 +0000 |
| commit | dd43dcca8c3a0af761ae981edcadd7e78e875fe8 (patch) | |
| tree | 57451afd4dc559df5b267357f90a11cbc2d3a410 /generate_descriptor_proto.sh | |
| parent | 8c5260b21bb0e217e91375893d507a0ef6578d67 (diff) | |
| download | protobuf-dd43dcca8c3a0af761ae981edcadd7e78e875fe8.tar.gz protobuf-dd43dcca8c3a0af761ae981edcadd7e78e875fe8.tar.bz2 protobuf-dd43dcca8c3a0af761ae981edcadd7e78e875fe8.zip | |
Ensure that FieldMask, Timestamp and Duration ToString() calls don't throw
The usage of ICustomDiagnosticMessage here is non-essential - ToDiagnosticString
doesn't actually get called by ToString() in this case, due to JsonFormatter code. It was
intended to make it clearer that it *did* have a custom format... but then arguably I should
do the same for Value, Struct, Any etc.
Moving some of the code out of JsonFormatter and into Duration/Timestamp/FieldMask likewise
feels somewhat nice, somewhat nasty... basically there are JSON-specific bits of formatting, but
also domain-specific bits of computation. <sigh>
Thoughts welcome.
Diffstat (limited to 'generate_descriptor_proto.sh')
0 files changed, 0 insertions, 0 deletions