aboutsummaryrefslogtreecommitdiff
path: root/js/binary/encoder.js
diff options
context:
space:
mode:
authorJisi Liu <jisi.liu@gmail.com>2017-08-18 16:25:35 -0700
committerJisi Liu <jisi.liu@gmail.com>2017-08-18 16:25:35 -0700
commit139775ccc040a07e07c5407e34834dab27928cbc (patch)
treec500f4eabfea9d2e059f18b7d612c6e2a2db3ad5 /js/binary/encoder.js
parent1825d6d8f0aedcd7966c5c137a71e46ae650b3da (diff)
parent26ac3e8e242f1cd6de15291a9973905a14b546ba (diff)
downloadprotobuf-139775ccc040a07e07c5407e34834dab27928cbc.tar.gz
protobuf-139775ccc040a07e07c5407e34834dab27928cbc.tar.bz2
protobuf-139775ccc040a07e07c5407e34834dab27928cbc.zip
Merge remote-tracking branch 'origin/3.4.x' into mergemaster
Diffstat (limited to 'js/binary/encoder.js')
-rw-r--r--js/binary/encoder.js8
1 files changed, 5 insertions, 3 deletions
diff --git a/js/binary/encoder.js b/js/binary/encoder.js
index f25935f1..8e9f5bbc 100644
--- a/js/binary/encoder.js
+++ b/js/binary/encoder.js
@@ -390,11 +390,13 @@ jspb.BinaryEncoder.prototype.writeDouble = function(value) {
/**
- * Writes a boolean value to the buffer as a varint.
- * @param {boolean} value The value to write.
+ * Writes a boolean value to the buffer as a varint. We allow numbers as input
+ * because the JSPB code generator uses 0/1 instead of true/false to save space
+ * in the string representation of the proto.
+ * @param {boolean|number} value The value to write.
*/
jspb.BinaryEncoder.prototype.writeBool = function(value) {
- goog.asserts.assert(goog.isBoolean(value));
+ goog.asserts.assert(goog.isBoolean(value) || goog.isNumber(value));
this.buffer_.push(value ? 1 : 0);
};