diff options
author | csharptest <roger@csharptest.net> | 2011-06-03 11:57:47 -0500 |
---|---|---|
committer | rogerk <devnull@localhost> | 2011-06-03 11:57:47 -0500 |
commit | 90922db77aef8bd7f21e7a87a75d86885da8dbbc (patch) | |
tree | b86202690d68a01341c2232477657a4da27f7375 /src/ProtoGen/RepeatedMessageFieldGenerator.cs | |
parent | 8a2d0f48d70bd760bf26218f7107c86ca9f91cce (diff) | |
download | protobuf-90922db77aef8bd7f21e7a87a75d86885da8dbbc.tar.gz protobuf-90922db77aef8bd7f21e7a87a75d86885da8dbbc.tar.bz2 protobuf-90922db77aef8bd7f21e7a87a75d86885da8dbbc.zip |
Added the field name to all CodedOutputStream.Write??? calls
Refactored 'speed' generated write of arrays to call Write???Array. This may
have impacted speed write speeds for arrays of non-reference types due to the
use of non-generic IEnumerable and the subsequent boxing of value types. This
could be addressed later if desired.
Diffstat (limited to 'src/ProtoGen/RepeatedMessageFieldGenerator.cs')
-rw-r--r-- | src/ProtoGen/RepeatedMessageFieldGenerator.cs | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/ProtoGen/RepeatedMessageFieldGenerator.cs b/src/ProtoGen/RepeatedMessageFieldGenerator.cs index c882f562..d349d78b 100644 --- a/src/ProtoGen/RepeatedMessageFieldGenerator.cs +++ b/src/ProtoGen/RepeatedMessageFieldGenerator.cs @@ -135,8 +135,13 @@ namespace Google.ProtocolBuffers.ProtoGen public void GenerateSerializationCode(TextGenerator writer)
{
- writer.WriteLine("foreach ({0} element in {1}List) {{", TypeName, PropertyName);
- writer.WriteLine(" output.Write{0}({1}, element);", MessageOrGroup, Number);
+ writer.WriteLine("if ({0}_.Count > 0) {{", Name);
+ writer.Indent();
+ writer.WriteLine("output.Write{0}Array({1}, \"{3}\", {2}_);", MessageOrGroup, Number, Name, Descriptor.Name);
+ //writer.WriteLine("foreach ({0} element in {1}List) {{", TypeName, PropertyName);
+ //writer.WriteLine(" output.Write{0}({1}, element);", MessageOrGroup, Number);
+ //writer.WriteLine("}");
+ writer.Outdent();
writer.WriteLine("}");
}
|