diff options
author | Jon Skeet <skeet@pobox.com> | 2008-08-14 20:35:24 +0100 |
---|---|---|
committer | Jon Skeet <skeet@pobox.com> | 2008-08-14 20:35:24 +0100 |
commit | 794409b379305d18dd0bb4d9ee1cabfd9b6da2d5 (patch) | |
tree | cc041d23517e3cac3638361b772f30f3dfe8bac8 /src | |
parent | ba02091ef822ffa9248fdd6450703e5ff045838e (diff) | |
download | protobuf-794409b379305d18dd0bb4d9ee1cabfd9b6da2d5.tar.gz protobuf-794409b379305d18dd0bb4d9ee1cabfd9b6da2d5.tar.bz2 protobuf-794409b379305d18dd0bb4d9ee1cabfd9b6da2d5.zip |
More tests, more fixes.
Diffstat (limited to 'src')
4 files changed, 7 insertions, 5 deletions
diff --git a/src/google/protobuf/compiler/csharp/csharp_enum_field.cc b/src/google/protobuf/compiler/csharp/csharp_enum_field.cc index 28a70200..00b69910 100644 --- a/src/google/protobuf/compiler/csharp/csharp_enum_field.cc +++ b/src/google/protobuf/compiler/csharp/csharp_enum_field.cc @@ -198,7 +198,7 @@ GenerateBuilderMembers(io::Printer* printer) const { " result.$name$_.Add(value);\r\n" " return this;\r\n" "}\r\n" - "public Builder AddAll$capitalized_name$(scg::IEnumerable<$type$> values) {\r\n" + "public Builder AddRange$capitalized_name$(scg::IEnumerable<$type$> values) {\r\n" " if (result.$name$_.Count == 0) {\r\n" " result.$name$_ = new scg::List<$type$>();\r\n" " }\r\n" diff --git a/src/google/protobuf/compiler/csharp/csharp_extension.cc b/src/google/protobuf/compiler/csharp/csharp_extension.cc index d1bca9ce..9beb7fca 100644 --- a/src/google/protobuf/compiler/csharp/csharp_extension.cc +++ b/src/google/protobuf/compiler/csharp/csharp_extension.cc @@ -57,7 +57,7 @@ void ExtensionGenerator::Generate(io::Printer* printer) { if (descriptor_->is_repeated()) { printer->Print(vars, "public static readonly\r\n" - " pb::GeneratedExtensionBase<$containing_type$, scg::IList<$type$>> name =\r\n" + " pb::GeneratedExtensionBase<$containing_type$, scg::IList<$type$>> $name$ =\r\n" " pb::GeneratedRepeatExtension<$containing_type$, $type$>.CreateInstance(Descriptor.Extensions[$index$]);\r\n"); } else { printer->Print(vars, diff --git a/src/google/protobuf/compiler/csharp/csharp_file.cc b/src/google/protobuf/compiler/csharp/csharp_file.cc index e4317b4b..286c408a 100644 --- a/src/google/protobuf/compiler/csharp/csharp_file.cc +++ b/src/google/protobuf/compiler/csharp/csharp_file.cc @@ -165,11 +165,9 @@ void FileGenerator::Generate(io::Printer* printer) { // Extensions must be generated in the outer class since they are values, // not classes. printer->Print("#region Extensions\r\n"); - printer->Print("/*"); for (int i = 0; i < file_->extension_count(); i++) { ExtensionGenerator(file_->extension(i)).Generate(printer); } - printer->Print("*/\r\n"); printer->Print("#endregion\r\n\r\n"); printer->Print("#region Static variables\r\n"); diff --git a/src/google/protobuf/compiler/csharp/csharp_message.cc b/src/google/protobuf/compiler/csharp/csharp_message.cc index 1d99f366..af7cf410 100644 --- a/src/google/protobuf/compiler/csharp/csharp_message.cc +++ b/src/google/protobuf/compiler/csharp/csharp_message.cc @@ -435,7 +435,7 @@ void MessageGenerator::GenerateBuilder(io::Printer* printer) { if (descriptor_->extension_range_count() > 0) { printer->Print( - "$access$ sealed partial class Builder : pb::GeneratedBuilder<$classname$, $classname$.Builder>.ExtendableBuilder {\r\n", + "$access$ sealed partial class Builder : pb::ExtendableBuilder<$classname$, $classname$.Builder> {\r\n", "classname", ClassName(descriptor_), "access", ClassAccessLevel(descriptor_->file())); } else { @@ -522,6 +522,10 @@ void MessageGenerator::GenerateCommonBuilderMethods(io::Printer* printer) { //TODO(jonskeet): Work out what this is really for... if (descriptor_->file()->options().optimize_for() == FileOptions::SPEED) { printer->Print( + "protected override IBuilder MergeFromImpl(CodedInputStream data, ExtensionRegistry extensionRegistry) {\r\n" + " return MergeFrom(data, extensionRegistry);\r\n" + "}\r\n" + "\r\n" "public override IBuilder MergeFrom(pb::IMessage other) {\r\n" " if (other is $classname$) {\r\n" " return MergeFrom(($classname$) other);\r\n" |