diff options
Diffstat (limited to 'csharp/src/ProtocolBuffers/FieldAccess/FieldAccessorTable.cs')
| -rw-r--r-- | csharp/src/ProtocolBuffers/FieldAccess/FieldAccessorTable.cs | 28 |
1 files changed, 2 insertions, 26 deletions
diff --git a/csharp/src/ProtocolBuffers/FieldAccess/FieldAccessorTable.cs b/csharp/src/ProtocolBuffers/FieldAccess/FieldAccessorTable.cs index c69612fb..80be93f5 100644 --- a/csharp/src/ProtocolBuffers/FieldAccess/FieldAccessorTable.cs +++ b/csharp/src/ProtocolBuffers/FieldAccess/FieldAccessorTable.cs @@ -84,8 +84,8 @@ namespace Google.Protobuf.FieldAccess public ReadOnlyCollection<OneofAccessor> Oneofs { get { return oneofs; } }
- // TODO: Review the API for the indexers. Now that we have fields and oneofs, it's not as clear...
-
+ // TODO: Review this, as it's easy to get confused between FieldNumber and Index.
+ // Currently only used to get an accessor related to a oneof... maybe just make that simpler?
public IFieldAccessor this[int fieldNumber]
{
get
@@ -94,29 +94,5 @@ namespace Google.Protobuf.FieldAccess return accessors[field.Index];
}
}
-
- public IFieldAccessor this[FieldDescriptor field]
- {
- get
- {
- if (field.ContainingType != descriptor)
- {
- throw new ArgumentException("FieldDescriptor does not match message type.");
- }
- return accessors[field.Index];
- }
- }
-
- public OneofAccessor this[OneofDescriptor oneof]
- {
- get
- {
- if (oneof.ContainingType != descriptor)
- {
- throw new ArgumentException("OneofDescriptor does not match message type.");
- }
- return oneofs[oneof.Index];
- }
- }
}
}
\ No newline at end of file |