| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | | |
grpc likely needs to provide the same sorta handling, so expose the class so
the logic can be reused.
|
| | |
| | |
| | |
| | | |
Adds better support for protos without packages and more warnings on possible improvements
|
| | |
| | |
| | |
| | | |
Fixes extra whitespace on generated comments.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Convert mapping of proto comments to appledoc format so they show up in Xcode and cocoadocs.
Fixes https://github.com/google/protobuf/issues/1866
|
| | | |
|
|\ \ \
| | | |
| | | | |
Adding missing generic gcc 64-bit atomicops.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When building for 64-bit big endian MIPS I was getting undefined
references to the following four functions during linking.
NoBarrier_AtomicIncrement
NoBarrier_Store
NoBarrier_AtomicExchange
NoBarrier_Load
Adding 64-bit versions of them to atomicops_internals_generic_gcc.h
fixed the compilation issues.
|
|\ \ \ \
| | |/ /
| |/| | |
Merge 3.0.0-GA into master
|
| | |/
| |/| |
|
| | |
| | |
| | |
| | | |
Remove the use of INT64_C/UINT64_C and add static_cast when neccessary.
|
| | | |
|
| |\ \
| | | |
| | | |
| | | | |
We need to pick up some of the last-minute Ruby fixes.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes https://github.com/google/protobuf/issues/823
Change-Id: I7f4c2bfcac2f81d8b34c030dd3d12ea02aaa2264
|
| | | | |
|
| | | | |
|
| |/ /
|/| | |
|
| | | |
|
|\ \ \
| |/ /
|/| | |
Ruby: generated foo.proto -> foo_pb.rb instead of foo.rb.
|
| | |
| | |
| | |
| | |
| | | |
This brings us more into line with other langauges, and makes it more
obvious when we are requiring protobuf generated code.
|
|/ /
| |
| |
| | |
- Also updates the documentation with a bit more information.
|
|\ \
| | |
| | | |
Fix sign-comparison warnings and add a test for that.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
grpc build treates them as errors and such issues (protobuf change
breaks grpc) has been reported repeatedly. For example:
https://github.com/google/protobuf/issues/1813
Change-Id: I077c4557cf3effd5195f88802c38999b884edc30
|
|/ /
| |
| |
| |
| | |
- Fixes memory issue where the pointer to the StringPiece would be allocated on the stack, and would mangle the output.
- Fixes length of the file name when parsing the comma separated files.
|
|\ \
| | |
| | | |
Versioning Java GeneratedMessage class
|
| | |
| | |
| | |
| | | |
Change-Id: I56a6cce613462794f172ff2e62b25d8a9fc162f3
|
| | |
| | |
| | |
| | | |
Change-Id: Ib2bb5042deaabdf452d5be2ad1ce40d739ad8d1b
|
| | | |
|
| | | |
|
|/ / |
|
|\ \
| | |
| | | |
JavaScript: segregate references to binary functionality
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
This change will help us separate binary support into
separate files, because we only refer to binary serialization
functions in the actual binary serialization paths.
|
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Currently some public API methods are defined in GenreatedMessage.java
and they have a generric return type:
class GeneratedMessage {
class Builder<BuilderType extends Builder<BuilderType>> {
public BuilderType setField(...);
public BuilderType setExtension(...);
}
}
With these definitions, the compiled byte code of a callsite will have
a direct reference to GeneratedMessage. For example:
fooBuilder.setField(...);
becomes:
##: invokevirtual // Method Builder.setField:(...)LGeneratedMessage.Builder
##: checkcast // class Builder
This will prevent us from updating generated classes to subclass a
different versioned GeneratedMessageV3 class in the future (we can't do
it in a binary compatible way).
This change addresses the problem by overriding these methods directly
in the generated class:
class Foo {
class Builder extends GeneratedMessage.Builder<Builder> {
public Builder setField(...) {
return super.setField(...);
}
}
}
After this, fooBuilder.setField(...) will be compiled to:
##: invokevirtual // Method Builder.setField:(...)LFoo.Builder
The callsites will no longer reference GeneratedMessage directly and we
can change Foo to subclass GeneratedMessageV3 without breaking binary
compatiblity.
The downside of this change is:
1. It increases generated code size (though it saves some instructions
on the callsites).
2. We can never stop generating these overrides because doing that
will break binary compatibility.
Change-Id: I879afbbc1325a66324a51565e017143489b06e97
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
When building into frameworks, the generated code doesn't always have direct
access to the proto internals. Instead of opening up the access, just use the
public method to fetch the correct oneof.
Fixes https://github.com/google/protobuf/issues/1789
|
|\ \
| | |
| | | |
Change placement of DebuggerNonUserCodeAttribute
|
| | |
| | |
| | |
| | |
| | |
| | | |
This does not affect the generated code.
If we decide we want to apply attributes to generated types, we should start by
just reverting this change.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I think this has caught everything.
I've left a stub for attributes to be applied to the types themselves, but we don't currently need anything.
Follow-up commit will include the changes to generated code itself.
Fixes #1671.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fix problems detected when integrating the code to our internal repo.
|
| | | | |
|
| |/ / |
|
| | | |
|
|/ / |
|