diff options
| author | Adriaan Moors <adriaan.moors@typesafe.com> | 2013-07-15 23:37:07 -0700 |
|---|---|---|
| committer | Adriaan Moors <adriaan.moors@typesafe.com> | 2013-07-15 23:37:07 -0700 |
| commit | b80f5ead4196ab604ee8b94b554d84743873957f (patch) | |
| tree | 9f6e95f55ccfd1138dd66122bff04ddae61d40a5 | |
| parent | 27ba398b44a9477473175016db19fc450a534a1e (diff) | |
| download | scala-b80f5ead4196ab604ee8b94b554d84743873957f.tar.gz scala-b80f5ead4196ab604ee8b94b554d84743873957f.tar.bz2 scala-b80f5ead4196ab604ee8b94b554d84743873957f.zip | |
clean up PR policy, add notes on buildbot
| -rw-r--r-- | pull-request-policy.md | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/pull-request-policy.md b/pull-request-policy.md index 2f4b9534a1..d6c803a698 100644 --- a/pull-request-policy.md +++ b/pull-request-policy.md @@ -6,6 +6,7 @@ title: Pull Request Policy Hi there, pull request submitter! Your pull request should: + - (... have been discussed on scala-internals) - merge cleanly - consist of commits with impeccable commit messages @@ -34,10 +35,13 @@ we will merge your changes. Please note: you are responsible for meeting these criteria (reminding your reviewer, for example). ### Pull request bot mechanics -* most of this will be automated, but in the mean time, please consider the following: - * when you push new commits, please delete the comments with the old build results to avoid confusion (this will also trigger a new build, even though the bot detects this automatically) - * label the issue corresponding to your pull request (if you have permission) as 'tested' when the bot has reported on a successful build, 'reviewed' when everyone has LGTM'd - * 'PLS REBUILD ALL' will force the bot to rebuild (handy for spurious failures) +Please see the [pr validator's overview](https://github.com/typesafehub/ghpullrequest-validator/blob/master/overview.md) for details. + +Quick notes: + + * The bot automatically builds every commit as it is added to the PR, and will set the status according to the results of the test suite (click on the indicator to see the build log). + * The bot will add the 'reviewed' label if there's a comment starting with "LGTM". + * 'PLS REBUILD ALL' is only necessary when something other than the commit is causing a failure ### List of reviewers by area: |