summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdriaan Moors <adriaan.moors@typesafe.com>2015-08-21 13:53:28 -0700
committerAdriaan Moors <adriaan.moors@typesafe.com>2015-08-21 13:53:28 -0700
commitf8a6d21a490090bac20b0753c46b91ca2b335049 (patch)
treea9c987b4534f1afefb18ca6631ff18345f00d817
parentc3bdcf4e1bb0f7da54775a8c9e306f20dd7e1d4b (diff)
parenta7e24ce7ee96d850bc0a6e1d9cd897c0ecf2ca32 (diff)
downloadscala-f8a6d21a490090bac20b0753c46b91ca2b335049.tar.gz
scala-f8a6d21a490090bac20b0753c46b91ca2b335049.tar.bz2
scala-f8a6d21a490090bac20b0753c46b91ca2b335049.zip
Merge pull request #4702 from janekdb/2.11.x-CONTRIBUTING-advice
Sync commit advice to README.md and fix Scabot URL
-rw-r--r--CONTRIBUTING.md4
1 files changed, 2 insertions, 2 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index e6557d78dd..d01a71b9bd 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -86,7 +86,7 @@ A pull request should consist of commits with messages that clearly state what p
Commit logs should be stated in the active, present tense.
-A commit's subject should be 60 characters or less. Overall, think of
+A commit's subject should be 72 characters or less. Overall, think of
the first line of the commit as a description of the action performed
by the commit on the code base, so use the active voice and the
present tense. That also makes the commit subjects easy to reuse in
@@ -113,7 +113,7 @@ Our pull request bot, Scabot, automatically builds all the commits in a PR indiv
Click on the little x next to a commit sha to go to the overview of the PR validation job. To diagnose a failure, consult the console output of the job that failed.
-See the [scala-jenkins-infra repo](https://github.com/scala/scala-jenkins-infra) and [Scabot repo](https://github.com/) for full details on PR validation. One tip you should know is that commenting `/rebuild` on a PR asks validation to be run again on the same commits. This is only necessary when a spurious failure occurred.
+See the [scala-jenkins-infra repo](https://github.com/scala/scala-jenkins-infra) and [Scabot repo](https://github.com/scala/scabot) for full details on PR validation. One tip you should know is that commenting `/rebuild` on a PR asks validation to be run again on the same commits. This is only necessary when a spurious failure occurred.
### Pass code review