diff options
author | Lukas Rytz <lukas.rytz@typesafe.com> | 2015-05-04 10:53:45 +0200 |
---|---|---|
committer | Lukas Rytz <lukas.rytz@typesafe.com> | 2015-05-04 10:53:45 +0200 |
commit | f1d7423ed41f516f9db8abd2364b764109150b6f (patch) | |
tree | ecf549df81911564ae70f125c6229bbeab0de9bc | |
parent | e547c6ec097fcaaab237655300ce0036deb37e72 (diff) | |
parent | fd14b6184250430b826c067bd7f3685d27ba9773 (diff) | |
download | scala-f1d7423ed41f516f9db8abd2364b764109150b6f.tar.gz scala-f1d7423ed41f516f9db8abd2364b764109150b6f.tar.bz2 scala-f1d7423ed41f516f9db8abd2364b764109150b6f.zip |
Merge pull request #4473 from retronym/ticket/9285
SI-9285 Don't warn about non-sensible equals in synthetic methods
-rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/RefChecks.scala | 2 | ||||
-rw-r--r-- | test/files/pos/t9285.flags | 1 | ||||
-rw-r--r-- | test/files/pos/t9285.scala | 1 |
3 files changed, 3 insertions, 1 deletions
diff --git a/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala b/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala index a3a4c70d1e..4b30b4e436 100644 --- a/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala +++ b/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala @@ -1122,7 +1122,7 @@ abstract class RefChecks extends InfoTransform with scala.reflect.internal.trans } /** Sensibility check examines flavors of equals. */ def checkSensible(pos: Position, fn: Tree, args: List[Tree]) = fn match { - case Select(qual, name @ (nme.EQ | nme.NE | nme.eq | nme.ne)) if args.length == 1 && isObjectOrAnyComparisonMethod(fn.symbol) => + case Select(qual, name @ (nme.EQ | nme.NE | nme.eq | nme.ne)) if args.length == 1 && isObjectOrAnyComparisonMethod(fn.symbol) && !currentOwner.isSynthetic => checkSensibleEquals(pos, qual, name, fn.symbol, args.head) case _ => } diff --git a/test/files/pos/t9285.flags b/test/files/pos/t9285.flags new file mode 100644 index 0000000000..85d8eb2ba2 --- /dev/null +++ b/test/files/pos/t9285.flags @@ -0,0 +1 @@ +-Xfatal-warnings diff --git a/test/files/pos/t9285.scala b/test/files/pos/t9285.scala new file mode 100644 index 0000000000..b7146cdf1c --- /dev/null +++ b/test/files/pos/t9285.scala @@ -0,0 +1 @@ +case class C(placeholder: Unit) |