diff options
author | Jason Zaugg <jzaugg@gmail.com> | 2013-11-23 22:25:22 +0100 |
---|---|---|
committer | Jason Zaugg <jzaugg@gmail.com> | 2013-11-24 09:12:24 +0100 |
commit | 28bf4ada31119712b415b2b2f6aeb87f0431eb48 (patch) | |
tree | b4aad81d541a4fa1327b051c67f277554aa6aecc | |
parent | c243435f113615b2f7407fbd683c93ec16c73749 (diff) | |
download | scala-28bf4ada31119712b415b2b2f6aeb87f0431eb48.tar.gz scala-28bf4ada31119712b415b2b2f6aeb87f0431eb48.tar.bz2 scala-28bf4ada31119712b415b2b2f6aeb87f0431eb48.zip |
SI-8002 private access for local companions
We go through similar gymnastics to make companion implicits
work for local class/object pairings, so we ought to be consistent
when it comes to access
-rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/Contexts.scala | 5 | ||||
-rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/Namers.scala | 7 | ||||
-rw-r--r-- | test/files/pos/t8002-nested-scope.scala | 20 | ||||
-rw-r--r-- | test/files/run/t8002.scala | 19 |
4 files changed, 50 insertions, 1 deletions
diff --git a/src/compiler/scala/tools/nsc/typechecker/Contexts.scala b/src/compiler/scala/tools/nsc/typechecker/Contexts.scala index 5e5619d034..2be6d92ed0 100644 --- a/src/compiler/scala/tools/nsc/typechecker/Contexts.scala +++ b/src/compiler/scala/tools/nsc/typechecker/Contexts.scala @@ -657,7 +657,10 @@ trait Contexts { self: Analyzer => // Console.println("isAccessible(%s, %s, %s)".format(sym, pre, superAccess)) // don't have access if there is no linked class (so exclude linkedClass=NoSymbol) - def accessWithinLinked(ab: Symbol) = ab.linkedClassOfClass.fold(false)(accessWithin) + def accessWithinLinked(ab: Symbol) = { + val linked = linkedClassOfClassOf(ab, this) + linked.fold(false)(accessWithin) + } /* Are we inside definition of `ab`? */ def accessWithin(ab: Symbol) = { diff --git a/src/compiler/scala/tools/nsc/typechecker/Namers.scala b/src/compiler/scala/tools/nsc/typechecker/Namers.scala index e3d7bfd4f8..39e259fdfd 100644 --- a/src/compiler/scala/tools/nsc/typechecker/Namers.scala +++ b/src/compiler/scala/tools/nsc/typechecker/Namers.scala @@ -1695,4 +1695,11 @@ trait Namers extends MethodSynthesis { ) } } + + /** A version of `Symbol#linkedClassOfClass` that works with local companions, ala `companionSymbolOf`. */ + final def linkedClassOfClassOf(original: Symbol, ctx: Context): Symbol = + if (original.isModuleClass) + companionSymbolOf(original.sourceModule, ctx) + else + companionSymbolOf(original, ctx).moduleClass } diff --git a/test/files/pos/t8002-nested-scope.scala b/test/files/pos/t8002-nested-scope.scala new file mode 100644 index 0000000000..a2088bce7a --- /dev/null +++ b/test/files/pos/t8002-nested-scope.scala @@ -0,0 +1,20 @@ +// This test serves to capture the status quo, but should really +// emit an accessibiltiy error. + +// `Namers#companionSymbolOf` seems too lenient, and currently doesn't +// implement the same-scope checks mentioned: +// +// https://github.com/scala/scala/pull/2816#issuecomment-22555206 +// +class C { + def foo = { + class C { private def x = 0 } + + { + val a = 0 + object C { + new C().x + } + } + } +} diff --git a/test/files/run/t8002.scala b/test/files/run/t8002.scala new file mode 100644 index 0000000000..f24a213dea --- /dev/null +++ b/test/files/run/t8002.scala @@ -0,0 +1,19 @@ +object Test extends App { + val a: Any = { + class A private () { private def x = 0; A.y }; + object A { + def a = new A().x + private def y = 0 + } + A.a + } + def b: Any = { + object A { + def a = new A().x + private def y = 0 + } + class A private () { private def x = 0; A.y }; + A.a + } + b +} |