I wrote a warning when nullary methods return U...

I wrote a warning when nullary methods return Unit. I wimped out of
including it in this patch because we had about 200 of them, and that's
what is fixed in this patch. I will add the warning to some kind of
"-Xlint" feature after 2.9.

This is motivated at least partly by the resolution of #4506, which
indicates the distinction between "def foo()" and "def foo" will
continue to jab its pointy stick into our eyes, so I believe we have a
minimal duty of at least following our own advice about what they mean
and not making a semirandom choice as to whether a method has parens or
not. Review by community.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/attic/scala/tools/nsc/models/SemanticTokens.scala b/src/attic/scala/tools/nsc/models/SemanticTokens.scala
index edbc13ccdc..6c2fe79d77 100644
--- a/src/attic/scala/tools/nsc/models/SemanticTokens.scala
+++ b/src/attic/scala/tools/nsc/models/SemanticTokens.scala
@@ -648,11 +648,11 @@ class SemanticTokens(val compiler: Global) {
       var token: Token = end
       var offset: Int = 0
 
-      def next: Unit = if (token == end) end else {
+      def next(): Unit = if (token == end) end else {
         offset = offset + token.length
         token  = token.next
       }
-      def prev: Unit = if (token.prev == begin) token else {
+      def prev(): Unit = if (token.prev == begin) token else {
         offset = offset - token.prev.length
         token = token.prev
       }