diff options
| author | Som Snytt <som.snytt@gmail.com> | 2014-07-01 08:21:07 -0700 |
|---|---|---|
| committer | Som Snytt <som.snytt@gmail.com> | 2014-07-10 09:27:51 -0700 |
| commit | 3b89c168b4926139f7295183fdc1903f6f553798 (patch) | |
| tree | 640f0672a1deadf6d3b7e57383be6432165a551f /src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala | |
| parent | 44855dcd3c2e19d5dbaf01b2165ea8dc9fb287d3 (diff) | |
| download | scala-3b89c168b4926139f7295183fdc1903f6f553798.tar.gz scala-3b89c168b4926139f7295183fdc1903f6f553798.tar.bz2 scala-3b89c168b4926139f7295183fdc1903f6f553798.zip | |
SI-8525 No anonymous lint
Turn anonymous references to `settings.lint` into named settings.
After that, trust to Adriaan to make them filterable.
There are a few remaining top-level -Y lint warnings that are
deprecated.
Diffstat (limited to 'src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala')
| -rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala b/src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala index 9516f94135..d0237fb468 100644 --- a/src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala +++ b/src/compiler/scala/tools/nsc/typechecker/SyntheticMethods.scala @@ -339,12 +339,11 @@ trait SyntheticMethods extends ast.TreeDSL { !hasOverridingImplementation(m) || { clazz.isDerivedValueClass && (m == Any_hashCode || m == Any_equals) && { // Without a means to suppress this warning, I've thought better of it. - // - // if (settings.lint) { - // (clazz.info nonPrivateMember m.name) filter (m => (m.owner != AnyClass) && (m.owner != clazz) && !m.isDeferred) andAlso { m => - // currentUnit.warning(clazz.pos, s"Implementation of ${m.name} inherited from ${m.owner} overridden in $clazz to enforce value class semantics") - // } - // } + if (settings.warnValueOverrides) { + (clazz.info nonPrivateMember m.name) filter (m => (m.owner != AnyClass) && (m.owner != clazz) && !m.isDeferred) andAlso { m => + currentUnit.warning(clazz.pos, s"Implementation of ${m.name} inherited from ${m.owner} overridden in $clazz to enforce value class semantics") + } + } true } } |