diff options
author | Lukas Rytz <lukas.rytz@gmail.com> | 2016-10-21 09:55:18 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-10-21 09:55:18 +0200 |
commit | 5f894c06da97fdcebf206ac41b4694beb7b27a05 (patch) | |
tree | feb13364f578c3acd00eeaaecf85f03dd14c1ff3 /src/compiler/scala/tools/nsc/typechecker/Typers.scala | |
parent | 5b8e4d3436b4b22d67b99e37573957554f151dd9 (diff) | |
parent | 94518ce0be2ffdb06d1d3f81279fdc05fa568c0b (diff) | |
download | scala-5f894c06da97fdcebf206ac41b4694beb7b27a05.tar.gz scala-5f894c06da97fdcebf206ac41b4694beb7b27a05.tar.bz2 scala-5f894c06da97fdcebf206ac41b4694beb7b27a05.zip |
Merge pull request #5393 from som-snytt/issue/nowarn-thistype-discard
No warn when discarding r.f(): r.type
Diffstat (limited to 'src/compiler/scala/tools/nsc/typechecker/Typers.scala')
-rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/Typers.scala | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/compiler/scala/tools/nsc/typechecker/Typers.scala b/src/compiler/scala/tools/nsc/typechecker/Typers.scala index d8183ea8df..7d48c548a1 100644 --- a/src/compiler/scala/tools/nsc/typechecker/Typers.scala +++ b/src/compiler/scala/tools/nsc/typechecker/Typers.scala @@ -1060,8 +1060,13 @@ trait Typers extends Adaptations with Tags with TypersTracking with PatternTyper @inline def tpdPos(transformed: Tree) = typedPos(tree.pos, mode, pt)(transformed) @inline def tpd(transformed: Tree) = typed(transformed, mode, pt) - @inline def warnValueDiscard(): Unit = - if (!isPastTyper && settings.warnValueDiscard) context.warning(tree.pos, "discarded non-Unit value") + @inline def warnValueDiscard(): Unit = if (!isPastTyper && settings.warnValueDiscard) { + def isThisTypeResult = (tree, tree.tpe) match { + case (Apply(Select(receiver, _), _), SingleType(_, sym)) => sym == receiver.symbol + case _ => false + } + if (!isThisTypeResult) context.warning(tree.pos, "discarded non-Unit value") + } @inline def warnNumericWiden(): Unit = if (!isPastTyper && settings.warnNumericWiden) context.warning(tree.pos, "implicit numeric widening") |