diff options
author | Adriaan Moors <adriaan@lightbend.com> | 2016-08-12 21:25:41 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-08-12 21:25:41 -0700 |
commit | 69c6500b5f25e1b4a66d3a62cf40d23877a9023f (patch) | |
tree | cbd5af93970a2d43ca24e676a8d1029700860a85 /src/compiler | |
parent | 4b77734b28f82e2573446bd997e739b80de4af1d (diff) | |
parent | 3a3688f64af0755cef5a772d322ac80e08498e54 (diff) | |
download | scala-69c6500b5f25e1b4a66d3a62cf40d23877a9023f.tar.gz scala-69c6500b5f25e1b4a66d3a62cf40d23877a9023f.tar.bz2 scala-69c6500b5f25e1b4a66d3a62cf40d23877a9023f.zip |
Merge pull request #5331 from adriaanm/pr5282-reword
SD-128 fix override checks for default methods
Diffstat (limited to 'src/compiler')
-rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/RefChecks.scala | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala b/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala index 72133f31fa..8449260fe6 100644 --- a/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala +++ b/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala @@ -419,7 +419,7 @@ abstract class RefChecks extends Transform { overrideError("cannot be used here - classes can only override abstract types") } else if (other.isEffectivelyFinal) { // (1.2) overrideError("cannot override final member") - } else if (!other.isDeferredOrJavaDefault && !other.hasFlag(JAVA_DEFAULTMETHOD) && !member.isAnyOverride && !member.isSynthetic) { // (*) + } else if (!other.isDeferred && !member.isAnyOverride && !member.isSynthetic) { // (*) // (*) Synthetic exclusion for (at least) default getters, fixes SI-5178. We cannot assign the OVERRIDE flag to // the default getter: one default getter might sometimes override, sometimes not. Example in comment on ticket. if (isNeitherInClass && !(other.owner isSubClass member.owner)) @@ -606,7 +606,7 @@ abstract class RefChecks extends Transform { def checkNoAbstractMembers(): Unit = { // Avoid spurious duplicates: first gather any missing members. def memberList = clazz.info.nonPrivateMembersAdmitting(VBRIDGE) - val (missing, rest) = memberList partition (m => m.isDeferredNotJavaDefault && !ignoreDeferred(m)) + val (missing, rest) = memberList partition (m => m.isDeferred && !ignoreDeferred(m)) // Group missing members by the name of the underlying symbol, // to consolidate getters and setters. val grouped = missing groupBy (sym => analyzer.underlyingSymbol(sym).name) |