summaryrefslogtreecommitdiff
path: root/src/library/scala/collection/immutable/Range.scala
diff options
context:
space:
mode:
authorAleksandar Pokopec <aleksandar.prokopec@epfl.ch>2011-03-18 19:07:38 +0000
committerAleksandar Pokopec <aleksandar.prokopec@epfl.ch>2011-03-18 19:07:38 +0000
commit86e8f5ae1dccc9f628b6a3f1bdab7e4e81ae9cbb (patch)
tree2e8a5cc7b5ef666c31a2c99dca990f269b850eb5 /src/library/scala/collection/immutable/Range.scala
parent0554c378653c47aefaabe48b0ef568f952d1695b (diff)
downloadscala-86e8f5ae1dccc9f628b6a3f1bdab7e4e81ae9cbb.tar.gz
scala-86e8f5ae1dccc9f628b6a3f1bdab7e4e81ae9cbb.tar.bz2
scala-86e8f5ae1dccc9f628b6a3f1bdab7e4e81ae9cbb.zip
Removing toPar* methods, since we've agreed the...
Removing toPar* methods, since we've agreed they're difficult to: - underestand - maintain Also, changed the docs and some tests appropriately. Description: 1) Every collection is now parallelizable - switch to the parallel version of the collection is done via `par`. - Traversable collections and iterators have `par` return a parallel - collection of type `ParIterable[A]` with the implementation being the - representative of `ParIterable`s (currently, `ParArray`). Iterable - collections do the same thing. Sequences refine `par`'s returns type - to `ParSeq[A]`. Maps and sets do a similar thing. The above means that the contract for `par` changed - it is no longer guaranteed to be O(1), nor reflect the same underlying data, as was the case for mutable collections before. Method `par` is now at worst linear. Furthermore, specific collection implementations override `par` to a more efficient alternative - instead of copying the dataset, the dataset is shared between the old and the new version. Implementation complexity may be sublinear or constant in these cases, and the underlying data structure may be shared. Currently, these data structures include parallel arrays, maps and sets, vectors, hash trie maps and sets, and ranges. Finally, parallel collections implement `par` trivially. 2) Methods `toMap`, `toSet`, `toSeq` and `toIterable` have been refined for parallel collections to switch between collection types, however, they never switch an implementation from parallel to sequential. They may or may not copy the elements, as is the case with sequential variants of these methods. 3) The preferred way to switch between different collection types, whether maps, sets and seqs, or parallel and sequential, is now via use of methods `toIterable`, `toSeq`, `toSet` and `toMap` in combination with `par` and `seq`. Review by odersky.
Diffstat (limited to 'src/library/scala/collection/immutable/Range.scala')
-rw-r--r--src/library/scala/collection/immutable/Range.scala10
1 files changed, 4 insertions, 6 deletions
diff --git a/src/library/scala/collection/immutable/Range.scala b/src/library/scala/collection/immutable/Range.scala
index f8b3dfa54f..90a1383353 100644
--- a/src/library/scala/collection/immutable/Range.scala
+++ b/src/library/scala/collection/immutable/Range.scala
@@ -41,10 +41,10 @@ import scala.collection.parallel.immutable.ParRange
@SerialVersionUID(7618862778670199309L)
class Range(val start: Int, val end: Int, val step: Int)
extends IndexedSeq[Int]
- with collection.Parallelizable[ParRange]
+ with collection.CustomParallelizable[Int, ParRange]
with Serializable
{
- def par = new ParRange(this)
+ override def par = new ParRange(this)
// Note that this value is calculated eagerly intentionally: it also
// serves to enforce conditions (step != 0) && (length <= Int.MaxValue)
@@ -205,11 +205,9 @@ extends IndexedSeq[Int]
final def contains(x: Int) = isWithinBoundaries(x) && ((x - start) % step == 0)
- override def toParIterable = par
+ override def toIterable = this
- override def toParSeq = par
-
- override def toParSet[U >: Int] = par.toParSet[U]
+ override def toSeq = this
override def equals(other: Any) = other match {
case x: Range =>