diff options
| author | Hubert Plociniczak <hubert.plociniczak@gmail.com> | 2012-01-25 11:33:53 +0100 |
|---|---|---|
| committer | Hubert Plociniczak <hubert.plociniczak@gmail.com> | 2012-01-25 11:33:53 +0100 |
| commit | c800d1fec5241ed8c29e5af30465856f9b583246 (patch) | |
| tree | a37c194bb2d632adf9adeda17a107913f63864ba /src/library | |
| parent | de2b0c68785afc0f801fbe8d2750366e90c9fa70 (diff) | |
| download | scala-c800d1fec5241ed8c29e5af30465856f9b583246.tar.gz scala-c800d1fec5241ed8c29e5af30465856f9b583246.tar.bz2 scala-c800d1fec5241ed8c29e5af30465856f9b583246.zip | |
Use context for buffering errors that cannot/shouldn't be reported in the given moment (instead of throwing type errors). This avoids previous problems where we were creating fake error trees in some incorrect places like in type completers in Namers etc. Implicits relied heavily on type errors being thrown but performance should stay the same due to some explicit checks/returns.
Some of the problems involved how ambiguous error messages were collected/reported because it was very random (similarly for divergent implicits). This should be more explicit now. Reduced the number of unnecessary cyclic references being thrown (apart from those in Symbols/Types which don't have a context and need to stay for now as is).
Review by @paulp, @odersky.
Diffstat (limited to 'src/library')
| -rw-r--r-- | src/library/scala/reflect/api/Trees.scala | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/library/scala/reflect/api/Trees.scala b/src/library/scala/reflect/api/Trees.scala index 2394925657..27f2ab1d08 100644 --- a/src/library/scala/reflect/api/Trees.scala +++ b/src/library/scala/reflect/api/Trees.scala @@ -8,8 +8,6 @@ package api import scala.collection.mutable.ListBuffer -//import scala.tools.nsc.util.{ FreshNameCreator, HashSet, SourceFile } - trait Trees /*extends reflect.generic.Trees*/ { self: Universe => private[scala] var nodeCount = 0 @@ -549,7 +547,7 @@ trait Trees /*extends reflect.generic.Trees*/ { self: Universe => Select(qualifier, sym.name) setSymbol sym /** Identifier <name> */ - case class Ident(name: Name) extends RefTree { } + case class Ident(name: Name) extends RefTree def Ident(name: String): Ident = Ident(newTermName(name)) |