diff options
author | Paul Phillips <paulp@improving.org> | 2009-12-02 05:00:11 +0000 |
---|---|---|
committer | Paul Phillips <paulp@improving.org> | 2009-12-02 05:00:11 +0000 |
commit | ea22ed166ac84e3e05c26b2a9ae5f8f1ac0077c4 (patch) | |
tree | cf25e4a56a4970983589b8a7d8acb75fc79abdc1 /src/partest | |
parent | a030f0d8b3f19c88c857adbeea7e8712fb6a8c8e (diff) | |
download | scala-ea22ed166ac84e3e05c26b2a9ae5f8f1ac0077c4.tar.gz scala-ea22ed166ac84e3e05c26b2a9ae5f8f1ac0077c4.tar.bz2 scala-ea22ed166ac84e3e05c26b2a9ae5f8f1ac0077c4.zip |
Some minor cleanups found while cleaning up.
Diffstat (limited to 'src/partest')
-rw-r--r-- | src/partest/scala/tools/partest/nest/Worker.scala | 42 |
1 files changed, 13 insertions, 29 deletions
diff --git a/src/partest/scala/tools/partest/nest/Worker.scala b/src/partest/scala/tools/partest/nest/Worker.scala index ec02009728..53c270bdbd 100644 --- a/src/partest/scala/tools/partest/nest/Worker.scala +++ b/src/partest/scala/tools/partest/nest/Worker.scala @@ -109,11 +109,10 @@ class Worker(val fileManager: FileManager) extends Actor { } def createOutputDir(dir: File, fileBase: String, kind: String): File = { - val outDir = new File(dir, fileBase + "-" + kind + ".obj") - if (!outDir.exists) - outDir.mkdir() - createdOutputDirs = outDir :: createdOutputDirs - outDir + val outDir = io.Path(dir) / io.Directory("%s-%s.obj".format(fileBase, kind)) + outDir.createDirectory() + createdOutputDirs ::= outDir.jfile + outDir.jfile } /* Note: not yet used/tested. */ @@ -304,34 +303,19 @@ class Worker(val fileManager: FileManager) extends Actor { } def compareOutput(dir: File, fileBase: String, kind: String, logFile: File): String = { - // if check file exists, compare with log file - val checkFile = { - val chkFile = new File(dir, fileBase + ".check") - if (chkFile.isFile) - chkFile - else - new File(dir, fileBase + "-" + kind + ".check") + def getCheckFile(s: String) = { + val f = io.Path(dir) / io.File("%s%s.check".format(fileBase, s)) + if (f.isFile && f.canRead) Some(f) else None } - if (!checkFile.exists || !checkFile.canRead) { - val reader = new BufferedReader(new FileReader(logFile)) - val swriter = new StringWriter - val pwriter = new PrintWriter(swriter, true) - val appender = new StreamAppender(reader, pwriter) - appender.run() - swriter.toString + + // if check file exists, compare with log file + (getCheckFile("") orElse getCheckFile("-" + kind)) match { + case Some(f) => fileManager.compareFiles(logFile, f.jfile) + case _ => file2String(logFile) } - else fileManager.compareFiles(logFile, checkFile) } - def file2String(logFile: File) = { - val logReader = new BufferedReader(new FileReader(logFile)) - val strWriter = new StringWriter - val logWriter = new PrintWriter(strWriter, true) - val logAppender = new StreamAppender(logReader, logWriter) - logAppender.run() - logReader.close() - strWriter.toString - } + def file2String(logFile: File) = io.File(logFile).slurp() /** Runs a list of tests. * |