Takes 30+% off the startup time for scala/scala...

Takes 30+% off the startup time for scala/scalac with a variety of
optimizations pinpointed by tracing method invocations. Frequent guest
stars in the parade of slowness were: using Lists and ListBuffers when
any amount of random access is needed, using Strings as if one shouldn't
have to supply 80 characters of .substring noise to drop a character
here and there, imagining that code can be reused in any way shape
or form without a savage slowness burn being unleashed upon you and
everything you have ever loved, String.format, methods which return
tuples, and any method written with appealing scala features which turns
out to be called a few orders of magnitude more often than the author
probably supposed.

This may be only the tip of the iceberg. No review.

1 files changed, 7 insertions, 6 deletions

diff --git a/src/scalap/scala/tools/scalap/Main.scala b/src/scalap/scala/tools/scalap/Main.scala
index 9ddb521a10..24f26e2b60 100644
--- a/src/scalap/scala/tools/scalap/Main.scala
+++ b/src/scalap/scala/tools/scalap/Main.scala
@@ -126,13 +126,14 @@ class Main {
     /**
      * The short name of the package (without prefix)
      */
-    def name: String = ""
-    def asURLs = Nil
+    def name              = ""
+    def asURLs            = Nil
     def asClasspathString = ""
-    val context = DefaultJavaContext
-    val classes: List[ClassRep] = Nil
-    val packages: List[ClassPath[AbstractFile]] = Nil
-    val sourcepaths: List[AbstractFile] = Nil
+
+    val context     = DefaultJavaContext
+    val classes     = IndexedSeq[ClassRep]()
+    val packages    = IndexedSeq[ClassPath[AbstractFile]]()
+    val sourcepaths = IndexedSeq[AbstractFile]()
   }
 }