diff options
author | Paul Phillips <paulp@improving.org> | 2011-11-29 18:10:55 +0000 |
---|---|---|
committer | Paul Phillips <paulp@improving.org> | 2011-11-29 18:10:55 +0000 |
commit | 8eba9acbc49eb02b9b5bd8523873a181255e4bb6 (patch) | |
tree | a0fa1d713bd0cfdba8b95f7d552dccd1be795fd4 /src | |
parent | 9c4f14411f1aac5d106aa4a2a404c7d231752478 (diff) | |
download | scala-8eba9acbc49eb02b9b5bd8523873a181255e4bb6.tar.gz scala-8eba9acbc49eb02b9b5bd8523873a181255e4bb6.tar.bz2 scala-8eba9acbc49eb02b9b5bd8523873a181255e4bb6.zip |
Fixed -Xfuture 5.ds, deprecated 0-octal.
I messed up my trip to the future the first time around; now in the
future 5.f is not an error but an attempt to call method "f" on 5 like
nature intended. (Thank you simon for catching this.) And deprecated
leading 0 for octal. Closes SI-5205.
Diffstat (limited to 'src')
-rw-r--r-- | src/compiler/scala/tools/nsc/ast/parser/Scanners.scala | 78 |
1 files changed, 40 insertions, 38 deletions
diff --git a/src/compiler/scala/tools/nsc/ast/parser/Scanners.scala b/src/compiler/scala/tools/nsc/ast/parser/Scanners.scala index b0a533afc6..a25b3afbc6 100644 --- a/src/compiler/scala/tools/nsc/ast/parser/Scanners.scala +++ b/src/compiler/scala/tools/nsc/ast/parser/Scanners.scala @@ -83,6 +83,7 @@ trait Scanners extends ScannersCommon { } abstract class Scanner extends CharArrayReader with TokenData with ScannerCommon { + private def isDigit(c: Char) = java.lang.Character isDigit c def flush = { charOffset = offset; nextChar(); this } @@ -342,16 +343,14 @@ trait Scanners extends ScannersCommon { base = 16 } else { - // !!! Let's deprecate this too, shall we? - // Can it really be worth it given the endless supply of newbies - // who have no hope whatsoever of intuiting that 012 != 12? - // Leading zero meaning octal is a relic of a darker time. - // - // Pre-fabricated future logic / warning: - // - // deprecationWarning("Treating numbers with a leading zero as octal is deprecated.") - // if (!opt.future) - // base = 8 + /** What should leading 0 be in the future? It is potentially dangerous + * to let it be base-10 because of history. Should it be an error? Is + * there a realistic situation where one would need it? + */ + if (isDigit(ch)) { + if (opt.future) syntaxError("Non-zero numbers may not have a leading zero.") + else deprecationWarning("Treating numbers with a leading zero as octal is deprecated.") + } base = 8 } getNumber() @@ -825,10 +824,7 @@ trait Scanners extends ScannersCommon { if (value > limit) syntaxError("floating point number too large") if (isDeprecatedForm) { - if (opt.future) - syntaxError("malformed floating point number: to be part of a number, a dot must be immediately followed by a digit") - else - deprecationWarning("This lexical syntax is deprecated. From scala 2.11, a dot will only be considered part of a number if it is immediately followed by a digit.") + deprecationWarning("This lexical syntax is deprecated. From scala 2.11, a dot will only be considered part of a number if it is immediately followed by a digit.") } if (negated) -value else value @@ -849,7 +845,6 @@ trait Scanners extends ScannersCommon { /** Read a number into strVal and set base */ protected def getNumber() { - def isDigit(c: Char) = java.lang.Character isDigit c val base1 = if (base < 10) 10 else base // read 8,9's even if format is octal, produce a malformed number error afterwards. while (digit2int(ch, base1) >= 0) { @@ -884,29 +879,36 @@ trait Scanners extends ScannersCommon { restOfUncertainToken() else { val lookahead = lookaheadReader - val isDefinitelyNumber = - (lookahead.getc(): @switch) match { - /** Another digit is a giveaway. */ - case '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9' => - true - - /** Backquoted idents like 22.`foo`. */ - case '`' => - return setStrVal() /** Note the early return */ - - /** These letters may be part of a literal, or a method invocation on an Int */ - case 'd' | 'D' | 'f' | 'F' => - !isIdentifierPart(lookahead.getc()) - - /** A little more special handling for e.g. 5e7 */ - case 'e' | 'E' => - val ch = lookahead.getc() - !isIdentifierPart(ch) || (isDigit(ch) || ch == '+' || ch == '-') - - case x => - !isIdentifierStart(x) - } - + val c = lookahead.getc() + + /** As of scala 2.11, it isn't a number unless c here is a digit, so + * opt.future excludes the rest of the logic. + */ + if (opt.future && !isDigit(c)) + return setStrVal() + + val isDefinitelyNumber = (c: @switch) match { + /** Another digit is a giveaway. */ + case '0' | '1' | '2' | '3' | '4' | '5' | '6' | '7' | '8' | '9' => + true + + /** Backquoted idents like 22.`foo`. */ + case '`' => + return setStrVal() /** Note the early return */ + + /** These letters may be part of a literal, or a method invocation on an Int. + */ + case 'd' | 'D' | 'f' | 'F' => + !isIdentifierPart(lookahead.getc()) + + /** A little more special handling for e.g. 5e7 */ + case 'e' | 'E' => + val ch = lookahead.getc() + !isIdentifierPart(ch) || (isDigit(ch) || ch == '+' || ch == '-') + + case x => + !isIdentifierStart(x) + } if (isDefinitelyNumber) restOfNumber() else restOfUncertainToken() } |