SI-5696 Detect excess constructor argument lists.

An apply method fooled the usual mechanism.

2 files changed, 7 insertions, 0 deletions

diff --git a/src/compiler/scala/tools/nsc/typechecker/ContextErrors.scala b/src/compiler/scala/tools/nsc/typechecker/ContextErrors.scala
index a2f0e053a8..bcf2ba6b71 100644
--- a/src/compiler/scala/tools/nsc/typechecker/ContextErrors.scala
+++ b/src/compiler/scala/tools/nsc/typechecker/ContextErrors.scala
@@ -224,6 +224,11 @@ trait ContextErrors {
       def SuperConstrArgsThisReferenceError(tree: Tree) =
         NormalTypeError(tree, "super constructor arguments cannot reference unconstructed `this`")
 
+      def TooManyArgumentListsForConstructor(tree: Tree) = {
+        issueNormalTypeError(tree, "too many argument lists for constructor invocation")
+        setError(tree)
+      }
+
       // typedValDef
       def VolatileValueError(vdef: Tree) =
         issueNormalTypeError(vdef, "values cannot be volatile")
diff --git a/src/compiler/scala/tools/nsc/typechecker/Typers.scala b/src/compiler/scala/tools/nsc/typechecker/Typers.scala
index fec5063bd0..2bdae4164a 100644
--- a/src/compiler/scala/tools/nsc/typechecker/Typers.scala
+++ b/src/compiler/scala/tools/nsc/typechecker/Typers.scala
@@ -4950,6 +4950,8 @@ trait Typers extends Modes with Adaptations with Tags {
                 else new ApplyToImplicitArgs(Select(tag, nme.newArray), args)
               }
               typed(newArrayApp, mode, pt)
+            case Apply(Select(fun, nme.apply), _) if treeInfo.isSuperConstrCall(fun) => //SI-5696
+              TooManyArgumentListsForConstructor(tree)
             case tree1 =>
               tree1
           }