diff options
| author | Martin Odersky <odersky@gmail.com> | 2012-01-04 07:05:19 +0100 |
|---|---|---|
| committer | Paul Phillips <paulp@improving.org> | 2012-01-04 06:24:23 -0800 |
| commit | 6975b4888da9b56e2c06d45da8f483f2e33a102b (patch) | |
| tree | b4fa395843b6c573f584481848f37ee1c0ba5c68 /test/files/neg/t5354.check | |
| parent | d188f6fdded6fdd9df3960d6085b9b80046c05ca (diff) | |
| download | scala-6975b4888da9b56e2c06d45da8f483f2e33a102b.tar.gz scala-6975b4888da9b56e2c06d45da8f483f2e33a102b.tar.bz2 scala-6975b4888da9b56e2c06d45da8f483f2e33a102b.zip | |
Closes SI-5354.
The reason why the test case compiled without error is pretty devious: When checking the `Foo.x' implicit, a CyclicReference error occurs which causes the alternative to be discarded. Why a CylicReference? Because the inferencer tries to decide whether the owner of `z` is a subclass of the owner od `x`. To do this, it computed the info of the owner of `z1`, which is not complete because no result type for `f1` was given. Hence a CyclicReference error.
The fix is twofold: (1) We make isNonBottomSubClass smarter so that it always returns false if the symbol in question is not a type; hence the info need not be computed. (2) It's dubious to swallow CyclicReference errors anywhere, but I deemed it too risky to propagate them. But at least the CyclicReference is now logged if -Ylog-implicit is true. This hopefully spares future maintainers the same detective work I had to go through when digging this out.
Diffstat (limited to 'test/files/neg/t5354.check')
| -rw-r--r-- | test/files/neg/t5354.check | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/test/files/neg/t5354.check b/test/files/neg/t5354.check new file mode 100644 index 0000000000..e47cecb5fe --- /dev/null +++ b/test/files/neg/t5354.check @@ -0,0 +1,7 @@ +t5354.scala:9: error: ambiguous implicit values: + both method x123 in package foo of type => foo.Bippy + and method z of type => foo.Bippy + match expected type foo.Bippy + implicitly[Bippy] + ^ +one error found |