Pickled flag reorg

Cleaned up and optimized code that maps between raw and pickled flags. Avoids mystery constants. Makes a whole bunch of new flags be pickled which were not pickled before (more precisely: Everything in InitialFlags with value greater than 1 << 31 which is not in FlagsNotPickled now gets pickled whereas before it wasn't. Among these: VARARGS, IMPLCLASS, SPECIALZED, DEFAULTINIT, SYNCHRONIZED. I am curious how many tickets will get fixed by this change.

The first one I noted is t5504, which previously enforced the buggy behavior through a neg check!

There are also some build manager check file changes that have to do with the fact that flags now print in a different order for performance reasons.

2 files changed, 12 insertions, 0 deletions

diff --git a/test/files/pos/t5504/s_1.scala b/test/files/pos/t5504/s_1.scala
new file mode 100644
index 0000000000..35cb2c8bae
--- /dev/null
+++ b/test/files/pos/t5504/s_1.scala
@@ -0,0 +1,4 @@
+// a.scala
+package object foo {
+  val m: List[_] = Nil
+}
diff --git a/test/files/pos/t5504/s_2.scala b/test/files/pos/t5504/s_2.scala
new file mode 100644
index 0000000000..03eecf6e19
--- /dev/null
+++ b/test/files/pos/t5504/s_2.scala
@@ -0,0 +1,8 @@
+// b.scala
+package foo
+
+object Test {
+  def main(args: Array[String]): Unit = {
+    println(foo.m)
+  }
+}