diff options
| author | Eugene Burmako <xeno.by@gmail.com> | 2014-01-28 11:29:28 +0300 |
|---|---|---|
| committer | Eugene Burmako <xeno.by@gmail.com> | 2014-02-14 14:08:57 +0100 |
| commit | 51b16e421ddd4e6c7e90ba945addf39ffcb4fa41 (patch) | |
| tree | d002d3dccfe613f830862a259957154523a21488 /test/files/run/t7582-private-within.check | |
| parent | edadc01df2cbac2c8a00c2e0cc520713690418b9 (diff) | |
| download | scala-51b16e421ddd4e6c7e90ba945addf39ffcb4fa41.tar.gz scala-51b16e421ddd4e6c7e90ba945addf39ffcb4fa41.tar.bz2 scala-51b16e421ddd4e6c7e90ba945addf39ffcb4fa41.zip | |
SI-8192 adds ClassSymbol.isPrimaryConstructor
Exposes a popular code pattern in macros as a dedicated reflection API.
This simple commit, however, ended up being not so simple, as it often
happens with our compiler.
When writing a test for the new API, I realized that our (pre-existing)
MethodSymbol.isPrimaryConstructor API returns nonsensical results for
implementation artifacts (trait mixin ctors, module class ctors).
What’s even more funny is that according to our reflection internals,
even Java classes have primary constructors. Well, that’s not surprising,
because `primaryConstructor` is just `decl(ctorName).alternatives.head`.
Good thing that package classes don’t have constructors or that would
elevate the situation to three fries short of a happy meal.
At the moment, I’m too scared to fiddle with internal#Symbol.primaryConstructor,
because that could easily break someone right before RC1, so I simply
documented the findings in SI-8193 and postponed the actual work, except
for one thing - isJavaDefined symbols no longer have primary constructors.
Diffstat (limited to 'test/files/run/t7582-private-within.check')
| -rw-r--r-- | test/files/run/t7582-private-within.check | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/files/run/t7582-private-within.check b/test/files/run/t7582-private-within.check index b2743ffa06..1b9a0910af 100644 --- a/test/files/run/t7582-private-within.check +++ b/test/files/run/t7582-private-within.check @@ -2,7 +2,7 @@ private[package pack] class JavaPackagePrivate private[package pack] module JavaPackagePrivate private[package pack] module class JavaPackagePrivate private[package pack] field field -private[package pack] primary constructor <init> +private[package pack] constructor <init> private[package pack] method meth private[package pack] field staticField private[package pack] method staticMeth |