diff options
author | aleksandar <aleksandar@lampmac14.epfl.ch> | 2012-01-26 16:38:54 +0100 |
---|---|---|
committer | aleksandar <aleksandar@lampmac14.epfl.ch> | 2012-01-26 16:38:54 +0100 |
commit | c608620531dcb47da43172c53891321c7beb98b0 (patch) | |
tree | a70c1a4e91ac58e6da0d2854d3416c406f6478c6 /test/files/scalacheck | |
parent | c94d342b385fa510882721b8b7f2070750c60f0e (diff) | |
download | scala-c608620531dcb47da43172c53891321c7beb98b0.tar.gz scala-c608620531dcb47da43172c53891321c7beb98b0.tar.bz2 scala-c608620531dcb47da43172c53891321c7beb98b0.zip |
Set fields in immutable hash maps and hash sets to vals.
This is part of an effort to make the immutable collections
(more) thread safe. The `::` still has non-final member fields
for head and tail, but there is not much that can be done right
now about that, since these fields are used by list buffers.
Tried writing a test with unsafe initialization, but could not
invent a scenario which actually fails, at least on the JDK6.
Diffstat (limited to 'test/files/scalacheck')
-rw-r--r-- | test/files/scalacheck/parallel-collections/ParallelIterableCheck.scala | 30 |
1 files changed, 15 insertions, 15 deletions
diff --git a/test/files/scalacheck/parallel-collections/ParallelIterableCheck.scala b/test/files/scalacheck/parallel-collections/ParallelIterableCheck.scala index fbacb9f45c..8273e302a2 100644 --- a/test/files/scalacheck/parallel-collections/ParallelIterableCheck.scala +++ b/test/files/scalacheck/parallel-collections/ParallelIterableCheck.scala @@ -414,21 +414,21 @@ abstract class ParallelIterableCheck[T](collName: String) extends Properties(col }).reduceLeft(_ && _) } - // property("groupBy must be equal") = forAll(collectionPairs) { - // case (t, coll) => - // (for ((f, ind) <- groupByFunctions.zipWithIndex) yield { - // val tgroup = t.groupBy(f) - // val cgroup = coll.groupBy(f) - // if (tgroup != cgroup || cgroup != tgroup) { - // println("from: " + t) - // println("and: " + coll) - // println("groups are: ") - // println(tgroup) - // println(cgroup) - // } - // ("operator " + ind) |: tgroup == cgroup && cgroup == tgroup - // }).reduceLeft(_ && _) - // } + property("groupBy must be equal") = forAll(collectionPairs) { + case (t, coll) => + (for ((f, ind) <- groupByFunctions.zipWithIndex) yield { + val tgroup = t.groupBy(f) + val cgroup = coll.groupBy(f) + if (tgroup != cgroup || cgroup != tgroup) { + println("from: " + t) + println("and: " + coll) + println("groups are: ") + println(tgroup) + println(cgroup) + } + ("operator " + ind) |: tgroup == cgroup && cgroup == tgroup + }).reduceLeft(_ && _) + } } |