SI-8970 hashCode of BigDecimal and Double do not match

Switched isValidDouble (binary equivalence) to isDecimalDouble (decimal expansion equivalence), as people generally do not care about the slew of extra decimal digits off the end of the binary approximation to a decimal fraction (decimal equivalence is the standard now).

Added minimal unit test to verify behavior.

1 files changed, 6 insertions, 0 deletions

diff --git a/test/junit/scala/math/BigDecimalTest.scala b/test/junit/scala/math/BigDecimalTest.scala
index d1ba96fcc8..c7a63da890 100644
--- a/test/junit/scala/math/BigDecimalTest.scala
+++ b/test/junit/scala/math/BigDecimalTest.scala
@@ -222,4 +222,10 @@ class BigDecimalTest {
     for (a <- different; b <- different if (a ne b))
       assert(a != b, "BigDecimal representations of Double mistakenly conflated")
   }
+
+  // Make sure hash code agrees with decimal representation of Double
+  @Test
+  def test_SI8970() {
+    assert((0.1).## == BigDecimal(0.1).##)
+  }
 }