diff options
author | Jason Zaugg <jzaugg@gmail.com> | 2013-03-24 13:56:19 +0100 |
---|---|---|
committer | Jason Zaugg <jzaugg@gmail.com> | 2013-03-24 21:41:37 +0100 |
commit | 8d537a13999878673b8d18c2429dbd6b97728e72 (patch) | |
tree | 565dc33ca2522659d7817dcc3d421b9eff115218 /test | |
parent | 1187c9896c097e6e591e5655b35f52c06b3c900a (diff) | |
download | scala-8d537a13999878673b8d18c2429dbd6b97728e72.tar.gz scala-8d537a13999878673b8d18c2429dbd6b97728e72.tar.bz2 scala-8d537a13999878673b8d18c2429dbd6b97728e72.zip |
SI-7294 Treat TupleN as final under -Xfuture
For the purposes of checkability warnings. This will
warn in case of:
scala> (1, 2) match { case Seq() => 0; case _ => 1 }
res9: Int = 1
Given how often Tuples are used as scrutinees, this is
a highly desirable place to warn.
I was orginally going to unlock this under -Xlint, and
could be easily convinced to go that way, given that
-Xfuture is a less popular option.
Diffstat (limited to 'test')
-rw-r--r-- | test/files/neg/t7294.check | 6 | ||||
-rw-r--r-- | test/files/neg/t7294.flags | 1 | ||||
-rw-r--r-- | test/files/neg/t7294.scala | 5 | ||||
-rw-r--r-- | test/files/pos/t7294.scala | 6 |
4 files changed, 18 insertions, 0 deletions
diff --git a/test/files/neg/t7294.check b/test/files/neg/t7294.check new file mode 100644 index 0000000000..f15289c1c0 --- /dev/null +++ b/test/files/neg/t7294.check @@ -0,0 +1,6 @@ +t7294.scala:4: warning: fruitless type test: a value of type (Int, Int) cannot also be a Seq[A] + (1, 2) match { case Seq() => 0; case _ => 1 } + ^ +error: No warnings can be incurred under -Xfatal-warnings. +one warning found +one error found diff --git a/test/files/neg/t7294.flags b/test/files/neg/t7294.flags new file mode 100644 index 0000000000..3f3381a45b --- /dev/null +++ b/test/files/neg/t7294.flags @@ -0,0 +1 @@ +-Xfuture -Xfatal-warnings diff --git a/test/files/neg/t7294.scala b/test/files/neg/t7294.scala new file mode 100644 index 0000000000..335d071124 --- /dev/null +++ b/test/files/neg/t7294.scala @@ -0,0 +1,5 @@ +object Test { + // Treat TupleN as final under -Xfuture for the for the purposes + // of the "fruitless type test" warning. + (1, 2) match { case Seq() => 0; case _ => 1 } +} diff --git a/test/files/pos/t7294.scala b/test/files/pos/t7294.scala new file mode 100644 index 0000000000..ccac2b1400 --- /dev/null +++ b/test/files/pos/t7294.scala @@ -0,0 +1,6 @@ +object Test { + // no fruitless warning as Tuple2 isn't (yet) final. + // The corresponding `neg` test will treat it as final + // for the purposes of these tests under -Xfuture. + (1, 2) match { case Seq() => 0; case _ => 1 } +} |