diff options
10 files changed, 32 insertions, 28 deletions
diff --git a/src/compiler/scala/reflect/reify/codegen/GenTrees.scala b/src/compiler/scala/reflect/reify/codegen/GenTrees.scala index d3d4b18d09..743fe131c4 100644 --- a/src/compiler/scala/reflect/reify/codegen/GenTrees.scala +++ b/src/compiler/scala/reflect/reify/codegen/GenTrees.scala @@ -129,11 +129,11 @@ trait GenTrees { else if (sym.isClass && !sym.isModuleClass) { if (reifyDebug) println("This for %s, reified as freeVar".format(sym)) if (reifyDebug) println("Free: " + sym) - mirrorBuildCall(nme.Ident, reifyFreeTerm(This(sym))) + mirrorBuildCall(nme.mkIdent, reifyFreeTerm(This(sym))) } else { if (reifyDebug) println("This for %s, reified as This".format(sym)) - mirrorBuildCall(nme.This, reify(sym)) + mirrorBuildCall(nme.mkThis, reify(sym)) } case Ident(name) => @@ -146,15 +146,15 @@ trait GenTrees { else if (!sym.isLocalToReifee) { if (sym.isVariable && sym.owner.isTerm) { captureVariable(sym) // Note order dependency: captureVariable needs to come before reification here. - mirrorCall(nme.Select, mirrorBuildCall(nme.Ident, reify(sym)), reify(nme.elem)) + mirrorCall(nme.Select, mirrorBuildCall(nme.mkIdent, reify(sym)), reify(nme.elem)) } - else mirrorBuildCall(nme.Ident, reify(sym)) + else mirrorBuildCall(nme.mkIdent, reify(sym)) } else mirrorCall(nme.Ident, reify(name)) case Select(qual, name) => if (qual.symbol != null && qual.symbol.isPackage) { - mirrorBuildCall(nme.Ident, reify(sym)) + mirrorBuildCall(nme.mkIdent, reify(sym)) } else { val effectiveName = if (sym != null && sym != NoSymbol) sym.name else name reifyProduct(Select(qual, effectiveName)) @@ -187,7 +187,7 @@ trait GenTrees { if (spliced == EmptyTree) { if (reifyDebug) println("splicing failed: reify as is") - mirrorBuildCall(nme.TypeTree, reify(tpe)) + mirrorBuildCall(nme.mkTypeTree, reify(tpe)) } else spliced match { case TypeRefToFreeType(freeType) => @@ -195,7 +195,7 @@ trait GenTrees { Ident(freeType) case _ => if (reifyDebug) println("splicing succeeded: " + spliced) - mirrorBuildCall(nme.TypeTree, spliced) + mirrorBuildCall(nme.mkTypeTree, spliced) } } else tree match { @@ -207,10 +207,10 @@ trait GenTrees { mirrorCall(nme.SelectFromTypeTree, reify(qual), reify(name)) case _ if sym.isLocatable => if (reifyDebug) println(s"tpe is locatable: reify as Ident($sym)") - mirrorBuildCall(nme.Ident, reify(sym)) + mirrorBuildCall(nme.mkIdent, reify(sym)) case _ => if (reifyDebug) println(s"tpe is not locatable: reify as TypeTree($tpe)") - mirrorBuildCall(nme.TypeTree, reify(tpe)) + mirrorBuildCall(nme.mkTypeTree, reify(tpe)) } } } diff --git a/src/compiler/scala/reflect/reify/utils/Extractors.scala b/src/compiler/scala/reflect/reify/utils/Extractors.scala index cfc42e31a9..4ec4de28c4 100644 --- a/src/compiler/scala/reflect/reify/utils/Extractors.scala +++ b/src/compiler/scala/reflect/reify/utils/Extractors.scala @@ -201,8 +201,8 @@ trait Extractors { object FreeRef { def unapply(tree: Tree): Option[(Tree, TermName)] = tree match { - case Apply(Select(Select(Select(uref @ Ident(_), internal), rs), ident), List(Ident(name: TermName))) - if internal == nme.internal && rs == nme.reificationSupport && ident == nme.Ident && name.startsWith(nme.REIFY_FREE_PREFIX) => + case Apply(Select(Select(Select(uref @ Ident(_), internal), rs), mkIdent), List(Ident(name: TermName))) + if internal == nme.internal && rs == nme.reificationSupport && mkIdent == nme.mkIdent && name.startsWith(nme.REIFY_FREE_PREFIX) => Some((uref, name)) case _ => None diff --git a/src/compiler/scala/tools/reflect/quasiquotes/Reifiers.scala b/src/compiler/scala/tools/reflect/quasiquotes/Reifiers.scala index 9078228314..af8b0be92c 100644 --- a/src/compiler/scala/tools/reflect/quasiquotes/Reifiers.scala +++ b/src/compiler/scala/tools/reflect/quasiquotes/Reifiers.scala @@ -7,7 +7,7 @@ import scala.reflect.internal.Flags._ trait Reifiers { self: Quasiquotes => import global._ - import global.build.{Select => _, Ident => _, TypeTree => _, _} + import global.build._ import global.treeInfo._ import global.definitions._ import Cardinality._ @@ -146,7 +146,7 @@ trait Reifiers { self: Quasiquotes => override def reifyTreeSyntactically(tree: Tree) = tree match { case RefTree(qual, SymbolPlaceholder(Hole(tree, _))) if isReifyingExpressions => - mirrorBuildCall(nme.RefTree, reify(qual), tree) + mirrorBuildCall(nme.mkRefTree, reify(qual), tree) case This(SymbolPlaceholder(Hole(tree, _))) if isReifyingExpressions => mirrorCall(nme.This, tree) case SyntacticTraitDef(mods, name, tparams, earlyDefs, parents, selfdef, body) => diff --git a/src/reflect/scala/reflect/api/Internals.scala b/src/reflect/scala/reflect/api/Internals.scala index 7d9fec3be0..70a74dd274 100644 --- a/src/reflect/scala/reflect/api/Internals.scala +++ b/src/reflect/scala/reflect/api/Internals.scala @@ -405,13 +405,13 @@ trait Internals { self: Universe => */ def setAnnotations[S <: Symbol](sym: S, annots: List[Annotation]): S - def This(sym: Symbol): Tree + def mkThis(sym: Symbol): Tree - def Select(qualifier: Tree, sym: Symbol): Select + def mkSelect(qualifier: Tree, sym: Symbol): Select - def Ident(sym: Symbol): Ident + def mkIdent(sym: Symbol): Ident - def TypeTree(tp: Type): TypeTree + def mkTypeTree(tp: Type): TypeTree def ThisType(sym: Symbol): Type @@ -465,7 +465,7 @@ trait Internals { self: Universe => def mkEarlyDef(defns: List[Tree]): List[Tree] - def RefTree(qual: Tree, sym: Symbol): Tree + def mkRefTree(qual: Tree, sym: Symbol): Tree def freshTermName(prefix: String): TermName diff --git a/src/reflect/scala/reflect/internal/ReificationSupport.scala b/src/reflect/scala/reflect/internal/ReificationSupport.scala index d4be708181..653beb4c2f 100644 --- a/src/reflect/scala/reflect/internal/ReificationSupport.scala +++ b/src/reflect/scala/reflect/internal/ReificationSupport.scala @@ -51,13 +51,13 @@ trait ReificationSupport { self: SymbolTable => def setInfo[S <: Symbol](sym: S, tpe: Type): S = sym.setInfo(tpe).markAllCompleted() - def This(sym: Symbol): Tree = self.This(sym) + def mkThis(sym: Symbol): Tree = self.This(sym) - def Select(qualifier: Tree, sym: Symbol): Select = self.Select(qualifier, sym) + def mkSelect(qualifier: Tree, sym: Symbol): Select = self.Select(qualifier, sym) - def Ident(sym: Symbol): Ident = self.Ident(sym) + def mkIdent(sym: Symbol): Ident = self.Ident(sym) - def TypeTree(tp: Type): TypeTree = self.TypeTree(tp) + def mkTypeTree(tp: Type): TypeTree = self.TypeTree(tp) def ThisType(sym: Symbol): Type = self.ThisType(sym) @@ -173,7 +173,7 @@ trait ReificationSupport { self: SymbolTable => def mkEarlyDef(defns: List[Tree]): List[Tree] = defns.map(mkEarlyDef) - def RefTree(qual: Tree, sym: Symbol) = self.RefTree(qual, sym.name) setSymbol sym + def mkRefTree(qual: Tree, sym: Symbol) = self.RefTree(qual, sym.name) setSymbol sym def freshTermName(prefix: String = nme.FRESH_TERM_NAME_PREFIX): TermName = self.freshTermName(prefix) diff --git a/src/reflect/scala/reflect/internal/StdNames.scala b/src/reflect/scala/reflect/internal/StdNames.scala index afb003b450..1e133eced9 100644 --- a/src/reflect/scala/reflect/internal/StdNames.scala +++ b/src/reflect/scala/reflect/internal/StdNames.scala @@ -725,8 +725,13 @@ trait StdNames { val moduleClass : NameType = "moduleClass" val mkAnnotation: NameType = "mkAnnotation" val mkEarlyDef: NameType = "mkEarlyDef" + val mkIdent: NameType = "mkIdent" val mkPackageStat: NameType = "mkPackageStat" val mkRefineStat: NameType = "mkRefineStat" + val mkRefTree: NameType = "mkRefTree" + val mkSelect: NameType = "mkSelect" + val mkThis: NameType = "mkThis" + val mkTypeTree: NameType = "mkTypeTree" val ne: NameType = "ne" val newArray: NameType = "newArray" val newFreeTerm: NameType = "newFreeTerm" @@ -749,7 +754,6 @@ trait StdNames { val runtime: NameType = "runtime" val runtimeClass: NameType = "runtimeClass" val runtimeMirror: NameType = "runtimeMirror" - val RefTree: NameType = "RefTree" val scala_ : NameType = "scala" val selectDynamic: NameType = "selectDynamic" val selectOverloadedMethod: NameType = "selectOverloadedMethod" diff --git a/test/files/run/macro-typecheck-macrosdisabled2.check b/test/files/run/macro-typecheck-macrosdisabled2.check index c0f9c436fe..2e862a6089 100644 --- a/test/files/run/macro-typecheck-macrosdisabled2.check +++ b/test/files/run/macro-typecheck-macrosdisabled2.check @@ -10,7 +10,7 @@ def apply[U <: scala.reflect.api.Universe with Singleton]($m$untyped: scala.reflect.api.Mirror[U]): U#Tree = { val $u: U = $m$untyped.universe; val $m: $u.Mirror = $m$untyped.asInstanceOf[$u.Mirror]; - $u.Apply.apply($u.Select.apply($u.internal.reificationSupport.Ident($m.staticModule("scala.Array")), $u.TermName.apply("apply")), scala.collection.immutable.List.apply[$u.Literal]($u.Literal.apply($u.Constant.apply(2)))) + $u.Apply.apply($u.Select.apply($u.internal.reificationSupport.mkIdent($m.staticModule("scala.Array")), $u.TermName.apply("apply")), scala.collection.immutable.List.apply[$u.Literal]($u.Literal.apply($u.Constant.apply(2)))) } }; new $treecreator1() diff --git a/test/files/run/toolbox_typecheck_macrosdisabled2.check b/test/files/run/toolbox_typecheck_macrosdisabled2.check index ca56dd44ac..86f89504d1 100644 --- a/test/files/run/toolbox_typecheck_macrosdisabled2.check +++ b/test/files/run/toolbox_typecheck_macrosdisabled2.check @@ -19,7 +19,7 @@ def apply[U <: scala.reflect.api.Universe with Singleton]($m$untyped: scala.reflect.api.Mirror[U]): U#Tree = { val $u: U = $m$untyped.universe; val $m: $u.Mirror = $m$untyped.asInstanceOf[$u.Mirror]; - $u.Apply.apply($u.Select.apply($u.internal.reificationSupport.Ident($m.staticModule("scala.Array")), $u.TermName.apply("apply")), scala.collection.immutable.List.apply[$u.Literal]($u.Literal.apply($u.Constant.apply(2)))) + $u.Apply.apply($u.Select.apply($u.internal.reificationSupport.mkIdent($m.staticModule("scala.Array")), $u.TermName.apply("apply")), scala.collection.immutable.List.apply[$u.Literal]($u.Literal.apply($u.Constant.apply(2)))) } }; new $treecreator1() diff --git a/test/files/scalacheck/quasiquotes/ForProps.scala b/test/files/scalacheck/quasiquotes/ForProps.scala index 87ff7f8205..b14d345edd 100644 --- a/test/files/scalacheck/quasiquotes/ForProps.scala +++ b/test/files/scalacheck/quasiquotes/ForProps.scala @@ -1,5 +1,5 @@ import org.scalacheck._, Prop._, Gen._, Arbitrary._ -import scala.reflect.runtime.universe._, Flag._, internal.reificationSupport.{Ident => _, _} +import scala.reflect.runtime.universe._, Flag._, internal.reificationSupport._ object ForProps extends QuasiquoteProperties("for") { case class ForEnums(val value: List[Tree]) diff --git a/test/files/scalacheck/quasiquotes/TypecheckedProps.scala b/test/files/scalacheck/quasiquotes/TypecheckedProps.scala index 1f8df168cf..8b1cb6cc49 100644 --- a/test/files/scalacheck/quasiquotes/TypecheckedProps.scala +++ b/test/files/scalacheck/quasiquotes/TypecheckedProps.scala @@ -1,5 +1,5 @@ import org.scalacheck._, Prop._, Gen._, Arbitrary._ -import scala.reflect.runtime.universe._, Flag._, internal.reificationSupport.{Ident => _, _} +import scala.reflect.runtime.universe._, Flag._, internal.reificationSupport._ object TypecheckedProps extends QuasiquoteProperties("typechecked") { def original(tree: Tree) = tree match { |