| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
This should assist in keeping line endings straight.
It is designed to enforce LF endings everywhere except
for files specifically for windows.
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
# By Martin Odersky
* pull-1352-reformatted:
Disabled failing build manager tests.
New test case for SI-6337
New test case for closing SI-6385
Value classes: eliminated half-boxing
Cleanup of OverridingPairs
Fixes SI-6260
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When the refined build manager computes its change sets it mixes up
the types. It computes constructors of inner classes of the first
compilation that point to types of the second compilation. This
breaks a useful assertion in ExtensionMethods. The error you get for
t4245 is
java.lang.AssertionError: assertion failed: unexpected constructor
erasure A#6956.this.B#20211 for class B#6963
What goes on here is that the primary constructor of inner
class B#6963 points to the new version of that inner class
A#6956.this.B#20211. This happens during the computation of change
sets, not during normal compilation. Since it looks like the
computation of change sets is broken I have disabled the tests,
rather than disabling the assertion.
It seems that during residential compilation, the result type of a
constructor can be a different version of the enclosing class. I
could not reproduce this
|
| |
| |
| |
| |
| | |
This test case shows that the variant in the comment of SI-6337 now
compiles also.
|
| |
| |
| |
| |
| | |
The fixes for SI-6260 + elimination of hlaf-boxing also solve
SI-6385
|
| |
| |
| |
| |
| |
| |
| | |
We now apply erasure of value classes everywhere. previously,
erasure was disabled in the value class itself. This led to
irregegularities and bugs. See test run/valueclasses-pavlov.scala
for something that led to a ClassCastException before.
|
| |
| |
| |
| |
| | |
Added a default value to a hashmap so that we can work with it
without Option acrobatics.
|
|/
|
|
|
|
|
|
| |
Guards against bridge methods that clash with other methods. Two
tests: The neg test is the original ticket. The run test tweaks
things slightly so that the generated bridge method does not clash,
and tests that the necessary unboxings are indeed performed at
runtime.
|
|\
| |
| | |
Fix problem with names encoding in scalap.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The refactoring performed in 020053c321 made use of naming encoding
more consisted but introduced a regression in scalap. The problem
is that the old encoder that scalap had didn't escape any characters
that were not included in its opcode list.
`NameTransformer` performs full encoding so it also encodes dots
that are being used as separators for packages. Therefore, in order
to retain the old behaviour we need to split the name by dots before
feeding each fragment to `NameTransformer`.
Review by @paulp.
|
|\ \
| | |
| | | |
SI-5943 toolboxes now autoimport Predef and scala
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously tb.typeCheck used default typer, which builds upon NoContext.
Changing the context to analyzer.rootContext(NoCompilationUnit, EmptyTree)
fixed the missing imports problem.
Unfortunately this doesn't help in cases like "math.sqrt(4.0)" because of
https://issues.scala-lang.org/browse/SI-6393. But anyways I'm adding
this test case to pending.
|
|\ \ \
| | | |
| | | | |
existentially typed macro expansions now work fine
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Now, when the existential reification bug is fixed, I've been able
to take a look at SI-5418, and, apparently, the problem with importers
has fixed itself during these 9 months of the bug being active.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If one tries to compile the following code with the parent of this commit:
ru.reify(new Object().getClass)
then the following error will occur:
Test.scala:2: error: type mismatch;
found : $u.Expr[Class[_ <: Object]]
required: reflect.runtime.universe.Expr[Class[?0(in value <local Test>)]]
where type ?0(in value <local Test>) <: Object
ru.reify(new Object().getClass)
^
This happens because macro expansions are always typechecked against the
return type of their macro definitions instantiated in the context of expandee.
In this case the expected type contains skolems which are incompatible
with wildcards in the type of the expansion.
I tried all the incantations I could think of - without any success.
Luckily I met Martin who pointed me at the same problem solved in adapt
(see the diff w.r.t Typers.scala).
|
|\ \ \
| | | |
| | | | |
SI-6392 wraps non-terms before typecheck/eval
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Wrap non-term arguments of typecheck and eval, so that toolboxes
can work with full-fledged files (except for package declarations).
|
|\ \ \ \
| | | | |
| | | | | |
merges scala.reflect.base into scala.reflect.api
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As the experience has shown, there's no need for a separate layer of reflection
in scala-library.jar. Therefore I'm putting an end to it.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Reification (both tree-based and type-based) should be avoided
before we release 2.10.0-final, since it impairs reflection refactorings
like the upcoming one.
Also the upcoming refactoring moves tag materialization anchors, and we
have to add them to fast track in advance, so that they are treated as
macros later.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
NameType is introduced in base.StandardNames#NamesBase to abstract away the
difference between term names and type names in order to encode common names
such as EMPTY or WILDCARD.
Flavor-specific name repositories, such as TermNames and TypeNames are supposed
to override NameType fixing it to correspondingly TermName or TypeName.
Unfortunately I completely overlooked this and as a result some standard names
were typed with insufficient precision, e.g. This(tpnme.EMPTY) didn't work.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Introduced by uncurry - therefore it can be seen
neither by macros, nor by runtime reflection.
Despite never being pickled, ArrayValue is supported by unpickler
so I couldn't move it exclusively to scala-compiler.jar.
Figuring out the mysterious reason for pickling ArrayValue is left
to future work.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Removed many @inline annotations and final modifiers.
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is my belief that these @inlines and finals landed between
unhelpful and harmful. I am sure this will be disputed in some
cases. It's too much and too difficult to measure except in the
aggregate unless we have specific @inline sites to discuss.
I don't know upon whom the burden of proof lies. I think we
should err on the side given here, since there is no evidence
of any consistent rationale being applied and it is easy to
verify the negative impact scala compiler inlining can have on
hotspot's far more sophisticated inlining.
|
|\ \ \ \
| |_|_|/
|/| | | |
Rank based take/drop/slice
|
| | | |
| | | |
| | | |
| | | | |
Addresses review feedback by axel22.
|
| | | |
| | | |
| | | |
| | | | |
Addresses code review feedback by @axel22.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Tree navigation based on node rank is faster than using compare
method. rank is simply count(tree.left) + 1.
|
|\ \ \ \
| |_|_|/
|/| | | |
Fixes SI-6354: improved error messages for Dynamic signature mismatches.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If an error occurs afer a Dynamic rewriting, augment the error message
with the rewritten tree and a hint to check the Dynamic method
signature.
|
|\ \ \ \
| | | | |
| | | | | |
improved reflection documentation
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
SI-6287 fixes synthetic symbol clashes in toolbox
|
| | | | | |
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Apparently synthetic classes like $anonfun$1 have two properties:
1) Their names are generated using a counter unique to a compilation unit
2) After flatten they levitate to the nearest enclosing package
As a result if we use an empty package to wrap toolbox codegen,
then this package will soon be overflown by $anonfun$1 symbols, because:
1) New codegen session = new compilation unit = new counter which starts at 0
2) New codegen session = new anon funs that end up as children of empty package
Creating a freshly named package for each codegen session fixed the problem.
Now anonfuns from different sessions end up with different parents.
|
|\ \ \ \
| | | | |
| | | | | |
clarify caveats of App trait
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Scala reflection now supports Java CRTP
|
| | | | |
| | | | |
| | | | |
| | | | | |
All javac-produced artifacts are now placed into test/files/lib
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Enum members are static and, therefore, they need to be looked up in
classSymbol(<enum>).companionModule, rather than in classSymbol(<enum>).
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Because of using plain ExistentialType factory of a case class
typeToScala sometimes returned existentials with empty quantifieds.
Changing ExistentialType to newExistentialType, which simply returns
the underlying types if params are empty, fixed the problem.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Translation of Java types to Scala types has previously been
existentionalizing raw types of ParameterizedType arguments.
As shown in https://issues.scala-lang.org/browse/SI-6374
this leads to cyclic reference errors. If you wonder about the
mechanism of the error, take a look at the comments to the
aforementioned issue - there's a detailed explanation.
However calling rawToExistential is completely unnecessary, because
existential parameters of the results are immediately discarded,
and only prefix and symbol are used later on (which means that
existential extrapolation performed by rawToExistential also doesn't
after the result).
Finding out this was tough, but the rest was a piece of cake.
Getting rid of the call to rawToExistential when translating ParameterizedType
fixed the problem.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
SI-5767 fix + protecting public FlatHashMap API
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
As discussed in https://groups.google.com/forum/?pli=1#!topic/scala-internals/1yABM30POS0
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- `LinkedHashSet` implementation moved from `FlatHashTable` to `HashTable`
- `remove` time reduced from O(n) to O(1)
- `diff` time reduced from O(n^2) to O(n)
- A bit of refactoring in `HashTable` serialization code
- Putting an element into hash map now avoids double hash code/hash index
calculation (see `HashTable#findOrAddEntry`)
- bugfix: compiler/LambdaLift occasionally breaks LinkedHashSet integrity
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Revert `@static` annotation
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
It's a follow-up commit on 4bfcadabae7663e4329f5a4b21a9368477a7e3e3.
|