| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
`isFunctionType` and `isTupleType` started returing true for
type constructors as of aeb73314. This led to a crash in type
printing in ScalaDoc (specfically, in ModelFactoryTypeSupport.scala)
This commit:
- fixes those methods by guarding with !isHigherKinded
- unit tests said methods
- tests the reported crasher with a ScalaDoc test.
|
|\
| |
| | |
SI-4742 Make -Xcheckinit aware of constants.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Members defined as `final val x = <literal>` are given
a ConstantType. The constant is folded into the accessor
method `x`, and the field itself is never initialized.
(Related discussion: SI-4605)
As such, -Xcheckinit spuriously warns when calling that
accessor.
This commit disables the checks for constants.
This will also fix the checkinit build (failure tracked as SI-7839),
which is the victim of this a spurious scolding.
|
|\ \
| |/
|/| |
Revert #2957
|
| |
| |
| |
| |
| |
| |
| |
| | |
The starting bound for ValDefs in #2957 is distinct from the expected result, e.g.
[4:9]val x = [8:9]0
instead of
[0:9]val x = [8:9]0
|
| |
| |
| |
| |
| | |
This reverts commit 884e1ce762d98b29594146d37b85384581d9ba96, reversing
changes made to f6fcc4431f272c707d49de68add532c452dd4b0f.
|
|\ \
| |/
|/| |
SI-7868 Account for numeric widening in match translation
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Pattern match translation was unprepared for trees of the shape:
(0: Short) match {
case A.unapply(<unapply-selector>.toInt) <unapply> (_) => ()
case _ => ()
}
While a scrutinee is inelibigle for implicit views in order to
conform to the type of the extractor call, it is allowed to
weakly conform. In this case, the typechecker will add the
numeric widening with a `toInt` call.
This commit:
- Changes treeInfo.Unapplied to recognize this tree shape
- Changes spliceApply to recognize and preserve the widening
when substituting the unapply selector with the binder
- Tests reification of such pattern matches, which also depends
on treeInfo.Unapplied.
|
|\ \
| | |
| | | |
SI-7725 - Vector concatenation is unreasonably slow
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rewrote ++ to use append or prepend when adding small collections to the end
or beginning of vectors. This solves the extra-O(n) problem for addition of
single elements reported in SI_7725.
Renamed LgConcatFaster to Log2ConcatFaster (more widely recognizable).
|
|\ \ \
| | | |
| | | | |
Upgrade: starr=M5, partest=RC5, xml=RC4, parsers=RC2.
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
SI-7848 Xlint says what looks interpolated
|
| | | |
| | | |
| | | |
| | | | |
This idea brought to you by retronym.
|
| | | |
| | | |
| | | |
| | | | |
Avoid extra work, extra warnings.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The motivating use case was an Expecty debug string
getting flagged for `$eq`.
The test case demonstrates a different bug, in which
the position of the literal tree is changed when typer
gets rid of the unused local, so that when the tree is
re-typed in erasure, a second, spurious warning is
emitted at the start of the method. Specifically, the
second warning is not suppressed because of the
different position.
|
|\ \ \ \
| | | | |
| | | | | |
Fix typo in documentation.
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Quasiquotes: add syntactic extractor for assignment-like trees
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
There are three kinds of assign-like trees:
1. Assign(lhs, rhs) // $lhs = $rhs
3. AssignOrNamedArg(lhs, rhs) // $lhs = $rhs
2. Apply(Select(f, nme.update), args :+ rhs) // $f(..$args) = $rhs
New syntactic combinator unifies all of them and lets users not to think
about these implementations details.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Follow good interrupt discipline in Response
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Restores the interrupted status of the waiting thread after catching
an InterruptException.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SI-7864 Harden "looks like an interpolated String" warning
|
| | |_|_|_|/
| |/| | | |
| | | | | |
| | | | | |
| | | | | | |
We can't rely on the qualifier of an `Apply` having a non-null
symbol in general.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Avoid null checks when emitting "".== and SomeModule.==
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Directly count null checks, rather than diffing the textual
bytecode of the entire method
- Add a test to show that the LHS needs to be a direct module
reference, not just a tree with a module type, to elide the
null check.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
For the same reasons outlined in the previous commits.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
For which we can also elide the null check, and will in the
next commit.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Although the same the code would be later optimized by -Yconst-opt,
we can offer the same lean byte code to those compiling without that
option by being more discerning when translating ==.
This helps people using bytecode based code coverage tools
such as jacoco that would emit "branch not covered" warnings
for the impossible null check.
|
| | |_|/ /
| |/| | |
| | | | |
| | | | | |
Will be somewhat leaner after the next commit.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Convenience methods from Try[T] => {Future, Promise}[T]
|
| | |_|_|/
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Require Ant >= 1.8.2
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Reportedly our build fails with Ant earlier incarnations.
Time to raise the bar.
Tested by temporarily setting the requirement to 1.8.5 and observing:
% ant init
Buildfile: /Users/jason/code/scala/build.xml
desired.jars.uptodate:
boot:
init:
BUILD FAILED
/Users/jason/code/scala/build.xml:216: Ant version 1.8.5 is required. You are running Apache Ant(TM) version 1.8.4 compiled on May 22 2012
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix SI-7862: MANIFEST.MF file for Scala sources
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In order to be able to use published Scala jars as OSGi bundles in the
Eclipse build, Eclipse needs to match sources and binaries. That is
done by making source jars *source bundles*. This PR adds the required
manifest entries. Nothing else should be affected (file names remain
the same).
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Add test case for SI-6719
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The bug itself was fixed earlier in 95fe19545d60ae9aa79d2c8d5665c7f3b0cbdb1a
It was caused by improper wrapping of blocks in the toolbox's parse method.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Parser and position improvements.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The parser hole I found while working on the generated positions
serves as the umbrella for a host of improvements. Upgraded
positions assigned during some specific challenging situations mostly
involving the creation of synthetic trees, e.g. for comprehensions
and closures. While doing so improved some error messages.
Eliminated some of the most glaring duplication in the parser.
It's written like there is some payoff associated with being
spectacularly imperative. Not so far.
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Can't ensure range position points are meaningful when we never
see them. To limit noise, only print the point when it != start.
[x:y] // point=x, start=x, end=y
[p/x:y] // point=p, start=x, end=y
I'm open to a different syntax.
Also prints NoPosition as [X] rather than [NoPosition] because
noise is for construction workers and attenders of rock concerts.
Some range position and parser tests are included so we can see
the checkfile change when the forthcoming fix happens (either an
error message improvement or a positional one.)
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Cautiously give PC more control over docComments table
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Type housekeeping.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Moved ListOfNil somewhere more generally accessible. No
reason the compiler should hoard it for itself. Flitted
to a few locations with constructs like ".head.head" and
".tail.head" looking for code which could be rewritten. Found
some, admittedly not always making use of ListOfNil.
Made overdue moves of ConstantType(Constant(true|false|null))
to vals in Definitions.
|
|\ \ \ \
| | | | |
| | | | | |
Cull extraneous whitespace.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
One last flurry with the broom before I leave you slobs to code
in your own filth. Eliminated all the trailing whitespace I
could manage, with special prejudice reserved for the test cases
which depended on the preservation of trailing whitespace.
Was reminded I cannot figure out how to eliminate the trailing
space on the "scala> " prompt in repl transcripts. At least
reduced the number of such empty prompts by trimming transcript
code on the way in.
Routed ConsoleReporter's "printMessage" through a trailing
whitespace stripping method which might help futureproof
against the future of whitespace diseases. Deleted the up-to-40
lines of trailing whitespace found in various library files.
It seems like only yesterday we performed whitespace surgery
on the whole repo. Clearly it doesn't stick very well. I suggest
it would work better to enforce a few requirements on the way in.
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Silence pos/t3960's -Ycheck output.
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Someday someone will have to straighten out where output goes.
Clearly under current conditions, Console.err is not a good place.
I rerouted through unit.warning so the output will be swallowed
like all the other warnings.
|