summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Set `canRetransform` flag to `false` in instrumentation.Grzegorz Kossakowski2013-01-241-1/+1
| | | | | | | | | | We do not need to retransform classes once they are loaded. All instrumentation byte-code is pushed at loading time. This fixes a problem with Java 7 that was failing to add a transformer because we did not declare retransformation capability in `MANIFEST.MF` file in Java agent jar. Java 6 allowed to add transformer due to a bug.
* Correct whitespace in `ASMTransformer.java`.Grzegorz Kossakowski2013-01-241-27/+27
| | | | Let's stick to 2 spaces for indentation (and no tabs).
* Fix class loader issues in instrumentation tests.Nada Amin2013-01-241-2/+28
| | | | | | | | | | | | | The ASM ClassWriter uses a wimpy class loader when computing common superclasses. This could cause a ClassNotFoundException in the transform method (at reader.accept). This exception gets swallowed, resulting in a class that should be instrumented to silently not be. The fix is to override getCommonSuperClass to use the correct class loader. Trivia: This bug was discovered while 'stress-testing' this instrumentation scheme on the Coursera students, to check that they implement one method in terms of another in the assignment.
* Merge pull request #1958 from JamesIry/SI-6434_2.10.xPaul Phillips2013-01-243-2/+22
|\ | | | | SI-6434 Pretty print function types with by name arg as (=> A) => B
| * SI-6434 Pretty print function types with by name arg as (=> A) => BJames Iry2013-01-233-2/+22
|/ | | | | | | | | We were pretty printing a function type with one by name arg as => A => B, but because => is right associative that's formally equivalent to => (A => B) and that's entirely a different thing. This commit changes the pretty printer in Typers.scala to check for a byname argument on a function type and wrap it in parens. A REPL test is included.
* Merge pull request #1944 from paulp/pr/remove-classfilesPaul Phillips2013-01-222-0/+0
|\ | | | | Removed class files.
| * Removed class files.Paul Phillips2013-01-212-0/+0
|/ | | | Someone checked in a pair of .class files.
* Merge pull request #1915 from adriaanm/ticket-6942Paul Phillips2013-01-204-25/+349
|\ | | | | SI-6942 more efficient CNF conversion in patmat analysis
| * use ArrayBuffer instead of Array to build FormulaeAdriaan Moors2013-01-171-3/+3
| |
| * SI-6942 more efficient unreachability analysisAdriaan Moors2013-01-174-24/+348
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Avoid blowing the stack/the analysis budget by more eagerly translating the propositions that model matches to CNF. First building a large proposition that represents the match, and then converting to CNF tends to blow the stack. Luckily, it's easy to convert to CNF as we go. The optimization relies on `CNF(P1 /\ ... /\ PN) == CNF(P1) ++ CNF(...) ++ CNF(PN)`: Normalizing a conjunction of propositions yields the same formula as concatenating the normalized conjuncts. CNF conversion is expensive for large propositions, so we push it down into the conjunction and then concatenate the resulting arrays of clauses (which is cheap). (CNF converts a free-form proposition into an `Array[Set[Lit]]`, where: - the Array's elements are /\'ed together; - and the Set's elements are \/'ed; - a Lit is a possibly negated variable.) NOTE: - removeVarEq may throw an AnalysisBudget.Exception - also reworked the interface used to build formula, so that we can more easily plug in SAT4J when the time comes
* | Merge pull request #1904 from JamesIry/SI-5568_2.10.xGrzegorz Kossakowski2013-01-183-6/+46
|\ \ | |/ |/| SI-5568 Fixes verify error from getClass on refinement of value type
| * SI-5568 Comment improvements for getClass on primitive intersection.James Iry2013-01-152-7/+9
| | | | | | | | | | Based on code review here are a few comment cleanups and the removal of some dead test code.
| * SI-5568 Fixes verify error from getClass on refinement of value typeJames Iry2013-01-153-6/+44
| | | | | | | | | | | | | | | | ().asInstanceOf[AnyRef with Unit].getClass and 5.asInstanceOf[AnyRef with Int].getClass would cause a verify error. Going the other way, i.e. [Unit with AnyRef] or [Int with AnyRef] worked fine. This commit fixes it that both directions work out to BoxedUnit or java.lang.Integer.
* | Merge pull request #1914 from retronym/ticket/6601Grzegorz Kossakowski2013-01-175-1/+10
|\ \ | | | | | | SI-6601 Publicise derived value contstructor after pickler
| * | SI-6601 Publicise derived value contstructor after picklerJason Zaugg2013-01-165-1/+10
| | | | | | | | | | | | | | | | | | | | | Otherwise the access restrictions are not enforced under separate compilation. See also SI-6608.
* | | Merge pull request #1854 from pufuwozu/ticket-SI-6923Paul Phillips2013-01-175-3/+39
|\ \ \ | | | | | | | | SI-6923 Context now buffers warnings as well as errors
| * | | SI-6923 Context now buffers warnings as well as errorsBrian McKenna2013-01-075-3/+39
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code that was silently typed would not report warnings, even if it returned a successful result. This appeared in the following code which didn't show warnings even with -Ywarn-adapted-args: def foo(a: Any) = a; foo(1, 2) While the following would show the expected warning: def foo[A](a: Any) = a; foo(1, 2)
* | | Merge pull request #1905 from adriaanm/ticket-6956Paul Phillips2013-01-173-2/+31
|\ \ \ | | | | | | | | SI-6956 determine switchability by type, not tree
| * | | use Constant::isIntRange even if it's NIHAdriaan Moors2013-01-151-1/+1
| | | |
| * | | SI-6956 determine switchability by type, not treeAdriaan Moors2013-01-153-2/+31
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Constant folding will set the type of a constant tree to `ConstantType(Constant(folded))`, while the tree itself can be many different things (in casu, an Ident). We used to look at the tree directly when deciding whether to emit a switch. Now we look at the tree's type. Voilà.
* | | Merge pull request #1892 from retronym/ticket/6479Paul Phillips2013-01-152-2/+60
|\ \ \ | |/ / |/| | SI-6479 Don't lift try exprs in label arguments.
| * | SI-6479 Don't lift try exprs in label arguments.Jason Zaugg2013-01-132-2/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new pattern matcher uses label jumps to GOTO the next case. Uncurry treated these like regular method arguments, and performed the liftedTree() transformation, which ensures that try expressions are only used in a statement position. Even try in statement position of a block used as such an argument are subject to the same transform. This transform stems from the JVM limitation, that try/catch does not leave a value on the stack. See b194446. This commit changes Uncurry to avoid this transform for arguments to label jumps. This avoids needlessly indirect code, and enables tail call elimination in more cases. As an example, Scala 2.10.0 transforms the last method of the enclosed test case to: try { case <synthetic> val x1: Int = 1; case5(){ if (2.==(x1)) { val x2: Int = x1; matchEnd4({ { def liftedTree2(): Unit = try { throw new scala.runtime.NonLocalReturnControl[Unit](nonLocalReturnKey1, ()) } catch { case (e @ (_: ClassNotFoundException)) => () }; liftedTree2() }; TailrecAfterTryCatch.this.bad() }) } else case6() }; case6(){ matchEnd4(throw new MatchError(x1)) }; matchEnd4(x: Unit){ x } } catch { case (ex @ (_: scala.runtime.NonLocalReturnControl[Unit @unchecked])) => if (ex.key().eq(nonLocalReturnKey1)) ex.value() else throw ex } After this patch: @scala.annotation.tailrec final def bad(): Unit = { case <synthetic> val x1: Int = 1; case5(){ if (2.==(x1)) { <synthetic> val x2: Int = x1; matchEnd4({ try { return () } catch { case (e @ (_: ClassNotFoundException)) => () }; TailrecAfterTryCatch.this.bad() }) } else case6() }; case6(){ matchEnd4(throw new MatchError(x1)) }; matchEnd4(x: Unit){ x } }
* | | Merge pull request #1895 from JamesIry/SI_6963_2.10.xPaul Phillips2013-01-154-1/+8
|\ \ \ | | | | | | | | SI-6963 Deprecates -Xmigration switch
| * | | SI-6963 Deprecates -Xmigration switchJames Iry2013-01-144-1/+8
| |/ / | | | | | | | | | | | | | | | -Xmigration is specific to the 2.7 to 2.8 upgrade and is no longer relevant. There is no plan to maintain it so it will be removed. This commit deprecates it in anticipation.
* | | Merge pull request #1888 from retronym/ticket/6675Paul Phillips2013-01-1511-10/+53
|\ \ \ | | | | | | | | SI-6675 -Xlint arity enforcement for extractors
| * | | SI-6675 Test new warning under -Xoldpatmat.Jason Zaugg2013-01-153-0/+18
| | | | | | | | | | | | | | | | This commit should be discarded when merging to master.
| * | | SI-6675 -Xlint arity enforcement for extractorsJason Zaugg2013-01-158-10/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extractor Patterns changed in 2.10.0 to implement the letter of the spec, which allows a single binding to capture an entire TupleN. But this can hide arity mismatches, especially if the case body uses the bound value as an `Any`. This change warns when this happens under -Xlint.
* | | | Merge pull request #1879 from adriaanm/ticket-6955Paul Phillips2013-01-153-1/+28
|\ \ \ \ | | | | | | | | | | SI-6955 switch emission no longer foiled by type alias
| * | | | SI-6955 switch emission no longer foiled by type aliasAdriaan Moors2013-01-103-1/+28
| | | | | | | | | | | | | | | | | | | | | | | | | dealias the type of the scrutinee before checking it's switchable now with tests! (using IcodeTest since javap is not available everywhere)
* | | | | Merge pull request #1894 from retronym/ticket/6082Adriaan Moors2013-01-143-4/+22
|\ \ \ \ \ | | | | | | | | | | | | SI-6082 Conditionally expand @ann(x) to @ann(value = x)
| * | | | | SI-6082 Conditionally expand @ann(x) to @ann(value = x)Jason Zaugg2013-01-133-4/+22
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... if the annotation has an argument with the name `value`. Doing so unconditionally obscures error messages. We still require that arguments to ClassFileAnnotations are named, other than for this special case.
* | | | | Merge pull request #1890 from retronym/ticket/5440Adriaan Moors2013-01-143-0/+13
|\ \ \ \ \ | | | | | | | | | | | | SI-5440 Test case for exhaustiveness check
| * | | | | SI-5440 Test case for exhaustiveness checkJason Zaugg2013-01-133-0/+13
| | |_|/ / | |/| | | | | | | | | | | | | Reported against patmatclassic, working in virtpatmat.
* | | | | Merge pull request #1889 from retronym/ticket/5340Adriaan Moors2013-01-143-1/+36
|\ \ \ \ \ | | | | | | | | | | | | SI-5340 Change println to log
| * | | | | SI-5340 Change println to logJason Zaugg2013-01-133-1/+36
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | An esoteric implicit search could trigger an "amb prefix ..." message to standard out. Now the message has been improved and sent to the logger.
* | | | | Merge pull request #1878 from adriaanm/ticket-6925Adriaan Moors2013-01-145-145/+183
|\ \ \ \ \ | | | | | | | | | | | | SI-6925 use concrete type in applyOrElse's match's selecto
| * | | | | clean up synthesizePartialFunctionAdriaan Moors2013-01-103-19/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | implement the following review comments by @retronym: - [x] Please clothe this naked assert. - [x] Use match to dissect targs and check isFullyDefined. - [x] Instead of `targs.head`/`targs.last`, use `val argTp :: resTp :: Nil = targs`. - [x] Add a quasi-quote-style comment for `apply`. - [x] Factor out mkCastPreservingAnnotations.
| * | | | | rework partial function synthesisAdriaan Moors2013-01-092-146/+163
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | no behavioral changes, just highly overdue cleanup some TODOs for further improvements
| * | | | | SI-6925 use concrete type in applyOrElse's match's selectorAdriaan Moors2013-01-092-1/+19
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a regression introduced in 28483739c3: PartialFunction synthesis was broken so that we'd get: ``` scala> def f[T](xs: Set[T]) = xs collect { case x => x } f: [T](xs: Set[T])scala.collection.immutable.Set[_ <: T] ``` rather than ``` scala> def f[T](xs: Set[T]) = xs collect { case x => x } f: [T](xs: Set[T])scala.collection.immutable.Set[T] ```
* | | | | Merge pull request #1876 from adriaanm/ticket-5189-infAdriaan Moors2013-01-143-6/+19
|\ \ \ \ \ | | | | | | | | | | | | SI-5189 detect unsoundness when inferring type of match
| * | | | | SI-5189 detect unsoundness when inferring type of matchAdriaan Moors2013-01-093-6/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GADT skolems encode type slack that results from pattern matching on variant type constructors I thought they would not longer be relevant after cases have been typed, and since they caused weird issues with the old pattern matcher, I deskolemized in typedCase however, when we don't have an expected type for the match, we need to keep the skolems around until the skolemized type makes it out of the match and it becomes the result of type inference for that match when you do have an expected type, it will propagate to the case-level and the confrontation will thus already take place when typing individual cases
* | | | | | Merge pull request #1872 from kzys/jira-6555-2.10.xAdriaan Moors2013-01-141-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | SI-6555 Scaladoc's class filter shouldn't drop the last character (2.10.x)
| * | | | | | SI-6555 Scaladoc's class filter shouldn't drop the last characterKato Kazuyoshi2013-01-091-1/+1
| | |/ / / / | |/| | | | | | | | | | | | | | | | The event handler have to wait "keyup", not "keydown".
* | | | | | Merge pull request #1860 from heathermiller/issue/6930Adriaan Moors2013-01-141-0/+14
|\ \ \ \ \ \ | | | | | | | | | | | | | | SI-6930 adds documentation to reduceLeft in TraversableOnce
| * | | | | | SI-6930 adds documentation to reduceLeft in TraversableOnceHeather Miller2013-01-081-0/+14
| | |/ / / / | |/| | | |
* | | | | | Merge pull request #1838 from viktorklang/wip-6905-√Adriaan Moors2013-01-142-4/+28
|\ \ \ \ \ \ | | | | | | | | | | | | | | SI-6594 - Switch to sneakyThrows instead of Unsafe.throwException as per...
| * | | | | | SI-6905 - Switch to sneakyThrows instead of Unsafe.throwException as per new ↵Viktor Klang2013-01-142-4/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | jsr166y to avoid issues with Android
* | | | | | | Merge pull request #1891 from retronym/ticket/6126Adriaan Moors2013-01-141-0/+8
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | SI-6126 Test case for varargs of tagged primitives.
| * | | | | | | SI-6126 Test case for varargs of tagged primitives.Jason Zaugg2013-01-131-0/+8
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | This started working after the merge fe1110f. I didn't track down precisely which commit was responsible beyond that.
* | | | | | | Merge pull request #1875 from heathermiller/issue/6946Adriaan Moors2013-01-141-15/+86
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | SI-6946, SI-6924 Greatly improves IsTraversableLike docs
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-21 11:14:25 +0000