| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
Another corner involving generic signatures and java interop flushed out
by seth tisue. Keep that detector fired up seth or the rebel alliance
will surely be crushed. (In fact, I nominate you to write a test suite!)
Closes #4317, no review.
|
|
|
|
|
|
|
| |
Re-enabling the disabled signature test along with changes which allow
it to pass. Closes #4238 again, no review. (But would anyone like to
expand the signature tests? Great idea, extempore!)
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Changed class name from `Main` to `Test` in a failing test case.
|
|
|
|
|
| |
Review by dragos.
|
| |
|
|
|
|
|
|
|
| |
Renamed some methods in icode exception handlers for clarification,
fixed finalizers for 'return' inside a catch block. closes #4240. review
by rytz.
|
|
|
|
|
| |
attempt #2. No review.
|
|
|
|
|
|
|
| |
Reverting some recent signature code and temporarily disabling a test so
I can work this out without shattering the tranquility of the build. No
review.
|
| |
|
|
|
|
|
|
| |
A swing at fixing the remaining test without taking any innocents down
with me. No review.
|
|
|
|
|
|
| |
One still broken. (Very sorry, all laptop and no servers makes jack a
dull tester.) No review.
|
|
|
|
|
|
|
|
| |
Seem to have made a breakthrough with signature correctness. Most of
the remaining troubles were due to inherited members and their foreign
identifiers, but I think I found a simple way to make everyone happy.
Closes #4238, review by moors.
|
|
|
|
|
|
| |
Added an innocuous java BigDecimal -> scala BigDecimal implicit. Cleaned
up some documentation. Closes #2199, no review.
|
|
|
|
|
|
|
| |
Glad to see there was a test case; but we have to push harder when
writing tests to include the key characteristics of the function being
tested. No review.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commas in the generated scaladoc. Example:
< <a id=":+[B>:B, That](B)(C,a,n,B,u,i,l,d,F,r,o,m,[,L,i,s,t,[,B,],,,
,B,,, ,T,h,a,t,]):That"></a>
---
> <a id=":+[B>:B, That](B)(CanBuildFrom[List[B], B, That]):That"></a>
The whole element may be spurious given that this could go unnoticed,
but today was only "Stamp Out Commas" day. No review.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Another lap around the track with generic signatures. At the root of the
issue reported in #4214 is our old friend (fondly remembered from the
days of primitive equality) boxed/primitive unification.
// scala
trait T[A] {
def f(): A
}
// the generic signature spec doesn't allow for parameterizing
// on primitive types, so this cannot remain Char. However
// translating it to Character, as was done, also has issues.
class C extends T[Char] {
def f(): Char = 'a'
}
// Note that neither of the signatures for f, the implementation // or
the bridge method, matches the type parameter. Generic interfaces in
class: T<java.lang.Character> Generic signatures: public char C.f()
public java.lang.Object C.f()
After this commit, primitive type parameters are translated into Object
instead of the boxed type. It was martin's idea, so no review. Closes
#4214.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Long overdue rehaul of presentation compiler tests. Added support for
options file, and switched simple-tests to use the STARR library on the
test classpath.
Put any options you need passed to the presentation compiler in a file
with the same name as the test, ending in '.opts'. Currently it's used
to set the -bootclasspath for simple-tests. Check the contents of
simple-tests.opts for all the options.
IMPORTANT: when committing a new STARR, you need to check this test.
Most likely, you *will* break it otherwise.
review by extempore
|
|
|
|
|
|
|
| |
Break 9 tests, fix 9 tests, realize you broke the test you checked in
between +9 and -9. Fix that and generalize the repl tests a little. I
think we're all the way there. No review.
|
| |
|
| |
|
|
|
|
|
| |
Attempting to fix half my recently imposed breakage. No review.
|
|
|
|
|
|
|
|
|
| |
Altered a check for impl classes to look at the name instead of the
flags, since the flags are wrong. Obviously we should fix the flags or
otherwise better address. Note that the test is well intentioned but
doesn't actually fail with older versions; the crash is not easy to
reproduce even when I simulate the whole repl. Review by dragos.
|
|
|
|
|
|
| |
A fix for ListBuffer's iterator not to blow up when values are changed
during iteration. No review.
|
|
|
|
|
| |
No review.
|
|
|
|
|
| |
about how to obtain a String and how not to. Closes #4297, no review.
|
| |
|
|
|
|
|
|
|
| |
lazy val calls shouldn't be included in pure expressions in general.
closes 4047. fixed also bug in optimizer (was eliminating a.foo call in
the test). review by dragos
|
|
|
|
|
| |
in future attempts. Closes #4291, references #4214, no review.
|
|
|
|
|
|
|
| |
[scaladoc] Comments for lazy vals are printed in documentation. Solution
is hack around issue in compiler's analyser. Closes #3790. Review by
plocinic.
|
|
|
|
|
|
| |
[scaladoc] No companion linking is attempted from inner object to
abstract type member. Closes #4180. No review.
|
|
|
|
|
|
| |
[scaladoc] Specializes upper and lower bounds of abstract type members
and variables to local class context. Closes #3982. No review.
|
|
|
|
|
|
| |
[scaladoc] The "inherited" filter work correctly for inner classes and
object. Closes #3775. No review.
|
|
|
|
|
| |
[scaladoc] Unsightly hack in Scaladoc to close #4086. Review by odersky.
|
|
|
|
|
| |
(only to make you aware of the commit message in r24263.)
|
|
|
|
|
|
| |
[scaladoc] Fixes the way default values and annotations are output in
Scaladoc. Closes #4167. No review.
|
|
|
|
|
|
|
|
| |
[scaladoc] Changed TreeFactory so that it doesn't consume exceptions.
Required fixes to makeAnnotation and makeTree which were throwing
exceptions as a matter of fact. Also code refactoring around annotations
and trees. Closes #4284. No review.
|
|
|
|
|
| |
Partial revert of r24325; tryToSetFromPropertyValue is used by Eclipse.
|
| |
|
|
|
|
|
|
|
| |
Added daemonized() method to ProcessBuilder so I can do things like
start fsc without the jvm failing to exit. More logging to fsc. scala -e
'5' now works again. Closes #4254, review by harrah.
|
| |
|
|
|
|
|
| |
No review.
|
| |
|