| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yin and yang would be pleased: A fix in two parts.
1. Use the name of the imported symbol, rather than the alias, in the generated `Select(qual, name)` tree.
2. Do the opposite in `isQualifyingImplicit`, which performs one part of the shadowing check.
But there is still work to do. The second part of the shadowing check, `nonImplicitSynonymInScope`,
fails to notice this case (irrespective of aliased imports).
// Expecting shadowing #2. Alas, none is cast!
object Test1 {
object A { implicit val x: Int = 1 }
import A.x
def x: Int = 0
implicitly[Int]
}
I'm hitching the residual problem to SI-4270's wagon.
|
| |\
| |
| | |
SI-5760: Improve error message for package$Klass conflict with Klass
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added a clarification to DoubleDefError for when the previous symbol
was in the package object but current symbol is not.
This was actually supposed to be an opportunity to hack partest to
run the two-step failing compilation, but somebody beat me to it and my
rebase failed.
The next hacking opportunity might be to add .pt script files! The
possibilities are endless.
|
| |\ \
| | |
| | | |
Test case closes SI-3880.
|
| | |/
| |
| |
| | |
virtpatmat ftw.
|
| |\ \
| | |
| | | |
Pending test for SI-3899.
|
| | |/
| |
| |
| |
| |
| | |
The super accessor for the Java varargs method impedes Uncurry's
efforts to convert repeated arguments to an Array. I'm not sure how
to fix that.
|
| |\ \
| | |
| | | |
Fix @varargs forwarder generation in the presence of nested templates.
|
| | | |
| | |
| | |
| | | |
Uncomment a line, as was the intent.
|
| | |/
| |
| |
| |
| |
| | |
Makes `newMembers` a Map[Symbol, Buffer[Tree]] to ensure we add the forwarders to the right template.
Closes SI-5125.
|
| |\ \
| |/
|/|
| | |
Fix SI-4717: lazy val declared inside an anonymous class inside a specialized
context no longer crashes Duplicators.
|
| | |
| |
| |
| | |
Should be checking if the owner of the new symbol is a class, not the new symbol itself.
|
| | |
| |
| |
| |
| |
| |
| | |
Only adding a lazy val into list of declarations if the owner is a class.
Review by dragos.
@mention dragos
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
A lazy val declared inside an anonymous class inside a specialized
context no longer crashes Duplicators.
Previously, a duplicated lazy val was assigned to the wrong owner
in Duplicators:
def x[B >: A]: Unit = new Bounds[B] {
lazy val it = ??? // def or val okay
}
Above, the `it` in `$anon` in `x$mcZ$sp` had its owner set to `x$mcZ$sp`
instead of `$anon`. This crashed the typer when it had to retype its
lazy accessor, because there was no `lazy var it` in `$anon$`.
Furthermore, the duplicated symbol wasn't being added to the list of
declarations of `$anon`.
Changes:
1) `invalidate` in Duplicators takes an additional parameter which is
the new owner of the new symbol that has to be duplicated. If this parameter
is set to `NoSymbol`, then the new owner is `context.owner`, as before.
2) the newly created lazy val symbol is being added to the list of
declarations of its new owner.
Removes debugging output from the previous commit.
Review by dragos.
@mention dragos
|
| | | |
|
| |\ \
| | |
| | | |
Fix SI-5055 (for real). Implement keyboard shortcuts in Scaladoc. Browsing is fun again!
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
Fix SI-4812: handle trait method with Symbol as default for argument
|
| | | | |
| | | |
| | | |
| | | | |
Remove default arguments from parameter ValDefs in UnCurry.
|
| |\ \ \ \
| | | | |
| | | | | |
fix SI-5044: better error message on cyclic error and named/default args
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Fix SI-2488: allow named arg, in original position, before positionals
|
| | | |_|/ /
| |/| | | |
|
| |\ \ \ \ \
| |_|_|/ /
|/| | | | |
Fix SI-5801: error messages regression.
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Fixes SI-4461.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
No review.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix SI-5544
|
| | | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
Type-check annotations in a context with a localDummy owner
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SIP-14: clean ups and fixes by @viktorklang
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Fix 4138
|
| | | |/ / / /
| |/| | | | |
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Test case for SI-3844 - fixed by #virtpatmat @adriaanm
|
| | |/ / / / |
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Fix SI-4928
|
| | | |_|/ /
| |/| | |
| | | | |
| | | | | |
better error message when a parameter is first defined positionally, then with a named argument.
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
fixes resetAttrs
|
| | | | | | | |
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Added infrastructure to enable easy enrichment of GenTraversables.
|
| | | | | | | |
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
A band-aid solution for SI-5803.
|
| | | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since ae5ff662, resetAttrs duplicates trees, which doesn't preserve ApplyConstructor.
My attempt to modify TreeCopier to do so proved trickier than expected.
In any case, ApplyConstructor is not long for this world, and is only used in tree printing
to distinguish `new X` from regular Apply trees, so this should suffice pending full surgery.
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes SI-5623 on SyncVar. Deprecates set & unset.
Review by @phaller.
|
| | | | | | | |
|
| | |\| | | | |
|
| | | |/ / /
| |/| | | |
|
