| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Removes the stubs left out to appease the old starr, fixes macro tests.
|
|
|
|
|
|
|
|
|
| |
Builds a starr that uses stuff from scala.reflect.macros for macro activities.
Crucial makro thingies (such as makro.Context or makro.internal.macroImpl)
are temporarily left in place, because they are necessary for previous starr.
Macro tests will be fixed in a dedicated commit, so that they don't pollute
meaningful commits, making the life easy for reviewers and spelunkers.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These options were meant to be used to bootstrap macros defined in our codebase
However we can bootstrap perfectly without any additional effort, because
library classpath classloader can delegate to tool classpath classloader to
load macro implementations from starr.
Since then (for several months) this functionality hasn't proven to be useful,
neither anyone on the mailing list or stackoverflow asked questions about it
(even despite it was explicitly mentioned in the "cannot load macro impl"
error message).
Hence I suggest that it is totally unnecessary and should be removed.
|
|
|
|
|
|
|
|
|
|
| |
Since the previous commit the compiler doesn't need any help
to find out that fast-tracked macros are macros. Hence I'm
replacing their RHSes with the universal ??? body.
This way macro definitions defined in scala (for example,
tag materialization macros or certain string formatters)
won't stand in the way of the changes to the macro system.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In our codebase we have a bunch of macros, and some of those macros
(namely, tag materialization macros and string context "f" formatter)
are used inside the compiler itself.
The logic of those macros is hardwired into starr's fast track,
so it doesn't rely on any of the subsystems of the macro engine
to be located, bound and executed.
But to trigger this logic we need to color these macros as macros, i.e. as
term symbols having the MACRO flag. Currently this works automatically,
because fast track macros (the same as regular macros) have their rhs
in the "macro ???" form. Having seen the "macro" keyword, the compiler knows
that the corresponding def declares a macro and sets the MACRO flag.
As the latest refactoring attempt has shown, the "macro" in "macro ???"
is unnecessary and might stand in the way of macro refactorings. After all
if some symbol is in the fast track registry, then it's definitely a macro.
Hence I'm changing the compiler to not need the "macro" keyword in declarations
of fast track macros anymore.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a bunch of test methods to symbols to cover public flags:
(e.g. isPrivate, isFinal, isOverride, isImplicit, etc). I'd argue that
the API duplication w.r.t flag sets is trumped by unified interface
to tests and better encapsulation.
Also updated the API to be easier to understand after prior exposure
to Java or .NET reflection APIs:
1) Added typeParams to TypeSymbol and ClassSymbol.
2) Renamed MethodSymbol.resultType to returnType.
3) Removed the distinction between MethodSymbol.params vs MethodSymbol.allParams
now we just have MethodSymbol.params: List[List[Symbol]].
|
|
|
|
|
|
|
|
| |
Adds informative toString for InstanceMirror, FieldMirror,
MethodMirror (for methods and constructors), ClassMirror and ModuleMirror.
Universe mirrors (e.g. JavaMirrors or compiler mirrors) already have good
toString methods that show their affiliation and/or classpaths.
|
|
|
|
|
|
|
| |
This renaming arguably makes the intent of `asType` more clear,
but more importantly it shaves 6 symbols off pervasive casts that
are required to anything meaningful with reflection API
(as in mirror.reflectMethod(tpe.member(newTermName("x")).asMethodSymbol)).
|
|
|
|
|
|
|
| |
1) Removed unnecessary (i.e. implementable with pattern matching) type APIs.
2) Renamed isHigherKinded to takesTypeArgs making it easier to understand.
2) typeParams and resultType have been moved from MethodType to MethodSymbol
Strictly speaking they are superfluous, but they are used very often.
|
|
|
|
|
|
| |
This works around SI-5736 that's been deemed too risky to be fixed in 2.10.0.
A reflection newbie will be unlikely to acquire a field symbol from its name,
but the `accessed` method provides an easy way to navigate to it from a getter.
|
|
|
|
| |
Things like tpe.member("foo").isSkolem don't make much sense.
|
|
|
|
|
|
|
|
| |
Flag ops now only include | and hasFlag,
flag bearer ops now only include flags and hasFlag.
These abstractions are enough to implement everything else,
so let's stick to them for the sake of minimalism.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Firstly this unifies the reflection API - now both decls and members
return Scope (not Scope and List[Symbol] as it were before).
Secondly this fixes SI-5732 without having to sort the result of members.
Type.members now returns Scope, a distinguished type, which has the
`sorted` method, which does the required sorting if necessary.
Also removes nonPrivateMembers and nonPrivateDeclarations to keep the API
minimalistic (as can be seen from their implementation in internal.Types
they are just members and decls with bridges and private members removed).
|
|\
| |
| | |
SI-5751 cleans up toolboxes for the release
|
| |
| |
| |
| |
| |
| |
| |
| | |
Removes the `freeTypes` parameters on `typeCheckExpr` and `runExpr`,
since we now have public `substituteTypes` on both trees and types.
Also implements long-awaited `inferImplicitValue` and `inferImplicitView`
(thanks to Miles Sabin for nudging me!)
|
|\ \
| | |
| | | |
I actually managed to hit the limit of Scala signature annotation not fi...
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fitting into a single string (high five everyone) and entered the undisovered region of arrEncode in GenASM.
arrEncode returns Array[String] so asm.AnnotationWriter is not going to like it.
Already discussed with @magarciaEPFL but please review again.
|
|\ \ \
| |/ /
|/| | |
Added more variants to achieve getLinkPos
|
| |/
| |
| |
| | |
getLinkPos is known to be flakey. This commit tries some variants and logs what failed.
|
|\ \
| |/
|/| |
Fixed maddening "..." lately in printed types.
|
| |
| |
| |
| |
| |
| | |
I screwed around with type printing for a long time and now I have
to be done, so I suggest we accept the imperfection in here for now
because it's still way ahead of "..." as types go.
|
| |
| |
| |
| |
| |
| | |
This must have been me when I eliminated some of the
remaining distinction between TypeRef(_, moduleClass, Nil) and
SingleType(_, moduleClass). Sorry I didn't track it down sooner. Review by anyone who is around because this is overdue.
|
|\ \
| | |
| | | |
SI-5866 Support casting null to value classes
|
| | |
| | |
| | |
| | | |
The fix now supports null.asInstanceOf[C] where C is a value class that wraps a primitive type.
|
|\ \ \
| | | |
| | | | |
ClassTag.Nothing now throws an exception
|
| |/ /
| | |
| | |
| | |
| | | |
Nothing is a bottom type, so it doesn't make much sense for it to have
a meaningful erasure (ClassTag.Nothing.runtimeClass).
|
|\ \ \
| | | |
| | | | |
Fixed SI-5031. Only consider classes when looking for companion class.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
sym.effectiveOwner revealed this piece of inconsistency. companionModule
is fine because similar check is there already.
Review by @paulp.
|
|\ \ \
| | | |
| | | | |
Closes SI-5882
|
| | | |
| | | |
| | | |
| | | | |
I changed the SIP and added a test.
|
| | | |
| | | |
| | | |
| | | | |
I have added a restriction that value classes may not contain inner classes or objects. This makes sense as the "outer" field of any such classes or objects would be ephemeral, with surprising results. SIP-15 has been changed accordingly.
|
|\ \ \ \
| | | | |
| | | | | |
SI-2038 make pt fully-defined when typing Typed
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
dropExistential turns existentials in the expected type (pt) that's passed to `typed`
into `BoundedWildcardType`s, but those should not end up in trees
when typing a `Typed` node, we didn't check for the type being fully defined (`isFullyDefined`)
(and thus did not make it fully defined by turning these BWTs into existentials again using `makeFullyDefined`)
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove resolveOverloaded
|
| | |_|_|/
| |/| | |
| | | | |
| | | | | |
It was decided to remove it until the next release
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fixed SI-5603. Early definitions now get transparent positions.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | | |
This includes a fix for a minor problem described in #594 -
ensureNonOverlapping still focuses on default position when outside of early defs.
Review by @dragos, @odersky.
|
|\ \ \ \
| | | | |
| | | | | |
Avoids loading scala.package and scala.reflect.package from source if a ...
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
classfile exists.
We know that loading these packages from source leads to compilation errors. To reproduce: Update scala.reflect.package, make sure it is on the source path and recompile anything using it. You will get a number of errors having to do with ClassTags and macro expansions. With the patch, these errors go away because the package is not loaded as long as a classfile exists.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Closes SI-5878
|
| | |_|_|/
| |/| | |
| | | | |
| | | | | |
We need to impose an additional rule on value classes: They may not unbox directly or indirectly to themselves.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
IDE improvements, with particular focus on making worksheets work.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Debug changes
|
| | | | |
| | | | |
| | | | |
| | | | | |
Adds a raw string interpolator raw"..." which does not do any escape sequence processing.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Adds method askForResponse which returns a response immediately instead of waiting for a result. That way, one can wait for an ask's result using a timeout.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Code instrumentation needs to see a consistent snapshot of a source file. To achieve that we disable interrupts during getInstrumented.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
To try it out:
run "instrument worksheet" as usual in the REPL. Worksheet needs to have enclosing object definition. Say it is named "Obj".
This will generate a file Obj$instrumented. You can compile that file separately and run it using Java. It should reproduce itself.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`ScriptSourceFile` should not hard-code `OffsetPosition`.
|
| | |_|/ /
| |/| | |
| | | | |
| | | | | |
The presentation compiler should support script source files as well, but it needs range positions. This commit
fixes an oversight when `RangePosition` was introduced.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Partest instrumentation fixes
|