summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Override checks and self-types still needed som...Paul Phillips2011-01-086-4/+24
| | | | | | | | | Override checks and self-types still needed some work (ticket #2808.) I believe this is the right change. The modifications in parallel and actors were a result of the files failing to compile after the change to allOverriddenSymbols. (I am taking the position that that aspect is a feature.) Review by malayeri, odersky.
* Great moments in code reuse:Paul Phillips2011-01-0716-87/+70
| | | | | | | | | | | | | | | | | | | | | | def isRootOrEmptyPackageClass(s: Symbol) = s.isRoot || s.isEmptyPackageClass def isRootOrEmpty = (this == EmptyPackageClass) || (this == RootClass) def isEffectiveRoot = isRoot || isEmptyPackageClass // last one actually not quite identical def isUnqualified(n: Name) = n match { case nme.ROOT | nme.EMPTY_PACKAGE_NAME => true ; case _ => false } I was responsible for at least half of these. Now it's only isEffectiveRoot. Also, I have always found it warty that we have to specify Nothing and Any as upper bounds. I gave the TypeBounds companion object a few obvious methods: def empty: TypeBounds = apply(NothingClass.tpe, AnyClass.tpe) def upper(hi: Type): TypeBounds = apply(NothingClass.tpe, hi) def lower(lo: Type): TypeBounds = apply(lo, AnyClass.tpe) It's a lovable patch. No review.
* Made NamesDefault more robust to support idempo...Martin Odersky2011-01-073-6/+23
| | | | | Made NamesDefault more robust to support idempotent compilation.
* Added test for #4072. no reviewHubert Plociniczak2011-01-072-0/+14
|
* Deprecate Cell.Hubert Plociniczak2011-01-071-0/+1
|
* Closes #4047. Review by oderskyHubert Plociniczak2011-01-073-5/+47
|
* Closes #4072.Hubert Plociniczak2011-01-074-26/+62
|
* re-added @SerialVersionUID(0) to anonymous func...Lukas Rytz2011-01-072-3/+4
| | | | | re-added @SerialVersionUID(0) to anonymous function classes.
* moved debug println under if(settings.debug.val...Martin Odersky2011-01-071-0/+1
| | | | | moved debug println under if(settings.debug.value) condition.
* Missing file from last commit.Martin Odersky2011-01-071-1/+5
|
* Documented Picklers.Martin Odersky2011-01-074-83/+319
|
* Test case change.Aleksandar Pokopec2011-01-072-2/+2
| | | | | No review
* Implemented a (slower) workaround for parallel ...Aleksandar Pokopec2011-01-0723-130/+573
| | | | | | | | Implemented a (slower) workaround for parallel vectors. Implemented group by. No review.
* Changed foreach to pforeach.Aleksandar Pokopec2011-01-077-16/+23
| | | | | No review.
* Apparently my flailing attempts to make things ...Paul Phillips2011-01-074-245/+283
| | | | | | | | | | | | | | | | | Apparently my flailing attempts to make things faster earned me the pity of Tiark, who sent this monster patch which he probably dashed off before the appetizers had been cleared away. All the steak is his but I threw in a little sizzle so I could feel like a part of things. It knocks about a bazillion miniseconds off the time spent in implicit search. This is the same patch martin already endorsed, give or take several hundred lines of diff, so I will say no review, even though I know it will be hard to look away. I trimmed most of the "speculative code" (that is, the commented out bits) because it's getting awfully busy along those sidelines. I will preserve the ideas in some more structured form.
* The shutdown hook installed by jline has made l...Paul Phillips2011-01-065-25/+48
| | | | | | | | | | | The shutdown hook installed by jline has made life difficult for sbt for a while. This changes jline not to install it, and alters the scala startup script to trap exit and re-enable echo on recognizably unix platforms. In addition it no longer installs a shutdown hook to flush the repl history to disk, instead flushing after every line. Any bash reviewers out there? Unless someone raises a hand, no review.
* One reversal wrt Pauls TypeRef -> typeRef changes.Martin Odersky2011-01-061-1/+4
|
* Replay now enabled for presentation compiler.Martin Odersky2011-01-0610-907/+666
|
* I took the following comments at their word:Paul Phillips2011-01-067-31/+29
| | | | | | | | | | | | | | // Cannot be created directly; one should always use `singleType' // for creation. Cannot be created directly; one should always use // `refinedType' for creation. Cannot be created directly; one should // always use `typeRef' for creation. (@M: Otherwise hashing breaks) This involved altering about 15 locations. If there was a rhyme or a reason as to why those particular places were entitled to ignore the "always" dictate, I trust it will emerge from some corner now. Until then, it's nice to see some code following its official marching orders. Review by odersky.
* Renamed the files whose names have fallen out o...Paul Phillips2011-01-063-0/+0
| | | | | | | Renamed the files whose names have fallen out of sync with their contents thereby consigning us to ant's version of groundhog day. No review.
* Avoids the creation of an amazing 106,700,793 e...Paul Phillips2011-01-052-14/+33
| | | | | | | | | | | | | Avoids the creation of an amazing 106,700,793 empty arrays (I counted on my fingers) during the compilation of quick.lib and quick.comp by reusing an empty Array[Object]. (And another ten million or so after quick.comp, but who is counting.) It sounds like it would make a bigger difference than it does. Also eliminated some strange indirection from WrappedArray to LowPriorityImplicits back to WrappedArray on each creation. Review by dragos.
* De-finalized equals/hashCode on Trees so people...Paul Phillips2011-01-051-2/+2
| | | | | | | De-finalized equals/hashCode on Trees so people ill-advisedly creating custom Trees with non-reference equality can continue doing their ill-advised thing. No review.
* Fixed a bad interaction between overloading, de...Iulian Dragos2011-01-053-3/+30
| | | | | | Fixed a bad interaction between overloading, default parameters and specialization. Closes #3896, no review.
* closes #4044.Adriaan Moors2011-01-053-1/+33
|
* Eliminated 16 avoidable closure objects in Stream.Paul Phillips2011-01-044-46/+40
|
* Disentangled scaladoc and the presentation comp...Iulian Dragos2011-01-048-15/+14
| | | | | | | | | | | Disentangled scaladoc and the presentation compiler. Now there are different flags, forInteractive and forScaladoc, instead of the overloaded onlyPresentation. While it is unfortunate to have these flags, I know of no easy way to customize the typer (the behavior they control is pretty deep into the analyzer). This shaves off around 100MB of unnecessary docComments from the presentation compiler. review by odersky, dubochet.
* Towards a replay framework for the presentation...Martin Odersky2011-01-049-58/+1110
| | | | | Towards a replay framework for the presentation compiler
* Closes #3869. no review.Iulian Dragos2011-01-042-1/+15
|
* One more try with the lazy clearing.Eugene Vigdorchik2011-01-041-3/+5
|
* Closes #3687, #3719, #3950, #3616.Hubert Plociniczak2011-01-047-78/+83
|
* Fixed infinite loop on call to super from a spe...Iulian Dragos2011-01-043-1/+71
| | | | | | | Fixed infinite loop on call to super from a specialized method. This happened only on illegal specialized inheritance. Closes #3651, no review.
* Protected protected constructors.Paul Phillips2011-01-043-1/+47
| | | | | | since r19547, which was for #1836 but loosened the noose too much. Closes #4128, review by odersky.
* Added some more debugging tools for printing ty...Paul Phillips2011-01-044-30/+83
| | | | | | Added some more debugging tools for printing types. Squirrelled it away in a type debugging trait. No review.
* Some profiler changes.Paul Phillips2011-01-0410-47/+160
| | | | | | | | | | | after each phase, so all the allocations are partitionable by phase in the profiler. I also changed the name of -Yprofile-resident to -Yprofile-memory and had it snapshot after the run instead of between them, so it is usable for regular scalac usage as well. Added tools/profile_scalac which can be used as a drop-in replacement which handles some tedious setup. Review by dragos.
* Modified generic companion apply to call empty ...Paul Phillips2011-01-044-7/+15
| | | | | | | | Modified generic companion apply to call empty if there are no arguments, so something like Set() does not generate unnecessary garbage. Also found some immutable classes which don't reuse an empty object for emptiness, and gave them one. No review.
* Misc icode cleanup. No review.Paul Phillips2011-01-043-25/+21
|
* Temp rollback.Eugene Vigdorchik2011-01-031-4/+2
|
* Some minor Tree optimizations. No review.Paul Phillips2011-01-032-12/+9
|
* There was a massive 30+ line cut and paste betw...Paul Phillips2011-01-031-79/+79
| | | | | | | | | | | There was a massive 30+ line cut and paste between isPlausiblyCompatible and normSubType. Since I already painstakingly optimized the former, it was incredibly depressing to discover an exact copy of the "before" code pasted into a method later in the same file. I can't begin to convey how much unnecessary difficulty this sort of thing brings for us. Friends, romans, countrymen, put down your ctrl-Vs. Review by anyone who might be tempted to perform similar cutting and pasting in the future.
* Working my way through popular methods with a m...Paul Phillips2011-01-034-86/+75
| | | | | | | | | | Working my way through popular methods with a microscope looking to shave off some time. Along the way fighting off various poor software engineering practices no doubt perpetrated in haste by people who suffered grave regrets afterward, such as the passing around of listbuffers to be modified by the callee, and a more egregious one to follow. No review.
* Since r22374 isCompatible and isCompatibleArg h...Paul Phillips2011-01-033-32/+21
| | | | | | | Since r22374 isCompatible and isCompatibleArg have been bit-for-bit identical methods. Deleted isCompatibleArg. Also gave some structure to the act of disabling implicit search. No review.
* Clear caseClassOfModuleClass lazily, otherwise ...Eugene Vigdorchik2011-01-031-2/+4
| | | | | | | Clear caseClassOfModuleClass lazily, otherwise we lose information calculated during the namer phase upon next run triggered by the presentation compiler. Review by odersky.
* Misc uninteresting tidbits to take some weight ...Paul Phillips2011-01-0210-33/+61
| | | | | | Misc uninteresting tidbits to take some weight off overly large patches in progress. No review.
* Removed the Name => TypeName implicit conversion.Paul Phillips2011-01-0117-117/+112
| | | | | | | | | | questions start to arise as the ability to distinguish between type and term names becomes more fully realized: particularly that the ability to distinguish between TermSymbols and TypeSymbols has not come along with the names. In any case, this is more tedious than I might have anticipated but mostly because it's blazing a trail of typiness to ease the path for others. No review.
* Knocking a few instructions off isSubType2, and...Paul Phillips2011-01-011-34/+26
| | | | | | Knocking a few instructions off isSubType2, and dodging some list traversals in SubstMap. Review by odersky.
* More comprehensive escaping for compiler String...Paul Phillips2011-01-011-9/+19
| | | | | More comprehensive escaping for compiler Strings/Chars. No review.
* Generalized a pile of duplicated type caching c...Paul Phillips2011-01-015-49/+117
| | | | | | | | | | | Generalized a pile of duplicated type caching code, but it's still largely undeployed because I haven't figured out how to make it as fast as the copy-pasted version, which bugs me like you wouldn't believe. Cannot deal with making "Sophie's Choice" between performance and lack of duplication. I left one deployment in because it fixed a bug, or at least so I see it: can't see why one would want the two absent error messages in t2641.check. Review by odersky.
* A very conservative extraction of some of the F...Paul Phillips2011-01-013-159/+179
| | | | | | | | A very conservative extraction of some of the FOOmode logic because it lends itself to encapsulation and that's something we need more of. I am doing everything these days with spectacularly high performance paranoia so you don't even need to ask. (It is if anything faster.) No review.
* Some performance tweaks to ResizableArray.Paul Phillips2010-12-311-8/+9
|
* Add option -toolcp to our runner script.Iulian Dragos2010-12-311-1/+7
|