| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |\
| |
| | |
New take on SI-6534, value classes.
|
| | |
| |
| |
| |
| |
| | |
Only exclude hashCode and equals from being overridden in
value classes, not other synthetics which may turn up such
as case class methods.
|
| | |
| |
| |
| |
| | |
Don't prohibit equals and hashCode in universal traits;
instead, always override them in value classes.
|
| |\ \
| | |
| | | |
Fixes SI-6500 by making erasure more regular.
|
| | |/
| |
| |
| |
| |
| | |
With the introduction of value classes, erasure uses specialErasure where a value class C with underlying type T is unboxed to an ErasedValueType. ErasedValue types are eliminated on phase later, in post-erasure. This was done everywhere, except in the parameter types of bridge methods. That was a mistale, because that way bridge methods could not do the boxing/unboxing logic triggered by ErasedValueTypes.
Note: there is one remaining use of erasure (not specialErasure) in Erasure.scala. I put in a comment why that is OK.
|
| |\ \
| | |
| | | |
SI-6556 no assert for surprising ctor result type
|
| | |/
| |
| |
| |
| |
| |
| | |
Previous fix to value classes uncovered some questionable cases in the backend where result types of constructor signatures are surprising. It's not a big deal because these types will be ignored afterwards anyway. But
the method uncovered some questionable situations which we should follow up on. However, breaking 2.9 code because of this is way too harsh. That's why the asserts were converted to warnings.
review by @paulp, @adriaanm
|
| |\ \
| | |
| | | |
SI-6577 Make actors-migration an external module
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Removes actors-migration hooks from partest
* Removes actors-migration code
* removes actors-migration tests
* removes actors-migration distribution packaging.
|
| | |\ \
| |/ /
|/| | |
|
| |\ \ \
| | | |
| | | | |
SI-6578 Harden against synthetics being added more than once.
|
| | | |/
| |/|
| | |
| | |
| | | |
Don't add synthetic methods if they already contain synthetic
methods from the set we're about to add.
|
| |\ \ \
| | | |
| | | | |
SI-6581 fixed by inlining `Actor.self`.
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
This avoids the necessary type cast that was preventing leakage of internal migration classes.
Review by @phaller
|
| |\ \ \
| | | |
| | | | |
Fixes SI-5031 for separate compilation scenario.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | | |
When you have a conflicting member in package object and normal package that share the same namespace we remove the latter ClassSymbol from the scope. Now, this has an unpleasant consequence that companionClass/companionModule/companionSymbol no longer work correctly as they rely on finding the correspondent symbol using decls of the owner.
This fixes the problem of SI-5031 for separate compilation. Why the above change matters for finding foo.bar.Foo? Because when parsing the class we needed information about the static module (and we have the correct module symbol when completing the info). It's just that 043ce6d0565c9d5d960 relied on no longer valid assumptions. So we were getting NoSymbol and sym.exist was failing.
Obviously a more complete solution would be better if we didn't rely on the scope but that's too big to change for 2.10.0.
|
| |\ \ \
| |/ /
|/| | |
SI-6575 Plug inference leak of AbstractPartialFunction
|
| | | |
| | |
| | |
| | | |
In response to pull request feedback.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
It's safe to replace `localTyper.typed(atPos(pos)(tree))` with
`localTyper.typedPos(pos)(tree)` given that we're all in the
same cake and we'll get to the same `atPos`.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Usually this isn't needed, as partial functions can only be
defined with an expected type. But if that expected type is
and inherited method return type, the actual type of the partial
function literal is used, and the implementation detail of
`AbstractPartialFunction[A, B] with Serializable` leaks out.
After this change, the inferred types match those from
Scala 2.9.2.
ticket/6575 ~/code/scala scalac29 -Xprint:typer test/files/pos/t6575a.scala | grep def > 29.txt
ticket/6575 ~/code/scala squalac -Xprint:typer test/files/pos/t6575a.scala | grep def > 210.txt
ticket/6575 ~/code/scala diff -u 29.txt 210.txt
--- 29.txt 2012-10-28 13:51:07.000000000 +0100
+++ 210.txt 2012-10-28 13:51:20.000000000 +0100
@@ -1,7 +1,16 @@
def foo: PartialFunction[Int,Int]
def /*Y*/$init$(): Unit = {
- absoverride def foo: PartialFunction[Int,Int] = ((x0$1: Int) => x0$1 match {
+ absoverride def foo: PartialFunction[Int,Int] = {
+ def <init>(): anonymous class $anonfun = {
+ final override def applyOrElse[A1 >: Nothing <: Int, B1 >: Int <: Any](x$1: A1, default: A1 => B1): B1 = (x$1: A1 @unchecked) match {
+ final def isDefinedAt(x$1: Int): Boolean = (x$1: Int @unchecked) match {
def /*Z*/$init$(): Unit = {
- absoverride def foo: PartialFunction[Int,Int] = ((x0$2: Int) => x0$2 match {
+ absoverride def foo: PartialFunction[Int,Int] = {
+ def <init>(): anonymous class $anonfun = {
+ final override def applyOrElse[A1 >: Nothing <: Int, B1 >: Int <: Any](x$1: A1, default: A1 => B1): B1 = (x$1: A1 @unchecked) match {
+ final def isDefinedAt(x$1: Int): Boolean = (x$1: Int @unchecked) match {
def /*Comb*/$init$(): Unit = {
- absoverride def foo: PartialFunction[Int,Int] = ((x0$3: Int) => x0$3 match {
+ absoverride def foo: PartialFunction[Int,Int] = {
+ def <init>(): anonymous class $anonfun = {
+ final override def applyOrElse[A1 >: Nothing <: Int, B1 >: Int <: Any](x$1: A1, default: A1 => B1): B1 = (x$1: A1 @unchecked) match {
+ final def isDefinedAt(x$1: Int): Boolean = (x$1: Int @unchecked) match {
|
| |/
|
|
|
|
|
| |
* Removes actors-migration hooks from partest
* Removes actors-migration code
* removes actors-migration tests
* removes actors-migration distribution packaging.
|
| |\
| |
| | |
Disabled generation of _1, _2, etc. methods.
|
| | |
| |
| |
| |
| |
| |
| | |
This was part of the introduction of ProductN, which had
to go back into pandora's box because of issues with cycles
during typing. These should have been reverted along
with it.
|
| |\ \
| | |
| | | |
SI-6526 Tail call elimination should descend deeper.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
It wasn't traversing into Select nodes nor into the receiver of
a tail call.
|
| |\ \ \
| |_|/
|/| | |
Fix SI-6552, regression with self types.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| | |
In 6eb55d4b7a we put in a remedy for an old issue SI-4560 which
had accumulated a number of sketchy partial remedies which carried
no tests to illustrate their necessity. Looks like at least one of
those was doing something useful. Here's to reversion-reversion.
This reverts commit c8bdf199, which itself reverted cb4fd6582.
|
| |\ \
| | |
| | | |
Fix for SI-6537, inaccurate unchecked warning.
|
| | |/
| |
| |
| |
| |
| |
| |
| | |
I found a more direct expression of the unchecked logic,
which should be much easier for others to verify. But the
bug being fixed here is that the unchecked checking happens
too early, and the sealed children of a symbol are not yet
visible if it is being simultaneously compiled.
|
| |\ \
| | |
| | | |
avoid single-arg assert where harmful in duration-tck
|
| | |/ |
|
| |\ \
| | |
| | | |
Fixes SI-6170: issue with dragging scaladoc splitter over central iframe
|
| | | | |
|
| |\ \ \
| |_|/
|/| | |
Changes Tree and Type members from vals to defs.
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Explanatory email:
The reflection API defines a great many abstract vals. I would
like these all to be defs. I'm sending a pull request to that end.
Reasons: for starters, they should default to being defs. It's a
decision to use vals for which one should have to supply reasons.
The reason for THAT is that defs can be implemented with vals, but
not vice versa.
Why does this matter? I can't find my long writing on the subject
of TypeRef. In short, we waste a huge amount of memory on its
fields, because given the way TypeRef is defined, each one demands
a pre, a sym, and an args. Except that somewhere between 1/3 and
1/2 have prefix "NoPrefix", and somewhere between 1/3 and 1/2 have
args "Nil". We know it at creation time, but we give every typeref
the whole field anyway.
At present there's no way to fix this which has acceptable
performance - i.e. custom subclasses save us lots of memory, but
are too much slower for having to use an extractor - but there's
no reason we should have to choose, and I fully expect to fix it
eventually. Let's not make that fix into a breaking change by
abstractly defining "pre" and "args" as field-requiring vals.
|
| |\ \
| | |
| | | |
Pullrequest/reflection docs
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
Additionally includes improvements, formatting fixes, and link
additions and fixes.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
blocked by SI-6511
|
| | | |
| | |
| | |
| | | |
and warning cleanup
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Oh those pretty groups, u gotta luv'em...
|
| | | | |
|
| | | | |
|
| | | | |
|
